Skip to content

Commit 2a29052

Browse files
keertipCommit Queue
authored andcommitted
Add extension on Completer to simplify code.
Change-Id: Ida74cf78f5cedf2c4b3c806c7aaef92fa86f6d61 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397960 Commit-Queue: Keerti Parthasarathy <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent 05696d5 commit 2a29052

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

pkg/analysis_server/lib/src/lsp/lsp_analysis_server.dart

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -561,9 +561,7 @@ class LspAnalysisServer extends AnalysisServer {
561561
} else {
562562
showErrorMessageToUser('Unknown message type');
563563
}
564-
if (completer != null && !completer.isCompleted) {
565-
completer.complete();
566-
}
564+
completer?.setComplete();
567565
} on InconsistentAnalysisException {
568566
sendErrorResponse(
569567
message,
@@ -572,9 +570,7 @@ class LspAnalysisServer extends AnalysisServer {
572570
message: 'Document was modified before operation completed',
573571
),
574572
);
575-
if (completer != null && !completer.isCompleted) {
576-
completer.complete();
577-
}
573+
completer?.setComplete();
578574
} catch (error, stackTrace) {
579575
var errorMessage =
580576
message is ResponseMessage
@@ -592,9 +588,7 @@ class LspAnalysisServer extends AnalysisServer {
592588
),
593589
);
594590
logException(errorMessage, error, stackTrace);
595-
if (completer != null && !completer.isCompleted) {
596-
completer.complete();
597-
}
591+
completer?.setComplete();
598592
}
599593
}, socketError);
600594
}
@@ -1395,3 +1389,12 @@ class LspServerContextManagerCallbacks
13951389
);
13961390
}
13971391
}
1392+
1393+
extension on Completer<void> {
1394+
void setComplete() {
1395+
if (isCompleted) {
1396+
return;
1397+
}
1398+
complete();
1399+
}
1400+
}

0 commit comments

Comments
 (0)