analyzer: correct invalid text about unsupported YAML options

Maybe these errors were once only used for the plugin section, but
they are now used to report any unknown YAML options in any section.

Change-Id: I31c9369c1cc7c6d18426036d69b3a5531f2db7ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390922
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart

@@ -287,11 +287,11 @@ class AnalysisOptionsWarningCode extends ErrorCode {
     "The option '{1}' isn't supported by '{0}'.",
   );
 
-  ///  An error code indicating that a plugin is being configured with an
+  ///  An error code indicating that a YAML section is being configured with an
   ///  unsupported option where there is just one legal value.
   ///
   ///  Parameters:
-  ///  0: the plugin name
+  ///  0: the section name
   ///  1: the unsupported option key
   ///  2: the legal value
   static const AnalysisOptionsWarningCode UNSUPPORTED_OPTION_WITH_LEGAL_VALUE =
@@ -301,11 +301,11 @@ class AnalysisOptionsWarningCode extends ErrorCode {
         "option: '{2}'.",
   );
 
-  ///  An error code indicating that a plugin is being configured with an
+  ///  An error code indicating that a YAML section is being configured with an
   ///  unsupported option and legal options are provided.
   ///
   ///  Parameters:
-  ///  0: the plugin name
+  ///  0: the section name
   ///  1: the unsupported option key
   ///  2: legal values
   static const AnalysisOptionsWarningCode UNSUPPORTED_OPTION_WITH_LEGAL_VALUES =

pkg/analyzer/messages.yaml

@@ -231,23 +231,23 @@ AnalysisOptionsWarningCode:
     problemMessage: "The option '{1}' isn't supported by '{0}'. Try using the only supported option: '{2}'."
     hasPublishedDocs: false
     comment: |-
-      An error code indicating that a plugin is being configured with an
+      An error code indicating that a YAML section is being configured with an
       unsupported option where there is just one legal value.
 
       Parameters:
-      0: the plugin name
+      0: the section name
       1: the unsupported option key
       2: the legal value
   UNSUPPORTED_OPTION_WITH_LEGAL_VALUES:
     problemMessage: "The option '{1}' isn't supported by '{0}'."
     correctionMessage: "Try using one of the supported options: {2}."
     hasPublishedDocs: false
     comment: |-
-      An error code indicating that a plugin is being configured with an
+      An error code indicating that a YAML section is being configured with an
       unsupported option and legal options are provided.
 
       Parameters:
-      0: the plugin name
+      0: the section name
       1: the unsupported option key
       2: legal values
   UNSUPPORTED_VALUE: