[status_file] Status file linting should not check for non-existing files when given input on stdin

jensjoha · Commit Queue · commit 2b5b3163e6b9 · 2024-12-13T05:37:29.000-08:00
Given input on stdin it has no path to resolve the relative paths that exists in a status file from. It will thus complain about almost all lines which is not ideal. This CL changes it so it doesn't check for it when given data on stdin. This also means that - because there are no old errors on that account - if there are such errors now you will be forced to fix it. The current errors in the status files I could find have also been fixed. This should for instance have flaggen when I in https://dart-review.googlesource.com/c/sdk/+/400320 updated the pkg.status file but forgot to actually rename the underlying file (as fixed in https://dart-review.googlesource.com/c/sdk/+/400560). Technically I suppose it _did_ flag it, but there were also hundreds of lines of false positives caused by the old status file been given at stdin to check if there were existing errors - which there then was, thus not forcing me to do anything. Logical follow-up to https://dart-review.googlesource.com/c/sdk/+/370886 TEST=ci Change-Id: Ib3533ede88b6d99a31f8b423c00930857e0ba49f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400620 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
diff --git a/pkg/pkg.status b/pkg/pkg.status
@@ -52,13 +52,13 @@ dev_compiler/test/options/*: Skip # test needs fixes
 dev_compiler/test/sourcemap/*: SkipByDesign # Skip sourcemap tests
 dev_compiler/test/sourcemap/testfiles/*: SkipByDesign # Skip dev_compiler codegen tests
 dev_compiler/test/worker/*: Skip # test needs fixes
-front_end/test/fasta/analyze_git_test: Pass, Slow
-front_end/test/fasta/bootstrap_test: Pass, Slow
-front_end/test/fasta/rasta/*: SkipByDesign # Anything in rasta is input to fasta unit tests and shouldn't be run as tests.
-front_end/test/fasta/types/dart2js_benchmark_test: Pass, Slow
-front_end/test/fasta/types/large_app_benchmark_test: Pass, ExtraSlow
+front_end/test/analyze_git_test: Pass, Slow
+front_end/test/bootstrap_test: Pass, Slow
 front_end/test/incremental_compiler_leak_test: Pass, ExtraSlow
 front_end/test/incremental_dart2js_test: Pass, Slow
+front_end/test/rasta/*: SkipByDesign # Anything in rasta is input to cfe unit tests and shouldn't be run as tests.
+front_end/test/types/dart2js_benchmark_test: Pass, Slow
+front_end/test/types/large_app_benchmark_test: Pass, ExtraSlow
 front_end/testcases/*: Skip # These are not tests but input for tests.
 front_end/tool/incremental_perf_test: Slow, Pass
 kernel/test/dart_scope_calculator_test: Slow, Pass
@@ -250,7 +250,7 @@ vm_snapshot_analysis/test/*: SkipByDesign # Only meant to run on vm
 
 [ $system == windows ]
 _macros/test/executor/executor_test: Skip # dartbug.com/56002
-front_end/test/fasta/bootstrap_test: Skip # Issue 31902
+front_end/test/bootstrap_test: Skip # Issue 31902
 front_end/test/incremental_dart2js_load_from_dill_test: Pass, Slow
 vm_service/test/private_rpcs/dev_fs_http_put_test: Skip # Windows disallows "?" in paths
 vm_service/test/private_rpcs/dev_fs_http_put_weird_char_test: Skip # Windows disallows "\r" in paths
diff --git a/pkg/status_file/bin/lint.dart b/pkg/status_file/bin/lint.dart
@@ -51,8 +51,7 @@ void main(List<String> arguments) {
   bool usePipe = results["text"];
   if (usePipe) {
     lintStdIn(
-        checkForDisjunctions: checkForDisjunctions,
-        checkForNonExisting: checkForNonExisting);
+        checkForDisjunctions: checkForDisjunctions, checkForNonExisting: false);
   } else {
     if (results.rest.length != 1) {
       printHelp(parser);
diff --git a/runtime/observatory/tests/service/service_kernel.status b/runtime/observatory/tests/service/service_kernel.status
@@ -121,15 +121,13 @@ next_through_await_for_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_call_on_field_in_class_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_call_on_field_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_call_on_static_field_in_class_test: SkipByDesign # Debugger is disabled in AOT mode.
-next_through_catch_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_closure_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_create_list_and_map_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_for_each_loop_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_for_loop_with_break_and_continue_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_function_expression_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_implicit_call_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_is_and_as_test: SkipByDesign # Debugger is disabled in AOT mode.
-next_through_multi_catch_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_new_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_operator_bracket_on_super_test: SkipByDesign # Debugger is disabled in AOT mode.
 next_through_operator_bracket_on_this_test: SkipByDesign # Debugger is disabled in AOT mode.
@@ -218,15 +216,13 @@ next_through_assign_int_test: Skip # Issues 32137 and 32138.
 next_through_call_on_field_in_class_test: Skip # Issues 32137 and 32138.
 next_through_call_on_field_test: Skip # Issues 32137 and 32138.
 next_through_call_on_static_field_in_class_test: Skip # Timeout
-next_through_catch_test: Skip # Issues 32137 and 32138.
 next_through_closure_test: Skip # Timeout
 next_through_create_list_and_map_test: Skip # Issues 32137 and 32138.
 next_through_for_each_loop_test: Skip # Timeout
 next_through_for_loop_with_break_and_continue_test: Skip # Timeout
 next_through_function_expression_test: Skip # Issues 32137 and 32138.
 next_through_implicit_call_test: Skip # Timeout
 next_through_is_and_as_test: Skip # Issues 32137 and 32138.
-next_through_multi_catch_test: Skip # Issues 32137 and 32138.
 next_through_new_test: Skip # Timeout
 next_through_operator_bracket_on_super_test: Skip # Timeout
 next_through_operator_bracket_on_this_test: Skip # Timeout
diff --git a/tests/ffi/ffi.status b/tests/ffi/ffi.status
@@ -2,14 +2,14 @@
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
-native_assets/asset_*: Pass, Slow # https://dartbug.com/56330
 function_callbacks_structs_by_value_test: Pass, Slow # https://dartbug.com/47304 https://dartbug.com/45007
 function_structs_by_value_generated_args_leaf_test: Pass, Slow # https://dartbug.com/47303 https://dartbug.com/45007
 function_structs_by_value_generated_args_test: Pass, Slow # https://dartbug.com/47303 https://dartbug.com/45007
 function_structs_by_value_generated_ret_arg_leaf_test: Pass, Slow # https://dartbug.com/47303 https://dartbug.com/45007
 function_structs_by_value_generated_ret_arg_test: Pass, Slow # https://dartbug.com/47303 https://dartbug.com/45007
 function_structs_by_value_generated_ret_leaf_test: Pass, Slow # https://dartbug.com/47303 https://dartbug.com/45007
 function_structs_by_value_generated_ret_test: Pass, Slow # https://dartbug.com/47303 https://dartbug.com/45007
+native_assets/asset_*: Pass, Slow # https://dartbug.com/56330
 
 [ $builder_tag == optimization_counter_threshold ]
 aliasing_test: SkipByDesign # Already has VMOptions=--optimization-counter-threshold
diff --git a/tests/language/language.status b/tests/language/language.status
@@ -27,9 +27,6 @@ type_object/literal_type_literal_test: SkipByDesign # Relies on symbol names
 unsorted/invocation_mirror_test: SkipByDesign # Relies on symbol names
 vm/type_cast_vm_test: SkipByDesign # Relies on symbol names
 
-[ $compiler != dart2analyzer ]
-switch/case_warn_test: Skip # Analyzer only, see language_analyzer2.status
-
 [ $compiler == dart2bytecode ]
 class_modifiers/trans_legacy/legacy_superdeclaration_test: Crash
 const/inference_test: Crash
diff --git a/tests/standalone/standalone.status b/tests/standalone/standalone.status
@@ -77,8 +77,8 @@ io/https_connection_closed_during_handshake_test: SkipByDesign # long_ssl_cert_e
 io/https_nonblocking_trust_evaluation_test: SkipByDesign
 
 [ $simulator ]
-io/socket_sigpipe_test: SkipByDesign # Test uses ffi
 io/http_big_header_test: SkipSlow # Issue 52110
+io/socket_sigpipe_test: SkipByDesign # Test uses ffi
 
 [ $compiler == dartk && $runtime == vm && $system == fuchsia ]
 *: Skip # Not yet triaged.
diff --git a/tests/web/web.status b/tests/web/web.status
@@ -57,8 +57,8 @@ code_motion_exception_test: Skip # Requires unminified operator names.
 code_motion_exception_test: Skip # Required V8 specific format of JavaScript errors.
 
 [ $compiler == dart2wasm && $runtime != d8 ]
-wasm/source_map_simple_test: SkipByDesign # Reads source map file using d8's readbuffer
 wasm/source_map_simple_optimized_test: SkipByDesign # Reads source map file using d8's readbuffer
+wasm/source_map_simple_test: SkipByDesign # Reads source map file using d8's readbuffer
 wasm/uri_base_test: SkipByDesign # Converts Uri.base to file path
 
 [ $compiler == dartk && $runtime == vm ]
