[dart2js] Update pubspec to 3.8 and reformat.

Change-Id: Ib1afd38a7d3694c2e5ed591132f41b147f76d75a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427560
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Mayank Patke <[email protected]>

Author: fishythefish

pkg/compiler/lib/src/common/codegen.dart

@@ -102,47 +102,38 @@ class _CodegenImpact extends WorldImpactBuilderImpl implements CodegenImpact {
   factory _CodegenImpact.readFromDataSource(DataSourceReader source) {
     source.begin(tag);
     MemberEntity member = source.readMember();
-    final dynamicUses =
-        source
-            .readListOrNull(() => DynamicUse.readFromDataSource(source))
-            ?.toSet();
-    final staticUses =
-        source
-            .readListOrNull(() => StaticUse.readFromDataSource(source))
-            ?.toSet();
-    final typeUses =
-        source
-            .readListOrNull(() => TypeUse.readFromDataSource(source))
-            ?.toSet();
-    final constantUses =
-        source
-            .readListOrNull(() => ConstantUse.readFromDataSource(source))
-            ?.toSet();
-    final typeVariableBoundsSubtypeChecks =
-        source.readListOrNull(() {
-          return (source.readDartType(), source.readDartType());
-        })?.toSet();
+    final dynamicUses = source
+        .readListOrNull(() => DynamicUse.readFromDataSource(source))
+        ?.toSet();
+    final staticUses = source
+        .readListOrNull(() => StaticUse.readFromDataSource(source))
+        ?.toSet();
+    final typeUses = source
+        .readListOrNull(() => TypeUse.readFromDataSource(source))
+        ?.toSet();
+    final constantUses = source
+        .readListOrNull(() => ConstantUse.readFromDataSource(source))
+        ?.toSet();
+    final typeVariableBoundsSubtypeChecks = source.readListOrNull(() {
+      return (source.readDartType(), source.readDartType());
+    })?.toSet();
     final constSymbols = source.readStringsOrNull()?.toSet();
     final specializedGetInterceptors = source.readListOrNull(() {
       return source.readClasses().toSet();
     });
     bool usesInterceptor = source.readBool();
     final asyncMarkersValue = source.readInt();
     final asyncMarkers = EnumSet<AsyncMarker>.fromRawBits(asyncMarkersValue);
-    final genericInstantiations =
-        source
-            .readListOrNull(
-              () => GenericInstantiation.readFromDataSource(source),
-            )
-            ?.toSet();
+    final genericInstantiations = source
+        .readListOrNull(() => GenericInstantiation.readFromDataSource(source))
+        ?.toSet();
     final nativeBehaviors = source.readListOrNull(
       () => NativeBehavior.readFromDataSource(source),
     );
     final nativeMethods = source.readMembersOrNull<FunctionEntity>()?.toSet();
-    final oneShotInterceptors =
-        source
-            .readListOrNull(() => Selector.readFromDataSource(source))
-            ?.toSet();
+    final oneShotInterceptors = source
+        .readListOrNull(() => Selector.readFromDataSource(source))
+        ?.toSet();
     source.end(tag);
     return _CodegenImpact.internal(
       member,
@@ -455,8 +446,8 @@ class CodegenResult {
     source.begin(tag);
     js.Fun? code = source.readJsNodeOrNull() as js.Fun?;
     CodegenImpact impact = CodegenImpact.readFromDataSource(source);
-    final deferredExpressionData = js
-        .DeferredExpressionRegistry.readDataFromDataSource(source);
+    final deferredExpressionData =
+        js.DeferredExpressionRegistry.readDataFromDataSource(source);
     source.end(tag);
     if (code != null) {
       code = code.withAnnotation(deferredExpressionData) as js.Fun;

pkg/compiler/lib/src/common/elements.dart

@@ -100,8 +100,10 @@ abstract class CommonElements {
   late final ClassEntity streamClass = _findClass(asyncLibrary, 'Stream');
 
   /// The dart:core library.
-  late final LibraryEntity coreLibrary =
-      _env.lookupLibrary(Uris.dartCore, required: true)!;
+  late final LibraryEntity coreLibrary = _env.lookupLibrary(
+    Uris.dartCore,
+    required: true,
+  )!;
 
   /// The dart:async library.
   late final LibraryEntity? asyncLibrary = _env.lookupLibrary(Uris.dartAsync);
@@ -118,12 +120,16 @@ abstract class CommonElements {
   );
 
   /// The dart:typed_data library.
-  late final LibraryEntity typedDataLibrary =
-      _env.lookupLibrary(Uris.dartNativeTypedData, required: true)!;
+  late final LibraryEntity typedDataLibrary = _env.lookupLibrary(
+    Uris.dartNativeTypedData,
+    required: true,
+  )!;
 
   /// The dart:_js_shared_embedded_names library.
-  late final LibraryEntity sharedEmbeddedNamesLibrary =
-      _env.lookupLibrary(Uris.dartJSSharedEmbeddedNames, required: true)!;
+  late final LibraryEntity sharedEmbeddedNamesLibrary = _env.lookupLibrary(
+    Uris.dartJSSharedEmbeddedNames,
+    required: true,
+  )!;
 
   /// The dart:_js_helper library.
   late final LibraryEntity? jsHelperLibrary = _env.lookupLibrary(
@@ -146,12 +152,16 @@ abstract class CommonElements {
   );
 
   /// The dart:_rti library.
-  late final LibraryEntity rtiLibrary =
-      _env.lookupLibrary(Uris.dartRti, required: true)!;
+  late final LibraryEntity rtiLibrary = _env.lookupLibrary(
+    Uris.dartRti,
+    required: true,
+  )!;
 
   /// The dart:_internal library.
-  late final LibraryEntity internalLibrary =
-      _env.lookupLibrary(Uris.dartInternal, required: true)!;
+  late final LibraryEntity internalLibrary = _env.lookupLibrary(
+    Uris.dartInternal,
+    required: true,
+  )!;
 
   /// The dart:js_util library.
   late final LibraryEntity? dartJsUtilLibrary = _env.lookupLibrary(
@@ -185,8 +195,10 @@ abstract class CommonElements {
     // TODO(johnniwinther): Kernel does not include redirecting factories
     // so this cannot be found in kernel. Find a consistent way to handle
     // this and similar cases.
-    return _symbolConstructorTarget ??=
-        _env.lookupConstructor(symbolImplementationClass, '')!;
+    return _symbolConstructorTarget ??= _env.lookupConstructor(
+      symbolImplementationClass,
+      '',
+    )!;
   }
 
   void _ensureSymbolConstructorDependencies() {
@@ -227,8 +239,10 @@ abstract class CommonElements {
   }
 
   /// The function `identical` in dart:core.
-  late final FunctionEntity identicalFunction =
-      _findLibraryMember(coreLibrary, 'identical')!;
+  late final FunctionEntity identicalFunction = _findLibraryMember(
+    coreLibrary,
+    'identical',
+  )!;
 
   /// Whether [element] is the `Function.apply` method.
   ///
@@ -420,8 +434,9 @@ abstract class CommonElements {
     bool onlyStringKeys = false,
   }) {
     // TODO(51534): Use CONST_CANONICAL_TYPE(T_i) for arguments.
-    ClassEntity classElement =
-        onlyStringKeys ? constantStringMapClass : generalConstantMapClass;
+    ClassEntity classElement = onlyStringKeys
+        ? constantStringMapClass
+        : generalConstantMapClass;
     return _env.createInterfaceType(classElement, sourceType.typeArguments);
   }
 
@@ -430,25 +445,25 @@ abstract class CommonElements {
     bool onlyStringKeys = false,
   }) {
     // TODO(51534): Use CONST_CANONICAL_TYPE(T_i) for arguments.
-    ClassEntity classElement =
-        onlyStringKeys ? constantStringSetClass : generalConstantSetClass;
+    ClassEntity classElement = onlyStringKeys
+        ? constantStringSetClass
+        : generalConstantSetClass;
     return _env.createInterfaceType(classElement, sourceType.typeArguments);
   }
 
   /// Returns the field that holds the internal name in the implementation class
   /// for `Symbol`.
 
-  FieldEntity get symbolField =>
-      _symbolImplementationField ??=
-          _env.lookupLocalClassMember(
-                symbolImplementationClass,
-                PrivateName(
-                  '_name',
-                  symbolImplementationClass.library.canonicalUri,
-                ),
-                required: true,
-              )
-              as FieldEntity;
+  FieldEntity get symbolField => _symbolImplementationField ??=
+      _env.lookupLocalClassMember(
+            symbolImplementationClass,
+            PrivateName(
+              '_name',
+              symbolImplementationClass.library.canonicalUri,
+            ),
+            required: true,
+          )
+          as FieldEntity;
 
   InterfaceType get symbolImplementationType =>
       _env.getRawType(symbolImplementationClass);
@@ -462,10 +477,12 @@ abstract class CommonElements {
     return _mapLiteralClass!;
   }
 
-  late final ConstructorEntity mapLiteralConstructor =
-      _env.lookupConstructor(mapLiteralClass, '_literal')!;
-  late final ConstructorEntity mapLiteralConstructorEmpty =
-      _env.lookupConstructor(mapLiteralClass, '_empty')!;
+  late final ConstructorEntity mapLiteralConstructor = _env.lookupConstructor(
+    mapLiteralClass,
+    '_literal',
+  )!;
+  late final ConstructorEntity mapLiteralConstructorEmpty = _env
+      .lookupConstructor(mapLiteralClass, '_empty')!;
   late final FunctionEntity mapLiteralUntypedMaker =
       _env.lookupLocalClassMember(
             mapLiteralClass,
@@ -484,10 +501,12 @@ abstract class CommonElements {
     'LinkedHashSet',
   );
 
-  late final ConstructorEntity setLiteralConstructor =
-      _env.lookupConstructor(setLiteralClass, '_literal')!;
-  late final ConstructorEntity setLiteralConstructorEmpty =
-      _env.lookupConstructor(setLiteralClass, '_empty')!;
+  late final ConstructorEntity setLiteralConstructor = _env.lookupConstructor(
+    setLiteralClass,
+    '_literal',
+  )!;
+  late final ConstructorEntity setLiteralConstructorEmpty = _env
+      .lookupConstructor(setLiteralClass, '_empty')!;
   late final FunctionEntity setLiteralUntypedMaker =
       _env.lookupLocalClassMember(
             setLiteralClass,
@@ -716,8 +735,10 @@ abstract class CommonElements {
   late final FunctionEntity getNativeInterceptorMethod =
       _findInterceptorsFunction('getNativeInterceptor');
 
-  late final ConstructorEntity jsArrayTypedConstructor =
-      _env.lookupConstructor(jsArrayClass, 'typed')!;
+  late final ConstructorEntity jsArrayTypedConstructor = _env.lookupConstructor(
+    jsArrayClass,
+    'typed',
+  )!;
 
   // From dart:_js_helper
   // TODO(johnniwinther): Avoid the need for this (from [CheckedModeHelper]).

pkg/compiler/lib/src/common/tasks.dart

@@ -109,12 +109,11 @@ abstract class CompilerTask {
     return runZoned(
       action,
       zoneValues: _zoneValues ??= {_measurer: this},
-      zoneSpecification:
-          _zoneSpecification ??= ZoneSpecification(
-            run: _run,
-            runUnary: _runUnary,
-            runBinary: _runBinary,
-          ),
+      zoneSpecification: _zoneSpecification ??= ZoneSpecification(
+        run: _run,
+        runUnary: _runUnary,
+        runBinary: _runBinary,
+      ),
     );
   }
 

pkg/compiler/lib/src/compiler.dart

@@ -159,10 +159,9 @@ class Compiler {
     options.validate();
     environment = Environment(options.environment);
 
-    abstractValueStrategy =
-        options.useTrivialAbstractValueDomain
-            ? const TrivialAbstractValueStrategy()
-            : const TypeMaskStrategy();
+    abstractValueStrategy = options.useTrivialAbstractValueDomain
+        ? const TrivialAbstractValueStrategy()
+        : const TypeMaskStrategy();
     if (options.debugGlobalInference) {
       abstractValueStrategy = ComputableAbstractValueStrategy(
         abstractValueStrategy,
@@ -267,8 +266,10 @@ class Compiler {
       return '${library.importUri}(${library.fileUri})';
     }
 
-    var unusedLibraries =
-        component.libraries.where(isUnused).map(libraryString).toList();
+    var unusedLibraries = component.libraries
+        .where(isUnused)
+        .map(libraryString)
+        .toList();
     unusedLibraries.sort();
     var jsonLibraries = jsonEncode(unusedLibraries);
     outputProvider.createOutputSink(
@@ -318,10 +319,9 @@ class Compiler {
     if (options.readProgramSplit != null) {
       var constraintUri = options.readProgramSplit;
       var constraintParser = psc.Parser();
-      var programSplitJson =
-          await CompilerFileSystem(
-            provider,
-          ).entityForUri(constraintUri!).readAsString();
+      var programSplitJson = await CompilerFileSystem(
+        provider,
+      ).entityForUri(constraintUri!).readAsString();
       programSplitConstraintsData = constraintParser.read(programSplitJson);
     }
 
@@ -353,9 +353,9 @@ class Compiler {
     List<Uri> libraries,
   ) {
     frontendStrategy.registerLoadedLibraries(component, libraries);
-    ResolutionEnqueuer resolutionEnqueuer = frontendStrategy
-        .createResolutionEnqueuer(enqueueTask, this)
-      ..onEmptyForTesting = onResolutionQueueEmptyForTesting;
+    ResolutionEnqueuer resolutionEnqueuer =
+        frontendStrategy.createResolutionEnqueuer(enqueueTask, this)
+          ..onEmptyForTesting = onResolutionQueueEmptyForTesting;
     if (retainDataForTesting) {
       resolutionEnqueuerForTesting = resolutionEnqueuer;
       resolutionWorldBuilderForTesting = resolutionEnqueuer.worldBuilder;
@@ -455,8 +455,8 @@ class Compiler {
       }
       return output.withNewComponent(component);
     } else {
-      ir.Component component =
-          await serializationTask.deserializeComponentAndUpdateOptions();
+      ir.Component component = await serializationTask
+          .deserializeComponentAndUpdateOptions();
       if (retainDataForTesting) {
         componentForTesting = component;
       }
@@ -952,8 +952,8 @@ class Compiler {
     // so that tests can determine the cause of the message.
     final messageText =
         diagnosticMessage is DiagnosticCfeMessage && options.testMode
-            ? diagnosticMessage.messageCode
-            : '$message';
+        ? diagnosticMessage.messageCode
+        : '$message';
     if (span.isUnknown) {
       callUserHandler(message, null, null, null, messageText, kind);
     } else {

pkg/compiler/lib/src/constants/constant_system.dart

@@ -425,8 +425,9 @@ class ShiftRightOperation extends BinaryBitOperation {
     ConstantValue adjustedLeft = left;
     if (left is IntConstantValue) {
       BigInt value = left.intValue;
-      BigInt truncated =
-          value.isNegative ? value.toSigned(32) : value.toUnsigned(32);
+      BigInt truncated = value.isNegative
+          ? value.toSigned(32)
+          : value.toUnsigned(32);
       if (value != truncated) {
         adjustedLeft = createInt(truncated);
       }