Skip to content

Commit 2bba463

Browse files
dcharkesCommit Queue
authored andcommitted
[vm/ffi] Add embedder API for resolving asset ids - fix
Stop swallowing error messages. TEST=Tested in the local engine build in Flutter that uses the new API. Change-Id: I179366b8d5a251bcb00b5fea722e440c2745a1c7 Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-try,pkg-mac-release-arm64-try,pkg-win-release-try,vm-ffi-android-debug-arm-try,vm-aot-linux-debug-x64-try,vm-linux-debug-x64-try,vm-win-debug-x64-try,vm-mac-debug-x64-try,vm-mac-debug-arm64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389740 Auto-Submit: Daco Harkes <[email protected]> Commit-Queue: Martin Kustermann <[email protected]> Reviewed-by: Martin Kustermann <[email protected]>
1 parent 9fae030 commit 2bba463

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

runtime/lib/ffi_dynamic_library.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ intptr_t FfiResolveInternal(const String& asset,
452452

453453
// Native assets resolution.
454454
void* asset_result = FfiResolveAsset(thread, asset, symbol, error);
455-
if (asset_result != nullptr) {
455+
if (asset_result != nullptr || *error != nullptr) {
456456
return reinterpret_cast<intptr_t>(asset_result);
457457
}
458458

0 commit comments

Comments
 (0)