[cfe] Use last token for missing constructor error

Change-Id: I1ae241eac162b9b0048a7e8ecbd9a9ddfe268d12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408560
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/kernel/body_builder.dart

@@ -6421,7 +6421,7 @@ class BodyBuilder extends StackListenerImpl
         typeName = type.fullNameForErrors;
       }
       push(buildUnresolvedError(
-          debugName(typeName!, name), nameToken.charOffset,
+          debugName(typeName!, name), nameLastToken.charOffset,
           arguments: arguments, kind: UnresolvedKind.Constructor));
     }
     constantContext = savedConstantContext;

pkg/front_end/testcases/general/issue37776.dart.strong.expect

@@ -9,9 +9,9 @@ library;
 // class X {
 //       ^
 //
-// pkg/front_end/testcases/general/issue37776.dart:16:9: Error: Couldn't find constructor 'X.foo'.
+// pkg/front_end/testcases/general/issue37776.dart:16:11: Error: Couldn't find constructor 'X.foo'.
 //   const X.foo();
-//         ^^^
+//           ^^^
 //
 import self as self;
 import "dart:core" as core;
@@ -27,7 +27,7 @@ class X extends core::Object /*hasConstConstructor*/  {
     ;
 }
 static method main() → void {
-  invalid-expression "pkg/front_end/testcases/general/issue37776.dart:16:9: Error: Couldn't find constructor 'X.foo'.
+  invalid-expression "pkg/front_end/testcases/general/issue37776.dart:16:11: Error: Couldn't find constructor 'X.foo'.
   const X.foo();
-        ^^^";
+          ^^^";
 }

pkg/front_end/testcases/general/issue37776.dart.strong.modular.expect

@@ -9,9 +9,9 @@ library;
 // class X {
 //       ^
 //
-// pkg/front_end/testcases/general/issue37776.dart:16:9: Error: Couldn't find constructor 'X.foo'.
+// pkg/front_end/testcases/general/issue37776.dart:16:11: Error: Couldn't find constructor 'X.foo'.
 //   const X.foo();
-//         ^^^
+//           ^^^
 //
 import self as self;
 import "dart:core" as core;
@@ -27,7 +27,7 @@ class X extends core::Object /*hasConstConstructor*/  {
     ;
 }
 static method main() → void {
-  invalid-expression "pkg/front_end/testcases/general/issue37776.dart:16:9: Error: Couldn't find constructor 'X.foo'.
+  invalid-expression "pkg/front_end/testcases/general/issue37776.dart:16:11: Error: Couldn't find constructor 'X.foo'.
   const X.foo();
-        ^^^";
+          ^^^";
 }

pkg/front_end/testcases/general/issue37776.dart.strong.transformed.expect

@@ -9,9 +9,9 @@ library;
 // class X {
 //       ^
 //
-// pkg/front_end/testcases/general/issue37776.dart:16:9: Error: Couldn't find constructor 'X.foo'.
+// pkg/front_end/testcases/general/issue37776.dart:16:11: Error: Couldn't find constructor 'X.foo'.
 //   const X.foo();
-//         ^^^
+//           ^^^
 //
 import self as self;
 import "dart:core" as core;
@@ -27,7 +27,7 @@ class X extends core::Object /*hasConstConstructor*/  {
     ;
 }
 static method main() → void {
-  invalid-expression "pkg/front_end/testcases/general/issue37776.dart:16:9: Error: Couldn't find constructor 'X.foo'.
+  invalid-expression "pkg/front_end/testcases/general/issue37776.dart:16:11: Error: Couldn't find constructor 'X.foo'.
   const X.foo();
-        ^^^";
+          ^^^";
 }