[linter] Dot shorthands: Update no_logic_in_create_state lint.

Updated the lint to handle the dot shorthand constructor invocation case.

Added unit tests.

Fixes: #60976
Bug: #60893
Change-Id: I4ba65e28b17b4357af0e09ad2cc0139177062583
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/436800
Commit-Queue: Kallen Tu <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: kallentu

pkg/linter/lib/src/rules/no_logic_in_create_state.dart

@@ -62,7 +62,12 @@ class _Visitor extends SimpleAstVisitor<void> {
       if (expressionToTest.argumentList.arguments.isEmpty) {
         return;
       }
+    } else if (expressionToTest is DotShorthandConstructorInvocation) {
+      if (expressionToTest.argumentList.arguments.isEmpty) {
+        return;
+      }
     }
+
     rule.reportAtNode(expressionToTest ?? body);
   }
 }

pkg/linter/test/rules/no_logic_in_create_state_test.dart

@@ -44,6 +44,24 @@ class MyWidget extends StatefulWidget {
   MyState createState() => MyState();
 }
 
+class MyState extends State {
+  int field = 0;
+
+  late BuildContext context;
+  bool get mounted => false;
+}
+''');
+  }
+
+  test_arrowBody_returnsState_dotShorthand() async {
+    await assertNoDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+
+class MyWidget extends StatefulWidget {
+  @override
+  MyState createState() => .new();
+}
+
 class MyState extends State {
   int field = 0;
 
@@ -75,6 +93,28 @@ class MyState extends State {
     );
   }
 
+  test_arrowBody_returnsState_passingArguments_dotShorthand() async {
+    await assertDiagnostics(
+      r'''
+import 'package:flutter/widgets.dart';
+
+class MyWidget extends StatefulWidget {
+  @override
+  MyState createState() => .new(1);
+}
+
+class MyState extends State {
+  int field;
+  MyState(this.field);
+
+  late BuildContext context;
+  bool get mounted => false;
+}
+''',
+      [lint(119, 7)],
+    );
+  }
+
   test_arrowBody_returnsState_withCascade() async {
     await assertDiagnostics(
       r'''
@@ -96,6 +136,27 @@ class MyState extends State {
     );
   }
 
+  test_arrowBody_returnsState_withCascade_dotShorthand() async {
+    await assertDiagnostics(
+      r'''
+import 'package:flutter/widgets.dart';
+
+class MyWidget extends StatefulWidget {
+  @override
+  MyState createState() => .new()..field = 0;
+}
+
+class MyState extends State {
+  int field = 0;
+
+  late BuildContext context;
+  bool get mounted => false;
+}
+''',
+      [lint(119, 17)],
+    );
+  }
+
   test_blockBodyWithSingleStatement_returnsInstanceField() async {
     await assertDiagnostics(
       r'''
@@ -131,6 +192,26 @@ class MyWidget extends StatefulWidget {
   }
 }
 
+class MyState extends State {
+  int field = 0;
+
+  late BuildContext context;
+  bool get mounted => false;
+}
+''');
+  }
+
+  test_blockBodyWithSingleStatement_returnsState_dotShorthand() async {
+    await assertNoDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+
+class MyWidget extends StatefulWidget {
+  @override
+  MyState createState() {
+    return .new();
+  }
+}
+
 class MyState extends State {
   int field = 0;
 
@@ -163,6 +244,29 @@ class MyState extends State {
     );
   }
 
+  test_blockBodyWithSingleStatement_returnsState_withCascade_dotShorthand() async {
+    await assertDiagnostics(
+      r'''
+import 'package:flutter/widgets.dart';
+
+class MyWidget extends StatefulWidget {
+  @override
+  MyState createState() {
+    return .new()..field = 0;
+  }
+}
+
+class MyState extends State {
+  int field = 0;
+
+  late BuildContext context;
+  bool get mounted => false;
+}
+''',
+      [lint(129, 17)],
+    );
+  }
+
   test_instantiateTopLevel_returnTopLevel() async {
     await assertDiagnostics(
       r'''
@@ -188,4 +292,30 @@ var global = MyState();
       [lint(121, 48)],
     );
   }
+
+  test_instantiateTopLevel_returnTopLevel_dotShorthand() async {
+    await assertDiagnostics(
+      r'''
+import 'package:flutter/widgets.dart';
+
+class MyStatefulBad extends StatefulWidget {
+  @override
+  MyState createState() {
+    global = .new();
+    return global;
+  }
+}
+
+class MyState extends State {
+  int field = 0;
+
+  late BuildContext context;
+  bool get mounted => false;
+}
+
+var global = MyState();
+''',
+      [lint(121, 45)],
+    );
+  }
 }