[cfe] Support aliased void

This supports void through type aliases as the return type of setters and index setters.

Closes #61628

Change-Id: Ie2f3dad59f630deec9c535e3b1caf1595720215d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/452402
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/builder/fixed_type_builder.dart

@@ -36,10 +36,6 @@ class FixedTypeBuilderImpl extends FixedTypeBuilder {
   @override
   String get debugName => 'FixedTypeBuilder';
 
-  @override
-  // Coverage-ignore(suite): Not run.
-  bool get isVoidType => type is VoidType;
-
   @override
   // Coverage-ignore(suite): Not run.
   StringBuffer printOn(StringBuffer buffer) {

pkg/front_end/lib/src/builder/function_type_builder.dart

@@ -114,10 +114,6 @@ abstract class FunctionTypeBuilderImpl extends FunctionTypeBuilder {
   @override
   String get debugName => "Function";
 
-  @override
-  // Coverage-ignore(suite): Not run.
-  bool get isVoidType => false;
-
   @override
   StringBuffer printOn(StringBuffer buffer) {
     if (typeParameters != null) {

pkg/front_end/lib/src/builder/invalid_type_builder.dart

@@ -61,10 +61,6 @@ class InvalidTypeBuilderImpl extends InvalidTypeBuilder {
   @override
   bool get isExplicit => true;
 
-  @override
-  // Coverage-ignore(suite): Not run.
-  bool get isVoidType => false;
-
   @override
   // Coverage-ignore(suite): Not run.
   TypeName? get typeName => null;

pkg/front_end/lib/src/builder/named_type_builder.dart

@@ -205,9 +205,6 @@ abstract class NamedTypeBuilderImpl extends NamedTypeBuilder {
     return _declaration!;
   }
 
-  @override
-  bool get isVoidType => false;
-
   @override
   void bind(
     ProblemReporting problemReporting,

pkg/front_end/lib/src/builder/omitted_type_builder.dart

@@ -39,10 +39,6 @@ abstract class OmittedTypeBuilderImpl extends OmittedTypeBuilder {
   // Coverage-ignore(suite): Not run.
   Uri? get fileUri => null;
 
-  @override
-  // Coverage-ignore(suite): Not run.
-  bool get isVoidType => false;
-
   @override
   // Coverage-ignore(suite): Not run.
   TypeName? get typeName => null;

pkg/front_end/lib/src/builder/record_type_builder.dart

@@ -107,10 +107,6 @@ abstract class RecordTypeBuilderImpl extends RecordTypeBuilder {
   @override
   String get debugName => "Record";
 
-  @override
-  // Coverage-ignore(suite): Not run.
-  bool get isVoidType => false;
-
   @override
   StringBuffer printOn(StringBuffer buffer) {
     buffer.write("(");

pkg/front_end/lib/src/builder/synthesized_type_builder.dart

@@ -172,10 +172,6 @@ class SynthesizedTypeBuilder extends FixedTypeBuilder {
   // Coverage-ignore(suite): Not run.
   bool get isExplicit => _typeBuilder.isExplicit;
 
-  @override
-  // Coverage-ignore(suite): Not run.
-  bool get isVoidType => _typeBuilder.isVoidType;
-
   @override
   NullabilityBuilder get nullabilityBuilder => _typeBuilder.nullabilityBuilder;
 

pkg/front_end/lib/src/builder/type_builder.dart

@@ -431,8 +431,6 @@ sealed class TypeBuilder {
 
   TypeBuilder withNullabilityBuilder(NullabilityBuilder nullabilityBuilder);
 
-  bool get isVoidType;
-
   /// Register [type] as the inferred type of this type builder.
   ///
   /// If this is not an [InferableTypeBuilder] this method will throw.

pkg/front_end/lib/src/builder/void_type_builder.dart

@@ -33,9 +33,6 @@ class VoidTypeBuilder extends FixedTypeBuilder {
   @override
   String get debugName => 'VoidTypeBuilder';
 
-  @override
-  bool get isVoidType => true;
-
   @override
   StringBuffer printOn(StringBuffer buffer) {
     buffer.write('void');

pkg/front_end/lib/src/fragment/field/declaration.dart

@@ -725,6 +725,7 @@ class RegularFieldDeclaration
   @override
   void buildSetterOutlineNode({
     required SourceLibraryBuilder libraryBuilder,
+    required ProblemReporting problemReporting,
     required NameScheme nameScheme,
     required BuildNodesCallback f,
     required PropertyReferences? references,