[linter] Doc and changelog updates

Change-Id: I64554034fc510afdab1c3e1dab18a3855fd31b09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406782
Commit-Queue: Marya Belanger <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Auto-Submit: Parker Lougheed <[email protected]>

Author: parlough

CHANGELOG.md

@@ -10,6 +10,12 @@
 
 ### Tools
 
+#### Analyzer
+
+- Added the experimental [`unnecessary_ignore`][] lint rule.
+
+[`unnecessary_ignore`]: http://dart.dev/lints/unnecessary_ignore
+
 #### Dart Development Compiler (dartdevc)
 
 In order to align with dart2js semantics, DDC will now throw a runtime error
@@ -94,7 +100,7 @@ main() {
 - Code completion now suggests instance variables when completing inside the
   initializer of a _late_ field.
 - Assists and quick fixes that add a const keyword now consider the
-  `prefer_const_declarations` lint rule, prefering to add `const` to a variable
+  `prefer_const_declarations` lint rule, preferring to add `const` to a variable
   declaration rather than the initial value.
 - Add a fix to add a missing `on` keyword in an extension declaration.
 - Add a fix to wrap an ambiguous property access or method call in an extension
@@ -109,6 +115,7 @@ main() {
 - Add the [`unnecessary_underscores`][] lint rule.
 - Add the experimental [`specify_nonobvious_property_types`][] lint rule.
 - Add the experimental [`omit_obvious_property_types`][] lint rule.
+- Add the experimental [`unnecessary_async`][] lint rule.
 - Add the experimental [`unsafe_variance`][] lint rule.
 - Remove the [`package_api_docs`][] lint rule.
 - Remove the [`unsafe_html`][] lint rule.
@@ -117,6 +124,7 @@ main() {
 [`unnecessary_underscores`]: https://dart.dev/lints/unnecessary_underscores
 [`specify_nonobvious_property_types`]: https://dart.dev/tools/linter-rules/specify_nonobvious_property_types
 [`omit_obvious_property_types`]: https://dart.dev/tools/linter-rules/omit_obvious_property_types
+[`unnecessary_async`]: http://dart.dev/lints/unnecessary_async
 [`unsafe_variance`]: https://dart.dev/tools/linter-rules/unsafe_variance
 [`package_api_docs`]: https://dart.dev/tools/linter-rules/package_api_docs
 [`unsafe_html`]: https://dart.dev/tools/linter-rules/unsafe_html

pkg/analyzer/messages.yaml

@@ -24346,7 +24346,7 @@ WarningCode:
       The analyzer produces this diagnostic when a comment that appears to be an
       attempt to specify a language version override doesn't conform to the
       requirements for such a comment. For more information, see
-      [Per-library language version selection](https://dart.dev/guides/language/evolution#per-library-language-version-selection).
+      [Per-library language version selection](https://dart.dev/resources/language/evolution#per-library-language-version-selection).
 
       #### Example
 

pkg/analyzer/tool/diagnostics/diagnostics.md

@@ -10469,7 +10469,7 @@ directive._
 The analyzer produces this diagnostic when a comment that appears to be an
 attempt to specify a language version override doesn't conform to the
 requirements for such a comment. For more information, see
-[Per-library language version selection](https://dart.dev/guides/language/evolution#per-library-language-version-selection).
+[Per-library language version selection](https://dart.dev/resources/language/evolution#per-library-language-version-selection).
 
 #### Example
 
@@ -28699,12 +28699,13 @@ ignored._
 
 #### Description
 
-The analyzer produces this diagnostic when an ignore is specified to ignore a diagnostic that isn't produced.
+The analyzer produces this diagnostic when an ignore is specified to
+ignore a diagnostic that isn't produced.
 
 #### Example
 
-The following code produces this diagnostic because the `unused_local_variable`
-diagnostic isn't reported at the ignored location:
+The following code produces this diagnostic because the
+`unused_local_variable` diagnostic isn't reported at the ignored location:
 
 ```dart
 // ignore: [!unused_local_variable!]

pkg/linter/lib/src/lint_codes.g.dart

@@ -1641,6 +1641,7 @@ class LinterLintCode extends LintCode {
     "The diagnostic '{0}' isn't produced at this location so it doesn't need "
     "to be ignored.",
     correctionMessage: "Try removing the ignore comment.",
+    hasPublishedDocs: true,
     uniqueName: 'unnecessary_ignore',
   );
 

pkg/linter/messages.yaml

@@ -1254,7 +1254,7 @@ LintCode:
 
       **This rule is experimental.** It is being evaluated, and it may be changed
       or removed. Feedback on its behavior is welcome! The main issue is here:
-      https://github.com/dart-lang/linter/issues/4622
+      https://github.com/dart-lang/sdk/issues/59232.
   avoid_implementing_value_types:
     problemMessage: "Classes that override '==' should not be implemented."
     correctionMessage: "Try removing the class from the 'implements' clause."
@@ -2903,7 +2903,7 @@ LintCode:
       **Known limitations**
 
       This rule does not track all patterns of StreamSubscription instantiations and
-      cancellations. See [linter#317](https://github.com/dart-lang/linter/issues/317)
+      cancellations. See [linter#317](https://github.com/dart-lang/sdk/issues/57387)
       for more information.
   cascade_invocations:
     problemMessage: "Unnecessary duplication of receiver."
@@ -3066,7 +3066,7 @@ LintCode:
       **Known limitations**
 
       This rule does not track all patterns of Sink instantiations and
-      closures. See [linter#1381](https://github.com/dart-lang/linter/issues/1381)
+      closures. See [sdk#57882](https://github.com/dart-lang/sdk/issues/57882)
       for more information.
   collection_methods_unrelated_type:
     problemMessage: "The argument type '{0}' isn't related to '{1}'."
@@ -3248,7 +3248,7 @@ LintCode:
       comment references, which is occasionally distinct from Dartdoc's notion of
       comment references. The lint rule may report comment references which Dartdoc
       can resolve, even though the analyzer cannot. See
-      [linter#1142](https://github.com/dart-lang/linter/issues/1142) for more
+      [sdk#57783](https://github.com/dart-lang/sdk/issues/57783) for more
       information.
   conditional_uri_does_not_exist:
     problemMessage: "The target of the conditional URI '{0}' doesn't exist."
@@ -7173,7 +7173,7 @@ LintCode:
 
       **This rule is experimental.** It is being evaluated, and it may be changed
       or removed. Feedback on its behavior is welcome! The main issue is here:
-      https://github.com/dart-lang/linter/issues/3480.
+      https://github.com/dart-lang/sdk/issues/58773.
   omit_obvious_property_types:
     problemMessage: "The type annotation isn't needed because it is obvious."
     correctionMessage: "Try removing the type annotation."
@@ -7224,7 +7224,7 @@ LintCode:
 
       **This rule is experimental.** It is being evaluated, and it may be changed
       or removed. Feedback on its behavior is welcome! The main issue is here:
-      https://github.com/dart-lang/linter/issues/5101.
+      https://github.com/dart-lang/sdk/issues/59550.
   one_member_abstracts:
     problemMessage: "Unnecessary use of an abstract class."
     correctionMessage: "Try making '{0}' a top-level function and removing the class."
@@ -10793,7 +10793,7 @@ LintCode:
 
       **This rule is experimental.** It is being evaluated, and it may be changed
       or removed. Feedback on its behavior is welcome! The main issue is here:
-      https://github.com/dart-lang/linter/issues/3480.
+      https://github.com/dart-lang/sdk/issues/58773.
   specify_nonobvious_property_types:
     problemMessage: "A type annotation is needed because it isn't obvious."
     correctionMessage: "Try adding a type annotation."
@@ -10863,14 +10863,15 @@ LintCode:
 
       **This rule is experimental.** It is being evaluated, and it may be changed
       or removed. Feedback on its behavior is welcome! The main issue is here:
-      https://github.com/dart-lang/linter/issues/5101.
+      https://github.com/dart-lang/sdk/issues/59550.
   strict_top_level_inference_add_type:
     sharedName: strict_top_level_inference
     problemMessage: "Missing type annotation."
     correctionMessage: "Try adding a type annotation."
     state:
       stable: "3.7"
     categories: [style]
+    hasPublishedDocs: false
     deprecatedDetails: |-
       Do type annotate top-level and class-like member declarations, where types
       are not inferred from super-interfaces or initializers.
@@ -10913,7 +10914,6 @@ LintCode:
       }
       int _sq(int v) => v * v;
       ```
-    hasPublishedDocs: false
   strict_top_level_inference_replace_keyword:
     sharedName: strict_top_level_inference
     problemMessage: "Missing type annotation."
@@ -11630,7 +11630,7 @@ LintCode:
       /// The type [List<int>]
       /// `<assignment> -> <variable> = <expression>`
       /// \<assignment\> -> \<variable\> = \<expression\>`
-      /// <http://foo.bar.baz>
+      /// <https://example.com/example>
       ```
   unnecessary_async:
     problemMessage: "Don't make a function 'async' if it doesn't use 'await'."
@@ -11792,7 +11792,7 @@ LintCode:
       ```
 
       NOTE: This lint only reports unnecessary breaks in libraries with a
-      [language version](https://dart.dev/guides/language/evolution#language-versioning)
+      [language version](https://dart.dev/resources/language/evolution#language-versioning)
       of 3.0 or greater. Explicit breaks are still required in Dart 2.19 and below.
   unnecessary_const:
     problemMessage: "Unnecessary 'const' keyword."
@@ -12061,16 +12061,17 @@ LintCode:
     state:
       experimental: "3.8"
     categories: [style]
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     documentation: |-
       #### Description
 
-      The analyzer produces this diagnostic when an ignore is specified to ignore a diagnostic that isn't produced.
+      The analyzer produces this diagnostic when an ignore is specified to
+      ignore a diagnostic that isn't produced.
 
       #### Example
 
-      The following code produces this diagnostic because the `unused_local_variable`
-      diagnostic isn't reported at the ignored location:
+      The following code produces this diagnostic because the
+      `unused_local_variable` diagnostic isn't reported at the ignored location:
 
       ```dart
       // ignore: [!unused_local_variable!]