Elements. Remove V1 ParameterElement.

Change-Id: I5ebfcf9a15548dc3bf0541f058c6c46a9e8bdc0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423065
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: scheglov

pkg/analyzer/api.txt

@@ -3169,27 +3169,6 @@ package:analyzer/dart/element/element.dart:
   NamespaceCombinator (class extends Object, sealed (immediate subtypes: HideElementCombinator, ShowElementCombinator)):
     end (getter: int)
     offset (getter: int)
-  ParameterElement (class extends Object implements PromotableElement, ConstantEvaluationTarget, deprecated):
-    new (constructor: ParameterElement Function())
-    declaration (getter: ParameterElement)
-    defaultValueCode (getter: String?)
-    element (getter: FormalParameterElement, experimental)
-    hasDefaultValue (getter: bool)
-    isCovariant (getter: bool)
-    isInitializingFormal (getter: bool)
-    isNamed (getter: bool)
-    isOptional (getter: bool)
-    isOptionalNamed (getter: bool)
-    isOptionalPositional (getter: bool)
-    isPositional (getter: bool)
-    isRequired (getter: bool)
-    isRequiredNamed (getter: bool)
-    isRequiredPositional (getter: bool)
-    isSuperFormal (getter: bool)
-    name (getter: String)
-    parameterKind (getter: ParameterKind, deprecated)
-    parameters (getter: List<ParameterElement>)
-    appendToWithoutDelimiters (method: void Function(StringBuffer, {bool withNullability}))
   PartElement (class extends Object implements _ExistingElement, deprecated):
     new (constructor: PartElement Function())
     uri (getter: DirectiveUri)
@@ -4808,27 +4787,6 @@ package:analyzer/src/generated/timestamped_data.dart:
     new (constructor: TimestampedData<E> Function(int, E))
     data (getter: E)
     modificationTime (getter: int)
-package:analyzer/src/generated/utilities_dart.dart:
-  ParameterKind (class extends Object implements Comparable<ParameterKind>):
-    NAMED (static getter: ParameterKind)
-    NAMED_REQUIRED (static getter: ParameterKind)
-    POSITIONAL (static getter: ParameterKind)
-    REQUIRED (static getter: ParameterKind)
-    values (static getter: List<ParameterKind>)
-    new (constructor: ParameterKind Function({required bool isNamed, required bool isOptional, required bool isOptionalNamed, required bool isOptionalPositional, required bool isPositional, required bool isRequired, required bool isRequiredNamed, required bool isRequiredPositional, required String name, required int ordinal}))
-    hashCode (getter: int)
-    isNamed (getter: bool)
-    isOptional (getter: bool)
-    isOptionalNamed (getter: bool)
-    isOptionalPositional (getter: bool)
-    isPositional (getter: bool)
-    isRequired (getter: bool)
-    isRequiredNamed (getter: bool)
-    isRequiredPositional (getter: bool)
-    name (getter: String)
-    ordinal (getter: int)
-    compareTo (method: int Function(ParameterKind))
-    toString (method: String Function())
 package:analyzer/src/lint/config.dart:
   RuleConfig (non-public)
 package:analyzer/src/lint/linter.dart:

pkg/analyzer/lib/dart/element/element.dart

@@ -52,7 +52,6 @@ import 'package:analyzer/src/dart/element/element.dart'
     show elementModelDeprecationMsg;
 import 'package:analyzer/src/dart/resolver/scope.dart' show Namespace;
 import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
-import 'package:analyzer/src/generated/utilities_dart.dart';
 // ignore: deprecated_member_use_from_same_package
 import 'package:analyzer/src/task/api/model.dart' show AnalysisTarget;
 import 'package:meta/meta.dart';
@@ -876,106 +875,6 @@ sealed class NamespaceCombinator {
   int get offset;
 }
 
-/// A parameter defined within an executable element.
-///
-/// Clients may not extend, implement or mix-in this class.
-@Deprecated('Use FormalParameterElement instead')
-abstract class ParameterElement
-    implements PromotableElement, ConstantEvaluationTarget {
-  @override
-  ParameterElement get declaration;
-
-  /// The code of the default value, or `null` if no default value.
-  String? get defaultValueCode;
-
-  @experimental
-  FormalParameterElement get element;
-
-  /// Whether the parameter has a default value.
-  bool get hasDefaultValue;
-
-  /// Whether the parameter is covariant, meaning it is allowed to have a
-  /// narrower type in an override.
-  bool get isCovariant;
-
-  /// Whether the parameter is an initializing formal parameter.
-  bool get isInitializingFormal;
-
-  /// Whether the parameter is a named parameter.
-  ///
-  /// Named parameters that are annotated with the `@required` annotation are
-  /// considered optional. Named parameters that are annotated with the
-  /// `required` syntax are considered required.
-  bool get isNamed;
-
-  /// Whether the parameter is an optional parameter.
-  ///
-  /// Optional parameters can either be positional or named. Named parameters
-  /// that are annotated with the `@required` annotation are considered
-  /// optional. Named parameters that are annotated with the `required` syntax
-  /// are considered required.
-  bool get isOptional;
-
-  /// Whether the parameter is both an optional and named parameter.
-  ///
-  /// Named parameters that are annotated with the `@required` annotation are
-  /// considered optional. Named parameters that are annotated with the
-  /// `required` syntax are considered required.
-  bool get isOptionalNamed;
-
-  /// Whether the parameter is both an optional and positional parameter.
-  bool get isOptionalPositional;
-
-  /// Whether the parameter is a positional parameter.
-  ///
-  /// Positional parameters can either be required or optional.
-  bool get isPositional;
-
-  /// Whether the parameter is either a required positional parameter, or a
-  /// named parameter with the `required` keyword.
-  ///
-  /// Note: the presence or absence of the `@required` annotation does not
-  /// change the meaning of this getter. The parameter `{@required int x}`
-  /// will return `false` and the parameter `{@required required int x}`
-  /// will return `true`.
-  bool get isRequired;
-
-  /// Whether the parameter is both a required and named parameter.
-  ///
-  /// Named parameters that are annotated with the `@required` annotation are
-  /// considered optional. Named parameters that are annotated with the
-  /// `required` syntax are considered required.
-  bool get isRequiredNamed;
-
-  /// Whether the parameter is both a required and positional parameter.
-  bool get isRequiredPositional;
-
-  /// Whether the parameter is a super formal parameter.
-  bool get isSuperFormal;
-
-  @override
-  String get name;
-
-  /// The kind of this parameter.
-  @Deprecated('Use the getters isOptionalNamed, isOptionalPositional, '
-      'isRequiredNamed, and isRequiredPositional')
-  ParameterKind get parameterKind;
-
-  /// The parameters defined by this parameter.
-  ///
-  /// A parameter will only define other parameters if it is a function typed
-  /// parameter.
-  List<ParameterElement> get parameters;
-
-  /// Appends the type, name and possibly the default value of this parameter
-  /// to the given [buffer].
-  void appendToWithoutDelimiters(
-    StringBuffer buffer, {
-    @Deprecated('Only non-nullable by default mode is supported')
-    bool withNullability = true,
-  });
-}
-
 /// A 'part' directive within a library.
 ///
 /// Clients may not extend, implement or mix-in this class.

pkg/analyzer/lib/src/dart/element/element.dart

@@ -8491,12 +8491,8 @@ abstract class NonParameterVariableElementImpl extends VariableElementImpl
 }
 
 class ParameterElementImpl extends VariableElementImpl
-    with
-        ParameterElementMixin
-    implements
-        // ignore:deprecated_member_use_from_same_package,analyzer_use_new_elements
-        ParameterElement,
-        FormalParameterFragment {
+    with ParameterElementMixin
+    implements FormalParameterFragment {
   @override
   String? name2;
 
@@ -8581,7 +8577,7 @@ class ParameterElementImpl extends VariableElementImpl
   @override
   Fragment? get enclosingFragment => enclosingElement3 as Fragment?;
 
-  @override
+  /// Whether the parameter has a default value.
   bool get hasDefaultValue {
     return defaultValueCode != null;
   }
@@ -8611,7 +8607,7 @@ class ParameterElementImpl extends VariableElementImpl
   @override
   bool get isLate => false;
 
-  @override
+  /// Whether the parameter is a super formal parameter.
   bool get isSuperFormal => false;
 
   @override
@@ -8744,46 +8740,77 @@ class ParameterElementImpl_ofImplicitSetter extends ParameterElementImpl {
 
 /// A mixin that provides a common implementation for methods defined in
 /// `ParameterElement`.
-mixin ParameterElementMixin
-    implements
-        // ignore:deprecated_member_use_from_same_package,analyzer_use_new_elements
-        ParameterElement,
-        VariableElementOrMember {
+mixin ParameterElementMixin implements VariableElementOrMember {
   @override
   ParameterElementImpl get declaration;
 
-  @override
+  /// The code of the default value, or `null` if no default value.
+  String? get defaultValueCode;
+
   FormalParameterElementImpl get element;
 
-  @override
+  /// Whether the parameter is covariant, meaning it is allowed to have a
+  /// narrower type in an override.
+  bool get isCovariant;
+
+  /// Whether the parameter is an initializing formal parameter.
+  bool get isInitializingFormal;
+
+  /// Whether the parameter is a named parameter.
+  ///
+  /// Named parameters that are annotated with the `@required` annotation are
+  /// considered optional. Named parameters that are annotated with the
+  /// `required` syntax are considered required.
   bool get isNamed => parameterKind.isNamed;
 
-  @override
+  /// Whether the parameter is an optional parameter.
+  ///
+  /// Optional parameters can either be positional or named. Named parameters
+  /// that are annotated with the `@required` annotation are considered
+  /// optional. Named parameters that are annotated with the `required` syntax
+  /// are considered required.
   bool get isOptional => parameterKind.isOptional;
 
-  @override
+  /// Whether the parameter is both an optional and named parameter.
+  ///
+  /// Named parameters that are annotated with the `@required` annotation are
+  /// considered optional. Named parameters that are annotated with the
+  /// `required` syntax are considered required.
   bool get isOptionalNamed => parameterKind.isOptionalNamed;
 
-  @override
+  /// Whether the parameter is both an optional and positional parameter.
   bool get isOptionalPositional => parameterKind.isOptionalPositional;
 
-  @override
+  /// Whether the parameter is a positional parameter.
+  ///
+  /// Positional parameters can either be required or optional.
   bool get isPositional => parameterKind.isPositional;
 
-  @override
+  /// Whether the parameter is either a required positional parameter, or a
+  /// named parameter with the `required` keyword.
+  ///
+  /// Note: the presence or absence of the `@required` annotation does not
+  /// change the meaning of this getter. The parameter `{@required int x}`
+  /// will return `false` and the parameter `{@required required int x}`
+  /// will return `true`.
   bool get isRequired => parameterKind.isRequired;
 
-  @override
+  /// Whether the parameter is both a required and named parameter.
+  ///
+  /// Named parameters that are annotated with the `@required` annotation are
+  /// considered optional. Named parameters that are annotated with the
+  /// `required` syntax are considered required.
   bool get isRequiredNamed => parameterKind.isRequiredNamed;
 
-  @override
+  /// Whether the parameter is both a required and positional parameter.
   bool get isRequiredPositional => parameterKind.isRequiredPositional;
 
-  @override
-  // Overridden to remove the 'deprecated' annotation.
   ParameterKind get parameterKind;
 
-  @override
+  /// The parameters defined by this parameter.
+  ///
+  /// A parameter will only define other parameters if it is a function typed
+  /// parameter.
   List<ParameterElementMixin> get parameters;
 
   @override
@@ -8795,7 +8822,8 @@ mixin ParameterElementMixin
   /// parameter.
   List<TypeParameterElementImpl> get typeParameters;
 
-  @override
+  /// Appends the type, name and possibly the default value of this parameter
+  /// to the given [buffer].
   void appendToWithoutDelimiters(
     StringBuffer buffer, {
     @Deprecated('Only non-nullable by default mode is supported')

pkg/analyzer/lib/src/dart/element/member.dart

@@ -1064,12 +1064,7 @@ class MethodMember extends ExecutableMember
 /// A parameter element defined in a parameterized type where the values of the
 /// type parameters are known.
 class ParameterMember extends VariableMember
-    with
-        ParameterElementMixin,
-        FormalParameterElementMixin
-    implements
-        // ignore:deprecated_member_use_from_same_package,analyzer_use_new_elements
-        ParameterElement {
+    with ParameterElementMixin, FormalParameterElementMixin {
   @override
   final List<TypeParameterElementImpl> typeParameters;
 

pkg/analyzer/lib/src/utilities/extensions/element.dart

@@ -362,14 +362,6 @@ extension FieldElementOrMemberExtension on FieldElementOrMember {
 }
 
 extension FormalParameterElementExtension on FormalParameterElement {
-  @Deprecated(elementModelDeprecationMsg)
-  ParameterElement get asElement {
-    if (this case ParameterMember member) {
-      return member;
-    }
-    return firstFragment as ParameterElement;
-  }
-
   void appendToWithoutDelimiters(
     StringBuffer buffer, {
     @Deprecated('Only non-nullable by default mode is supported')