[dart:js] Use Array.isArray

rakudrama · Commit Queue · commit 2f5dd77ccb72 · 2025-04-30T16:23:14.000-07:00
Bug: b/411647888 Change-Id: I501808ab48798e99531114017ad3497d1f0ab2c4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423067 Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Stephen Adams <sra@google.com>
diff --git a/sdk/lib/_internal/js_dev_runtime/patch/js_patch.dart b/sdk/lib/_internal/js_dev_runtime/patch/js_patch.dart
@@ -440,7 +440,7 @@ JsObject _wrapToDartHelper(Object o) {
   if (JS<bool>('!', 'typeof # == "function"', o)) {
     return JsFunction._fromJs(o);
   }
-  if (JS<bool>('!', '# instanceof Array', o)) {
+  if (JS<bool>('!', 'Array.isArray(#)', o)) {
     return JsArray._fromJs(o);
   }
   return JsObject._fromJs(o);
diff --git a/sdk/lib/_internal/js_runtime/lib/js_patch.dart b/sdk/lib/_internal/js_runtime/lib/js_patch.dart
@@ -548,7 +548,7 @@ Object _wrapToDart(o) {
       (o) => JsFunction._fromJs(o),
     );
   }
-  if (JS('bool', '# instanceof Array', o)) {
+  if (JS('bool', 'Array.isArray(#)', o)) {
     return _getDartProxy(
       o,
       _DART_OBJECT_PROPERTY_NAME,

Original file line number	Diff line number	Diff line change
`@@ -440,7 +440,7 @@ JsObject _wrapToDartHelper(Object o) {`
`440`	`440`	`if (JS<bool>('!', 'typeof # == "function"', o)) {`
`441`	`441`	`return JsFunction._fromJs(o);`
`442`	`442`	`}`
`443`		`- if (JS<bool>('!', '# instanceof Array', o)) {`
	`443`	`+ if (JS<bool>('!', 'Array.isArray(#)', o)) {`
`444`	`444`	`return JsArray._fromJs(o);`
`445`	`445`	`}`
`446`	`446`	`return JsObject._fromJs(o);`
Original file line number	Diff line number	Diff line change
`@@ -548,7 +548,7 @@ Object _wrapToDart(o) {`
`548`	`548`	`(o) => JsFunction._fromJs(o),`
`549`	`549`	`);`
`550`	`550`	`}`
`551`		`- if (JS('bool', '# instanceof Array', o)) {`
	`551`	`+ if (JS('bool', 'Array.isArray(#)', o)) {`
`552`	`552`	`return _getDartProxy(`
`553`	`553`	`o,`
`554`	`554`	`_DART_OBJECT_PROPERTY_NAME,`