[analyzer] avoid doing redundant work when rewriting a prefixed identifier.

When the `ResolverVisitor` rewrites an expression from a prefixed
identifier to a property access (which it only does for record types),
it's not necessary to re-resolve the target of the property access,
because it was already resolved before deciding to rewrite the
expression.

This change helps pave the way for a follow-up CL in which I'll be
adding assertions that fire if the `ResolverVisitor` tries to resolve
a given subexpression multiple times. (Doing so is dangerous because
it can interfere with the correctness of flow analysis.)

Change-Id: I429e0b744683e662772474967188bb1457168795
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399886
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Paul Berry <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: stereotype441

pkg/analyzer/lib/src/generated/resolver.dart

@@ -3412,7 +3412,7 @@ class ResolverVisitor extends ThrowingAstVisitor<void>
     var rewrittenPropertyAccess =
         _prefixedIdentifierResolver.resolve(node, contextType: contextType);
     if (rewrittenPropertyAccess != null) {
-      _resolvePropertyAccess(rewrittenPropertyAccess, contextType);
+      _resolvePropertyAccessRhs(rewrittenPropertyAccess, contextType);
       // We did record that `node` was replaced with `rewrittenPropertyAccess`.
       // But if `rewrittenPropertyAccess` was itself rewritten, replace the
       // rewrite result of `node`.
@@ -3451,7 +3451,14 @@ class ResolverVisitor extends ThrowingAstVisitor<void>
     inferenceLogWriter?.enterExpression(node, contextType);
     checkUnreachableNode(node);
 
-    _resolvePropertyAccess(node, contextType);
+    var target = node.target;
+    if (target != null) {
+      analyzeExpression(
+          target, SharedTypeSchemaView(UnknownInferredType.instance));
+      popRewrite();
+    }
+
+    _resolvePropertyAccessRhs(node, contextType);
     inferenceLogWriter?.exitExpression(node);
   }
 
@@ -4086,14 +4093,8 @@ class ResolverVisitor extends ThrowingAstVisitor<void>
     callReference.setPseudoExpressionStaticType(callMethodType);
   }
 
-  void _resolvePropertyAccess(PropertyAccessImpl node, DartType contextType) {
-    var target = node.target;
-    if (target != null) {
-      analyzeExpression(
-          target, SharedTypeSchemaView(UnknownInferredType.instance));
-      popRewrite();
-    }
-
+  void _resolvePropertyAccessRhs(
+      PropertyAccessImpl node, DartType contextType) {
     if (node.isNullAware) {
       _startNullAwareAccess(node, node.target);
     }