Elements. Deprecate InterfaceElement.

Change-Id: I59d5a7d98ebde932f411ba3f6e17da43ebf662e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/418940
Reviewed-by: Paul Berry <[email protected]>

Author: scheglov

pkg/analyzer/api.txt

@@ -3337,7 +3337,7 @@ package:analyzer/dart/element/element.dart:
     isAugmentation (getter: bool)
     methods (getter: List<MethodElement>)
     thisType (getter: DartType)
-  InterfaceElement (class extends Object implements InstanceElement):
+  InterfaceElement (class extends Object implements InstanceElement, deprecated):
     new (constructor: InterfaceElement Function())
     allSupertypes (getter: List<InterfaceType>)
     constructors (getter: List<ConstructorElement>, deprecated)

pkg/analyzer/lib/dart/element/element.dart

@@ -1349,6 +1349,7 @@ abstract class InstanceElement
 /// An element that defines an [InterfaceType].
 ///
 /// Clients may not extend, implement or mix-in this class.
+@Deprecated('Use InterfaceElement2 instead')
 abstract class InterfaceElement implements InstanceElement {
   /// All the supertypes defined for this element and its supertypes.
   ///

pkg/analyzer/lib/src/dart/element/element.dart

@@ -218,16 +218,6 @@ class ClassElementImpl extends ClassOrMixinElementImpl
     return false;
   }
 
-  /// Return `true` if the class has a concrete `noSuchMethod()` method distinct
-  /// from the one declared in class `Object`, as per the Dart Language
-  /// Specification (section 10.4).
-  bool get hasNoSuchMethod {
-    MethodElement? method = lookUpConcreteMethod(
-        FunctionElement.NO_SUCH_METHOD_METHOD_NAME, library);
-    var definingClass = method?.enclosingElement3 as ClassElementImpl?;
-    return definingClass != null && !definingClass.isDartCoreObject;
-  }
-
   @override
   bool get isAbstract {
     return hasModifier(Modifier.ABSTRACT);
@@ -5939,7 +5929,10 @@ abstract class InstanceElementImpl2 extends ElementImpl2
 }
 
 abstract class InterfaceElementImpl extends InstanceElementImpl
-    implements InterfaceElement, InterfaceFragment {
+    implements
+        // ignore:deprecated_member_use_from_same_package
+        InterfaceElement,
+        InterfaceFragment {
   /// A list containing all of the mixins that are applied to the class being
   /// extended in order to derive the superclass of this class.
   List<InterfaceTypeImpl> _mixins = const [];
@@ -6152,6 +6145,7 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
     );
   }
 
+  @Deprecated('Use InterfaceElementImpl2 instead')
   @override
   MethodElement? lookUpConcreteMethod(
       String methodName, LibraryElement library) {
@@ -6167,6 +6161,7 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
         .firstWhereOrNull((getter) => getter.isAccessibleIn(library));
   }
 
+  @Deprecated('Use InterfaceElementImpl2 instead')
   @override
   PropertyAccessorElement? lookUpInheritedConcreteGetter(
       String getterName, LibraryElement library) {
@@ -6188,6 +6183,7 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
     }
   }
 
+  @Deprecated('Use InterfaceElementImpl2 instead')
   @override
   MethodElement? lookUpInheritedConcreteMethod(
       String methodName, LibraryElement library) {
@@ -6209,6 +6205,7 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
         setter.enclosingElement3 != this);
   }
 
+  @Deprecated('Use InterfaceElementImpl2 instead')
   @override
   MethodElement? lookUpInheritedMethod(
       String methodName, LibraryElement library) {
@@ -6238,6 +6235,7 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
   /// This method should be used only for error recovery during analysis,
   /// when instance access to a static class member, defined in this class,
   /// or a superclass.
+  @Deprecated('Use InterfaceElementImpl2 instead')
   PropertyAccessorElementOrMember? lookupStaticGetter(
       String name, LibraryElement library) {
     return _implementationsOfGetter(name).firstWhereOrNull(
@@ -6249,6 +6247,7 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
   /// This method should be used only for error recovery during analysis,
   /// when instance access to a static class member, defined in this class,
   /// or a superclass.
+  @Deprecated('Use InterfaceElementImpl2 instead')
   MethodElementOrMember? lookupStaticMethod(
       String name, LibraryElement library) {
     return _implementationsOfMethod(name).firstWhereOrNull(
@@ -6285,6 +6284,7 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
   /// The getters are returned based on the depth of their defining class; if
   /// this class contains a definition of the getter it will occur first, if
   /// Object contains a definition of the getter it will occur last.
+  @Deprecated('Use InterfaceElementImpl2 instead')
   Iterable<PropertyAccessorElementOrMember> _implementationsOfGetter(
       String getterName) sync* {
     var visitedClasses = <InterfaceElement>{};
@@ -6315,6 +6315,7 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
   /// The methods are returned based on the depth of their defining class; if
   /// this class contains a definition of the method it will occur first, if
   /// Object contains a definition of the method it will occur last.
+  @Deprecated('Use InterfaceElementImpl2 instead')
   Iterable<MethodElementOrMember> _implementationsOfMethod(
       String methodName) sync* {
     var visitedClasses = <InterfaceElement>{};

pkg/analyzer/lib/src/dart/element/type_provider.dart

@@ -593,7 +593,8 @@ class TypeProviderImpl extends TypeProviderBase {
   @Deprecated('Use isNonSubtypableClass2() instead')
   @override
   bool isNonSubtypableClass(InterfaceElement element) {
-    return isNonSubtypableClass2(element.asElement2);
+    element as InterfaceElementImpl;
+    return isNonSubtypableClass2(element.element);
   }
 
   @override

pkg/analyzer/lib/src/utilities/extensions/element.dart

@@ -483,18 +483,6 @@ extension InstanceElementImplExtension on InstanceElementImpl {
   }
 }
 
-extension InterfaceElement2Extension on InterfaceElement2 {
-  InterfaceElement get asElement {
-    return firstFragment as InterfaceElement;
-  }
-}
-
-extension InterfaceElementExtension on InterfaceElement {
-  InterfaceElement2 get asElement2 {
-    return (this as InterfaceElementImpl).element;
-  }
-}
-
 extension InterfaceElementImpl2Extension on InterfaceElementImpl2 {
   InterfaceElementImpl get asElement {
     return firstFragment;