Skip to content

Commit 3055e89

Browse files
johnniwintherCommit Queue
authored andcommitted
[cfe] Implement toTextInternal on all InternalExpression nodes
Change-Id: I6fbd1fe1ff071eda2de94da0212291a5ed495c38 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448942 Commit-Queue: Johnni Winther <[email protected]> Reviewed-by: Chloe Stefantsova <[email protected]>
1 parent cbb3237 commit 3055e89

File tree

4 files changed

+472
-136
lines changed

4 files changed

+472
-136
lines changed

pkg/front_end/lib/src/kernel/expression_generator.dart

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -719,10 +719,10 @@ class PropertyAccessGenerator extends Generator {
719719
bool isPostIncDec = false,
720720
}) {
721721
return new CompoundPropertySet(
722-
receiver,
723-
name,
724-
binaryOperator,
725-
value,
722+
receiver: receiver,
723+
propertyName: name,
724+
binaryName: binaryOperator,
725+
value: value,
726726
forEffect: voidContext,
727727
readOffset: fileOffset,
728728
binaryOffset: operatorOffset,
@@ -1106,10 +1106,10 @@ class NullAwarePropertyAccessGenerator extends Generator {
11061106
bool isPostIncDec = false,
11071107
}) {
11081108
return new CompoundPropertySet(
1109-
receiver,
1110-
name,
1111-
binaryOperator,
1112-
value,
1109+
receiver: receiver,
1110+
propertyName: name,
1111+
binaryName: binaryOperator,
1112+
value: value,
11131113
forEffect: voidContext,
11141114
readOffset: fileOffset,
11151115
binaryOffset: operatorOffset,
@@ -1471,9 +1471,9 @@ class IndexedAccessGenerator extends Generator {
14711471
bool voidContext = false,
14721472
}) {
14731473
return new IfNullIndexSet(
1474-
receiver,
1475-
index,
1476-
value,
1474+
receiver: receiver,
1475+
index: index,
1476+
value: value,
14771477
readOffset: fileOffset,
14781478
testOffset: offset,
14791479
writeOffset: fileOffset,
@@ -1492,10 +1492,10 @@ class IndexedAccessGenerator extends Generator {
14921492
bool isPostIncDec = false,
14931493
}) {
14941494
return new CompoundIndexSet(
1495-
receiver,
1496-
index,
1497-
binaryOperator,
1498-
value,
1495+
receiver: receiver,
1496+
index: index,
1497+
binaryName: binaryOperator,
1498+
value: value,
14991499
readOffset: fileOffset,
15001500
binaryOffset: operatorOffset,
15011501
writeOffset: fileOffset,
@@ -1647,9 +1647,9 @@ class ThisIndexedAccessGenerator extends Generator {
16471647
}) {
16481648
Expression receiver = _helper.forest.createThisExpression(fileOffset);
16491649
return new IfNullIndexSet(
1650-
receiver,
1651-
index,
1652-
value,
1650+
receiver: receiver,
1651+
index: index,
1652+
value: value,
16531653
readOffset: fileOffset,
16541654
testOffset: offset,
16551655
writeOffset: fileOffset,
@@ -1669,10 +1669,10 @@ class ThisIndexedAccessGenerator extends Generator {
16691669
}) {
16701670
Expression receiver = _helper.forest.createThisExpression(fileOffset);
16711671
return new CompoundIndexSet(
1672-
receiver,
1673-
index,
1674-
binaryOperator,
1675-
value,
1672+
receiver: receiver,
1673+
index: index,
1674+
binaryName: binaryOperator,
1675+
value: value,
16761676
readOffset: fileOffset,
16771677
binaryOffset: operatorOffset,
16781678
writeOffset: fileOffset,
@@ -1818,10 +1818,10 @@ class SuperIndexedAccessGenerator extends Generator {
18181818
bool voidContext = false,
18191819
}) {
18201820
return new IfNullSuperIndexSet(
1821-
getter,
1822-
setter,
1823-
index,
1824-
value,
1821+
getter: getter,
1822+
setter: setter,
1823+
index: index,
1824+
value: value,
18251825
readOffset: fileOffset,
18261826
testOffset: offset,
18271827
writeOffset: fileOffset,
@@ -1846,11 +1846,11 @@ class SuperIndexedAccessGenerator extends Generator {
18461846
);
18471847
} else {
18481848
return new CompoundSuperIndexSet(
1849-
getter,
1850-
setter,
1851-
index,
1852-
binaryOperator,
1853-
value,
1849+
getter: getter,
1850+
setter: setter,
1851+
index: index,
1852+
binaryName: binaryOperator,
1853+
value: value,
18541854
readOffset: fileOffset,
18551855
binaryOffset: operatorOffset,
18561856
writeOffset: fileOffset,
@@ -3216,13 +3216,13 @@ class ExplicitExtensionIndexedAccessGenerator extends Generator {
32163216
}
32173217

32183218
return new ExtensionIfNullIndexSet(
3219-
extension,
3220-
explicitTypeArguments,
3221-
receiver,
3222-
getter,
3223-
setter,
3224-
index,
3225-
value,
3219+
extension: extension,
3220+
knownTypeArguments: explicitTypeArguments,
3221+
receiver: receiver,
3222+
getter: getter,
3223+
setter: setter,
3224+
index: index,
3225+
value: value,
32263226
readOffset: fileOffset,
32273227
testOffset: offset,
32283228
writeOffset: fileOffset,

0 commit comments

Comments
 (0)