[DAS] Fixes keyword completion inside map literal value

[email protected]

Fixes #57032

Change-Id: I4703fdafc7986d20a40a18b729a4c66eaafff87a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393940
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart

@@ -1840,9 +1840,7 @@ class InScopeCompletionPass extends SimpleAstVisitor<void> {
       collector.completionLocation = 'NullAwareElement_value';
     } else if (offset >= node.separator.end) {
       collector.completionLocation = 'MapLiteralEntry_value';
-      declarationHelper(
-        mustBeStatic: node.inStaticContext,
-      ).addLexicalDeclarations(node);
+      _forExpression(node, mustBeNonVoid: true);
     }
   }
 

pkg/analysis_server/test/services/completion/dart/location/map_literal_test.dart

@@ -106,6 +106,25 @@ suggestions
     kind: keyword
   switch
     kind: keyword
+''');
+  }
+
+  Future<void> test_inside_value_keyword() async {
+    await computeSuggestions('''
+void f() => <String, int>{"": ^};
+''');
+    assertResponse(r'''
+suggestions
+  null
+    kind: keyword
+  false
+    kind: keyword
+  true
+    kind: keyword
+  const
+    kind: keyword
+  switch
+    kind: keyword
 ''');
   }
 }