Format tests/language/e*.

Since I regenerated the test expectations, this also fills in a few
unspecified errors with more precise information.

Change-Id: I4a2450de030a7d38b08f30f46d9d9feca99404f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407082
Reviewed-by: Lasse Nielsen <[email protected]>
Commit-Queue: Lasse Nielsen <[email protected]>
Auto-Submit: Bob Nystrom <[email protected]>

Author: munificent

tests/language/enum/duplicate_lib.dart

@@ -4,10 +4,7 @@
 
 library enum_duplicate_lib;
 
-enum Enum1 {
-  A,
-  B,
-}
+enum Enum1 { A, B }
 
 class Enum2 {
   static Iterable get values => ['Enum2.A', 'Enum2.B'];

tests/language/enum/enhanced_enums_basic_test.dart

@@ -29,12 +29,18 @@ void main() {
   Expect.identical(EnumPlainSemicolon.v3, EnumPlainSemicolon.values[2]);
 
   Expect.equals(3, EnumPlainTrailingCommaSemicolon.values.length);
-  Expect.identical(EnumPlainTrailingCommaSemicolon.v1,
-      EnumPlainTrailingCommaSemicolon.values[0]);
-  Expect.identical(EnumPlainTrailingCommaSemicolon.v2,
-      EnumPlainTrailingCommaSemicolon.values[1]);
-  Expect.identical(EnumPlainTrailingCommaSemicolon.v3,
-      EnumPlainTrailingCommaSemicolon.values[2]);
+  Expect.identical(
+    EnumPlainTrailingCommaSemicolon.v1,
+    EnumPlainTrailingCommaSemicolon.values[0],
+  );
+  Expect.identical(
+    EnumPlainTrailingCommaSemicolon.v2,
+    EnumPlainTrailingCommaSemicolon.values[1],
+  );
+  Expect.identical(
+    EnumPlainTrailingCommaSemicolon.v3,
+    EnumPlainTrailingCommaSemicolon.values[2],
+  );
 
   Expect.equals(6, EnumAll.values.length);
   Expect.identical(EnumAll.v1, EnumAll.values[0]);
@@ -105,7 +111,9 @@ void main() {
   Expect.identical(EnumAll.v4, EnumAll.v3 ^ EnumAll.v2);
 
   Expect.equals(
-      "EnumAll.v1:EnumMixin<num>:ObjectMixin:this", EnumAll.v1.thisAndSuper());
+    "EnumAll.v1:EnumMixin<num>:ObjectMixin:this",
+    EnumAll.v1.thisAndSuper(),
+  );
 
   // Which can reference type parameters.
   Expect.isTrue(EnumAll.v2.test(2)); // does `is T` with `T` being `int`.
@@ -148,35 +156,22 @@ void main() {
 enum EnumPlain { v1, v2, v3 }
 
 // Also with trailing comma.
-enum EnumPlainTrailingComma {
-  v1,
-  v2,
-  v3,
-}
+enum EnumPlainTrailingComma { v1, v2, v3 }
 
 // Also if using type parameters, mixins or interfaces.
 // It only matters whether there is something after the values.
 enum EnumNoSemicolon<T extends num> with ObjectMixin implements Interface {
   v1,
   v2,
-  v3
+  v3,
 }
 
 // Allows semicolon after values, even when not needed.
 // Without trailing comma.
-enum EnumPlainSemicolon {
-  v1,
-  v2,
-  v3;
-}
+enum EnumPlainSemicolon { v1, v2, v3 }
 
 // With trailing comma.
-enum EnumPlainTrailingCommaSemicolon {
-  v1,
-  v2,
-  v3,
-  ;
-}
+enum EnumPlainTrailingCommaSemicolon { v1, v2, v3 }
 
 // Full syntax, with every possible option.
 @EnumAll.v1
@@ -193,8 +188,7 @@ enum EnumAll<S extends num, T extends num>
   v3<int, int>(y: 2),
   v4.named(1, y: 2),
   v5<int, int>.renamed(1, y: 2),
-  v6.new(),
-  ;
+  v6.new();
 
   /// Static members.
   ///
@@ -216,16 +210,16 @@ enum EnumAll<S extends num, T extends num>
   // Constructors.
   // Generative, non-redirecting, unnamed.
   const EnumAll({T? y})
-      : constructor = "unnamed",
-        this.x = 0 as S,
-        y = y ?? (0 as T);
+    : constructor = "unnamed",
+      this.x = 0 as S,
+      y = y ?? (0 as T);
   // Generative, non-redirecting, named.
   const EnumAll.named(this.x, {T? y, String? constructor})
-      : constructor = constructor ?? "named",
-        y = y ?? (0 as T);
+    : constructor = constructor ?? "named",
+      y = y ?? (0 as T);
   // Generative, redirecting.
   const EnumAll.renamed(S x, {T? y})
-      : this.named(x, y: y, constructor: "renamed");
+    : this.named(x, y: y, constructor: "renamed");
   // Factory, non-redirecting.
   factory EnumAll.factory(int index) => values[index] as EnumAll<S, T>;
   // Factory, redirecting (only to other factory constructor).

tests/language/enum/enhanced_enums_error_test.dart

@@ -264,7 +264,7 @@ enum ConflictClassTypeParameter<ConflictClassTypeParameter> {
   // [analyzer] COMPILE_TIME_ERROR.CONFLICTING_TYPE_VARIABLE_AND_CONTAINER
   // [cfe] A type variable can't have the same name as its enclosing declaration.
   e1;
-  //^
+  // [error column 3]
   // [cfe] Couldn't find constructor 'ConflictClassTypeParameter'.
 }
 
@@ -405,10 +405,10 @@ enum ConflictClassEnumValue {
 // Has conflict with implicitly inserted `values` member.
 enum values {
   // ^^^^^^
-  // [analyzer] unspecified
+  // [analyzer] COMPILE_TIME_ERROR.ENUM_WITH_NAME_VALUES
   // [cfe] The name 'values' is not a valid name for an enum. Try using a different name.
   e1;
-  //^
+  // [error column 3]
   // [cfe] Couldn't find constructor 'values'.
 }
 
@@ -449,9 +449,8 @@ enum OverridesEquals {
   e1;
 
   bool operator==(Object other) => identical(e1, other);
-  //   ^^^^^^^^
-  // [analyzer] unspecified
-  //           ^
+  //           ^^
+  // [analyzer] COMPILE_TIME_ERROR.ILLEGAL_CONCRETE_ENUM_MEMBER
   // [cfe] An enum can't declare a non-abstract member named '=='.
 }
 
@@ -460,7 +459,7 @@ enum OverridesHashCode {
 
   int get hashCode => 42;
   //      ^^^^^^^^
-  // [analyzer] unspecified
+  // [analyzer] COMPILE_TIME_ERROR.ILLEGAL_CONCRETE_ENUM_MEMBER
   // [cfe] An enum can't declare a non-abstract member named 'hashCode'.
 }
 
@@ -515,9 +514,9 @@ enum NoConstructorCalls {
   // [cfe] Final field 'x' is not initialized by this constructor.
   //                                       ^^^^^^^^^^^^^^
   // [analyzer] COMPILE_TIME_ERROR.REDIRECT_GENERATIVE_TO_NON_GENERATIVE_CONSTRUCTOR
-  // [cfe] Couldn't find constructor 'NoConstructorCalls.factory'.
   //                                            ^^^^^^^
   // [analyzer] COMPILE_TIME_ERROR.REDIRECT_TO_NON_CONST_CONSTRUCTOR
+  // [cfe] Couldn't find constructor 'NoConstructorCalls.factory'.
 
   factory NoConstructorCalls.factory() => e1; // Valid.
 
@@ -614,7 +613,7 @@ enum DeclaresStaticIndex {
 
 enum InheritsIndex with IndexGetter {
   // ^^^^^^^^^^^^^
-  // [analyzer] unspecified
+  // [analyzer] COMPILE_TIME_ERROR.ILLEGAL_CONCRETE_ENUM_MEMBER
   // [cfe] An enum can't inherit a member named 'index'.
   e1;
 }
@@ -643,8 +642,8 @@ enum ImplementsNeverIndex {
 }
 
 enum NSMImplementsNeverIndex implements NeverIndexGetter {
-  // ^^^^^^
-  // [analyzer] unspecified
+  // ^^^^^^^^^^^^^^^^^^^^^^^
+  // [analyzer] COMPILE_TIME_ERROR.INVALID_IMPLEMENTATION_OVERRIDE
   // [cfe] The implementation of 'index' in the non-abstract class 'NSMImplementsNeverIndex' does not conform to its interface.
   e1;
 
@@ -670,11 +669,10 @@ enum CyclicReference {
 // Since `values` contains `e1`,
 // we can't have a reference in the other direction.
 enum CyclicReferenceValues {
-//   ^
-// [cfe] Constant evaluation error:
   e1(values);
 //^^
 // [analyzer] COMPILE_TIME_ERROR.RECURSIVE_COMPILE_TIME_CONSTANT
+// [cfe] Constant evaluation error:
   final List<CyclicReferenceValues> list;
   const CyclicReferenceValues(this.list);
 }

tests/language/enum/enhanced_enums_subtype_error_test.dart

@@ -35,8 +35,8 @@ abstract class AbstractImplementsWithValues implements Enum {
 }
 
 abstract class AbstractExtendsWithValues extends Enum {
-//                                               ^
-// [cfe] The class 'Enum' can't be extended outside of its library because it's an interface class.
+  //                                             ^
+  // [cfe] The class 'Enum' can't be extended outside of its library because it's an interface class.
   int get values => 42;
   //      ^^^^^^
   // [analyzer] COMPILE_TIME_ERROR.ILLEGAL_ENUM_VALUES
@@ -51,8 +51,8 @@ abstract class AbstractImplementsWithIndex implements Enum {
 }
 
 abstract class AbstractExtendsWithIndex extends Enum {
-//                                              ^
-// [cfe] The class 'Enum' can't be extended outside of its library because it's an interface class.
+  //                                            ^
+  // [cfe] The class 'Enum' can't be extended outside of its library because it's an interface class.
   int get index => 42;
   //      ^^^^^
   // [analyzer] COMPILE_TIME_ERROR.ILLEGAL_CONCRETE_ENUM_MEMBER
@@ -184,7 +184,7 @@ enum EnumImplementsEnum implements MyEnum {
   // [cfe] 'MyEnum' is an enum and can't be extended or implemented.
   //                               ^^^^^^
   // [analyzer] COMPILE_TIME_ERROR.IMPLEMENTS_NON_CLASS
-  e1;
+  e1,
 }
 
 enum EnumMixesInEnum with MyEnum {
@@ -195,11 +195,9 @@ enum EnumMixesInEnum with MyEnum {
   // [analyzer] COMPILE_TIME_ERROR.MIXIN_OF_NON_CLASS
   // [cfe] The class 'MyEnum' can't be used as a mixin because it extends a class other than 'Object'.
   // [cfe] The class 'MyEnum' can't be used as a mixin because it isn't a mixin class nor a mixin.
-  e1;
+  e1,
 }
 
 void main() {}
 
-enum MyEnum {
-  e1;
-}
+enum MyEnum { e1 }

tests/language/enum/enum_test.dart

@@ -10,10 +10,10 @@ enum Enum2 { A }
 
 enum Enum3 { B, C }
 
-enum Enum4 {
-  D,
-  E,
-}
+// Don't format to preserve the trailing comma.
+// dart format off
+enum Enum4 { D, E, }
+// dart format on
 
 enum Enum5 { F, G, H }
 
@@ -35,7 +35,7 @@ enum JSFunctionPrototype {
   constructor,
   apply,
   bind,
-  call
+  call,
 }
 
 void expectIs<T>(T t, bool Function(Object?) test) {

tests/language/enum/index_test.dart

@@ -8,10 +8,7 @@ library enum_index_test;
 
 import 'package:expect/expect.dart';
 
-enum Enum {
-  A,
-  B,
-}
+enum Enum { A, B }
 
 class Class {
   var index;

tests/language/enum/initialization_near_stack_overflow_test.dart

@@ -9,10 +9,7 @@
 // how much stack is left and used by the compiler. It should never crash nor
 // produce a runtime exception.
 
-enum Fruit {
-  apple,
-  banana,
-}
+enum Fruit { apple, banana }
 
 getFruit() => Fruit.apple;
 

tests/language/enum/private_lib.dart

@@ -4,7 +4,4 @@
 
 library enum_private_lib;
 
-enum Enum2 {
-  _A,
-  _B,
-}
+enum Enum2 { _A, _B }

tests/language/enum/private_runtime_1_test.dart

@@ -13,10 +13,7 @@ import 'package:expect/expect.dart';
 
 import 'private_lib.dart';
 
-enum Enum1 {
-  _A,
-  _B,
-}
+enum Enum1 { _A, _B }
 
 main() {
   Expect.equals('Enum1._A,Enum1._B', Enum1.values.join(','));

tests/language/enum/private_runtime_test.dart

@@ -13,10 +13,7 @@ import 'package:expect/expect.dart';
 
 import 'private_lib.dart';
 
-enum Enum1 {
-  _A,
-  _B,
-}
+enum Enum1 { _A, _B }
 
 main() {
   Expect.equals('Enum1._A,Enum1._B', Enum1.values.join(','));