Fine. Persist type erasure and self-ref flags for extension types

Capture more observable facts about extension types in fine-grained
manifests to improve matching and invalidation.

This change persists additional fields on `ExtensionTypeItem` and uses
them during matching:
- `typeErasure`
- `representationType`
- `hasImplementsSelfReference`
- `hasRepresentationSelfReference`

It updates encode/decode/write paths, extends `match()` to compare the
new fields, and teaches the result printer to display the flags and
types when element manifests are enabled. The analyzer data format is
bumped (`DATA_VERSION` 532 → 533) to invalidate stale caches.

Motivation:
- Make manifest identities reflect changes to an extension type’s
  underlying representation and erasure.
- Enable manifest-driven, flag-level invalidation without re-deriving
  from other properties.
- Improve determinism and clarity in diagnostics and reuse decisions.

Notes:
- Existing behavior is preserved; changes primarily affect identity,
  reuse, and printed diagnostics.
- Cache rebuilds are expected due to the version bump.

Change-Id: I008c9549265811dacbabfcdb1d2554349c55fee2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447983
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -106,7 +106,7 @@ testFineAfterLibraryAnalyzerHook;
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 532;
+  static const int DATA_VERSION = 533;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/fine/manifest_item.dart

@@ -264,6 +264,11 @@ class ExtensionItem<E extends ExtensionElementImpl> extends InstanceItem<E> {
 }
 
 class ExtensionTypeItem extends InterfaceItem<ExtensionTypeElementImpl> {
+  final bool hasImplementsSelfReference;
+  final bool hasRepresentationSelfReference;
+  final ManifestType representationType;
+  final ManifestType typeErasure;
+
   ExtensionTypeItem({
     required super.id,
     required super.metadata,
@@ -279,6 +284,10 @@ class ExtensionTypeItem extends InterfaceItem<ExtensionTypeElementImpl> {
     required super.supertype,
     required super.mixins,
     required super.interfaces,
+    required this.hasImplementsSelfReference,
+    required this.hasRepresentationSelfReference,
+    required this.representationType,
+    required this.typeErasure,
   });
 
   factory ExtensionTypeItem.fromElement({
@@ -302,6 +311,10 @@ class ExtensionTypeItem extends InterfaceItem<ExtensionTypeElementImpl> {
         supertype: element.supertype?.encode(context),
         mixins: element.mixins.encode(context),
         interfaces: element.interfaces.encode(context),
+        hasImplementsSelfReference: element.hasImplementsSelfReference,
+        hasRepresentationSelfReference: element.hasRepresentationSelfReference,
+        representationType: element.representation.type.encode(context),
+        typeErasure: element.typeErasure.encode(context),
       );
     });
   }
@@ -322,8 +335,31 @@ class ExtensionTypeItem extends InterfaceItem<ExtensionTypeElementImpl> {
       mixins: ManifestType.readList(reader),
       interfaces: ManifestType.readList(reader),
       interface: ManifestInterface.read(reader),
+      hasImplementsSelfReference: reader.readBool(),
+      hasRepresentationSelfReference: reader.readBool(),
+      representationType: ManifestType.read(reader),
+      typeErasure: ManifestType.read(reader),
     );
   }
+
+  @override
+  bool match(MatchContext context, ExtensionTypeElementImpl element) {
+    return super.match(context, element) &&
+        hasImplementsSelfReference == element.hasImplementsSelfReference &&
+        hasRepresentationSelfReference ==
+            element.hasRepresentationSelfReference &&
+        representationType.match(context, element.representation.type) &&
+        typeErasure.match(context, element.typeErasure);
+  }
+
+  @override
+  void write(BufferedSink sink) {
+    super.write(sink);
+    sink.writeBool(hasImplementsSelfReference);
+    sink.writeBool(hasRepresentationSelfReference);
+    representationType.write(sink);
+    typeErasure.write(sink);
+  }
 }
 
 /// The item for [InstanceElementImpl].

pkg/analyzer/test/src/dart/analysis/driver_test.dart

@@ -24174,28 +24174,27 @@ extension type A(double it) {
 [operation] linkLibraryCycle
   package:test/a.dart
     declaredExtensionTypes
-      A: #M0
+      A: #M6
         declaredFields
-          it: #M6
-        declaredGetters
           it: #M7
+        declaredGetters
+          it: #M8
         declaredConstructors
-          named: #M3
-          new: #M8
-        interface: #M9
+          named: #M9
+          new: #M10
+        interface: #M11
           map
-            it: #M7
+            it: #M8
   requirements
 [operation] reuseLinkedBundle
   package:test/test.dart
 [operation] checkLibraryDiagnosticsRequirements
   library: /home/test/lib/test.dart
-  interfaceChildrenIdsMismatch
+  topLevelIdMismatch
     libraryUri: package:test/a.dart
-    interfaceName: A
-    childrenPropertyName: constructors
-    expectedIds: #M4 #M3
-    actualIds: #M8 #M3
+    name: A
+    expectedId: #M0
+    actualId: #M6
 [operation] analyzeFile
   file: /home/test/lib/test.dart
   library: /home/test/lib/test.dart
@@ -24212,10 +24211,10 @@ extension type A(double it) {
     libraries
       package:test/a.dart
         exportedTopLevels
-          A: #M0
+          A: #M6
         interfaces
           A
-            allConstructors: #M8 #M3
+            allConstructors: #M10 #M9
 [status] idle
 [future] getErrors T2
   ErrorsResult #3
@@ -24297,27 +24296,26 @@ extension type A(double it) {}
 [operation] linkLibraryCycle
   package:test/a.dart
     declaredExtensionTypes
-      A: #M0
+      A: #M6
         declaredFields
-          it: #M6
-        declaredGetters
           it: #M7
+        declaredGetters
+          it: #M8
         declaredConstructors
-          new: #M8
-        interface: #M9
+          new: #M9
+        interface: #M10
           map
-            it: #M7
+            it: #M8
   requirements
 [operation] reuseLinkedBundle
   package:test/test.dart
 [operation] checkLibraryDiagnosticsRequirements
   library: /home/test/lib/test.dart
-  interfaceConstructorIdMismatch
+  topLevelIdMismatch
     libraryUri: package:test/a.dart
-    interfaceName: A
-    constructorName: new
-    expectedId: #M3
-    actualId: #M8
+    name: A
+    expectedId: #M0
+    actualId: #M6
 [operation] analyzeFile
   file: /home/test/lib/test.dart
   library: /home/test/lib/test.dart
@@ -24332,11 +24330,11 @@ extension type A(double it) {}
     libraries
       package:test/a.dart
         exportedTopLevels
-          A: #M0
+          A: #M6
         interfaces
           A
             requestedConstructors
-              new: #M8
+              new: #M9
 [status] idle
 [future] getErrors T2
   ErrorsResult #3
@@ -24421,26 +24419,49 @@ extension type A(double it) {
 [operation] linkLibraryCycle
   package:test/a.dart
     declaredExtensionTypes
-      A: #M0
+      A: #M7
         declaredFields
-          it: #M7
-        declaredGetters
           it: #M8
+        declaredGetters
+          it: #M9
         declaredConstructors
-          named: #M3
-          new: #M9
-        interface: #M10
+          named: #M10
+          new: #M11
+        interface: #M12
           map
-            it: #M8
+            it: #M9
   requirements
 [operation] reuseLinkedBundle
   package:test/test.dart
-[operation] getErrorsFromBytes
+[operation] checkLibraryDiagnosticsRequirements
+  library: /home/test/lib/test.dart
+  topLevelIdMismatch
+    libraryUri: package:test/a.dart
+    name: A
+    expectedId: #M0
+    actualId: #M7
+[operation] analyzeFile
   file: /home/test/lib/test.dart
   library: /home/test/lib/test.dart
+[stream]
+  ResolvedUnitResult #2
+    path: /home/test/lib/test.dart
+    uri: package:test/test.dart
+    flags: exists isLibrary
+[operation] analyzedLibrary
+  file: /home/test/lib/test.dart
+  requirements
+    libraries
+      package:test/a.dart
+        exportedTopLevels
+          A: #M7
+        interfaces
+          A
+            requestedConstructors
+              named: #M10
 [status] idle
 [future] getErrors T2
-  ErrorsResult #2
+  ErrorsResult #3
     path: /home/test/lib/test.dart
     uri: package:test/test.dart
     flags: isLibrary
@@ -50881,6 +50902,82 @@ extension type A(int it) {
     );
   }
 
+  test_manifest_extensionType_hasImplementsSelfReference() async {
+    await _runLibraryManifestScenario(
+      initialCode: r'''
+extension type A(int it) implements Object {}
+''',
+      expectedInitialEvents: r'''
+[operation] linkLibraryCycle SDK
+[operation] linkLibraryCycle
+  package:test/test.dart
+    declaredExtensionTypes
+      A: #M0
+        declaredFields
+          it: #M1
+        declaredGetters
+          it: #M2
+        interface: #M3
+          map
+            it: #M2
+''',
+      updatedCode: r'''
+extension type A(int it) implements A {}
+''',
+      expectedUpdatedEvents: r'''
+[operation] linkLibraryCycle
+  package:test/test.dart
+    declaredExtensionTypes
+      A: #M4
+        declaredFields
+          it: #M5
+        declaredGetters
+          it: #M6
+        interface: #M7
+          map
+            it: #M6
+''',
+    );
+  }
+
+  test_manifest_extensionType_hasRepresentationSelfReference() async {
+    await _runLibraryManifestScenario(
+      initialCode: r'''
+extension type A(NoSuchType it) {}
+''',
+      expectedInitialEvents: r'''
+[operation] linkLibraryCycle SDK
+[operation] linkLibraryCycle
+  package:test/test.dart
+    declaredExtensionTypes
+      A: #M0
+        declaredFields
+          it: #M1
+        declaredGetters
+          it: #M2
+        interface: #M3
+          map
+            it: #M2
+''',
+      updatedCode: r'''
+extension type A(A it) {}
+''',
+      expectedUpdatedEvents: r'''
+[operation] linkLibraryCycle
+  package:test/test.dart
+    declaredExtensionTypes
+      A: #M4
+        declaredFields
+          it: #M5
+        declaredGetters
+          it: #M6
+        interface: #M7
+          map
+            it: #M6
+''',
+    );
+  }
+
   test_manifest_extensionType_implements_add() async {
     await _runLibraryManifestScenario(
       initialCode: r'''
@@ -51205,17 +51302,17 @@ extension type A(double it) {
 [operation] linkLibraryCycle
   package:test/test.dart
     declaredExtensionTypes
-      A: #M0
+      A: #M5
         declaredFields
-          it: #M5
-        declaredGetters
           it: #M6
+        declaredGetters
+          it: #M7
         declaredMethods
-          foo: #M3
-        interface: #M7
+          foo: #M8
+        interface: #M9
           map
-            foo: #M3
-            it: #M6
+            foo: #M8
+            it: #M7
 ''',
     );
   }
@@ -51278,6 +51375,44 @@ extension type A(int it) {
     );
   }
 
+  test_manifest_extensionType_typeErasure() async {
+    await _runLibraryManifestScenario(
+      initialCode: r'''
+extension type A(num it) {}
+''',
+      expectedInitialEvents: r'''
+[operation] linkLibraryCycle SDK
+[operation] linkLibraryCycle
+  package:test/test.dart
+    declaredExtensionTypes
+      A: #M0
+        declaredFields
+          it: #M1
+        declaredGetters
+          it: #M2
+        interface: #M3
+          map
+            it: #M2
+''',
+      updatedCode: r'''
+extension type A(int it) {}
+''',
+      expectedUpdatedEvents: r'''
+[operation] linkLibraryCycle
+  package:test/test.dart
+    declaredExtensionTypes
+      A: #M4
+        declaredFields
+          it: #M5
+        declaredGetters
+          it: #M6
+        interface: #M7
+          map
+            it: #M6
+''',
+    );
+  }
+
   test_manifest_extensionType_typeParameters() async {
     await _runLibraryManifestScenario(
       initialCode: r'''