[primary constructors] support for avoid_final_parameters

Fixes: #62033

Change-Id: I27547ece4f510f8759262f78951dd201cb24b389
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/463060
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/linter/lib/src/rules/avoid_final_parameters.dart

@@ -5,6 +5,7 @@
 import 'package:analyzer/analysis_rule/analysis_rule.dart';
 import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/analysis_rule/rule_visitor_registry.dart';
+import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/error/error.dart';
@@ -31,6 +32,11 @@ class AvoidFinalParameters extends AnalysisRule {
     RuleVisitorRegistry registry,
     RuleContext context,
   ) {
+    // This lint isn't relevant with primary constructors enabled
+    // as `final` is no longer used to indicate a parameter is final,
+    // but rather as a declaring parameter in a primary constructor.
+    if (context.isFeatureEnabled(Feature.declaring_constructors)) return;
+
     var visitor = _Visitor(this);
     registry.addConstructorDeclaration(this, visitor);
     registry.addFunctionExpression(this, visitor);

pkg/linter/messages.yaml

@@ -9422,6 +9422,9 @@ LinterLintCode:
     deprecatedDetails: |-
       **Note:** This lint rule was deprecated in Dart 3.11 and
       is set to be removed in a future release of the Dart SDK.
+      Also note that the lint is not applied to code that is opted
+      in to the `primary-constructors` language feature where using
+      `final` for a parameter becomes a compile-time error.
       If you want to ensure parameters aren't reassigned in function bodies,
       consider enabling the
       [`parameter_assignments`](https://dart.dev/lints/parameter_assignments)

pkg/linter/test/rules/avoid_final_parameters_test.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/src/diagnostic/diagnostic.dart' as diag;
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
@@ -10,11 +11,16 @@ import '../rule_test_support.dart';
 void main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(AvoidFinalParametersTest);
+    defineReflectiveTests(AvoidFinalParametersPrePrimaryConstructorsTest);
   });
 }
 
 @reflectiveTest
-class AvoidFinalParametersTest extends LintRuleTest {
+class AvoidFinalParametersPrePrimaryConstructorsTest extends LintRuleTest {
+  @override
+  List<String> get experiments =>
+      super.experiments..remove(Feature.declaring_constructors.enableString);
+
   @override
   String get lintRule => LintNames.avoid_final_parameters;
 
@@ -223,3 +229,20 @@ class B extends A {
     );
   }
 }
+
+@reflectiveTest
+class AvoidFinalParametersTest extends LintRuleTest {
+  @override
+  String get lintRule => LintNames.avoid_final_parameters;
+
+  // With primary constructors, this lint is disabled.
+  // No need to repeat all the tests; one will do.
+  test_constructorSimple_final() async {
+    await assertNoDiagnostics(r'''
+class C {
+  // Would be flagged.
+  C(final int p);
+}
+''');
+  }
+}