[analyzer] Switch error code references in messages.yaml to camelCase

This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/444921, which renamed
analyzer error codes from SCREAMING_CAPS conventions to camelCase
conventions. That CL left a few deprecated error codes in place
because they were referred to in comments in the `messages.yaml` file,
and those references couldn't be fixed in an automated fashion.

This CL cleans up the references in `messages.yaml` to use the new
camelCase constants, and removes the deprecated SCREAMING_CAPS
constants that are no longer needed.

Change-Id: I6a6a696406efa02d73775d1a8e0defa5a0e8e39b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445105
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Paul Berry <[email protected]>

Author: stereotype441

pkg/analyzer/lib/src/dart/error/syntactic_errors.g.dart

@@ -728,9 +728,6 @@ class ParserErrorCode extends DiagnosticCode {
         "Expected a type name.",
       );
 
-  @Deprecated("Please use experimentNotEnabled")
-  static const ParserErrorCode EXPERIMENT_NOT_ENABLED = experimentNotEnabled;
-
   static const ParserErrorCode experimentNotEnabled = ParserErrorCode(
     'EXPERIMENT_NOT_ENABLED',
     "This requires the '{0}' language feature to be enabled.",

pkg/analyzer/lib/src/error/codes.g.dart

@@ -3148,10 +3148,6 @@ class CompileTimeErrorCode extends DiagnosticCode {
     withArguments: _withArgumentsInitializingFormalForNonExistentField,
   );
 
-  @Deprecated("Please use instanceAccessToStaticMember")
-  static const CompileTimeErrorCode INSTANCE_ACCESS_TO_STATIC_MEMBER =
-      instanceAccessToStaticMember;
-
   /// Parameters:
   /// String p0: the name of the static member
   /// String p1: the kind of the static member (field, getter, setter, or
@@ -3283,9 +3279,6 @@ class CompileTimeErrorCode extends DiagnosticCode {
     withArguments: _withArgumentsInterfaceClassExtendedOutsideOfLibrary,
   );
 
-  @Deprecated("Please use invalidOverride")
-  static const CompileTimeErrorCode INVALID_OVERRIDE = invalidOverride;
-
   /// No parameters.
   static const CompileTimeErrorWithoutArguments
   invalidAnnotation = CompileTimeErrorWithoutArguments(
@@ -3536,7 +3529,7 @@ class CompileTimeErrorCode extends DiagnosticCode {
       );
 
   /// The parameters of this error code must be kept in sync with those of
-  /// [CompileTimeErrorCode.INVALID_OVERRIDE].
+  /// [CompileTimeErrorCode.invalidOverride].
   ///
   /// Parameters:
   /// Object p0: the name of the declared member that is not a valid override.
@@ -3562,7 +3555,7 @@ class CompileTimeErrorCode extends DiagnosticCode {
   );
 
   /// The parameters of this error code must be kept in sync with those of
-  /// [CompileTimeErrorCode.INVALID_OVERRIDE].
+  /// [CompileTimeErrorCode.invalidOverride].
   ///
   /// Parameters:
   /// Object p0: the name of the declared setter that is not a valid override.
@@ -6278,10 +6271,6 @@ class CompileTimeErrorCode extends DiagnosticCode {
     withArguments: _withArgumentsTopLevelCycle,
   );
 
-  @Deprecated("Please use typeArgumentNotMatchingBounds")
-  static const CompileTimeErrorCode TYPE_ARGUMENT_NOT_MATCHING_BOUNDS =
-      typeArgumentNotMatchingBounds;
-
   /// No parameters.
   static const CompileTimeErrorWithoutArguments
   typeAliasCannotReferenceItself = CompileTimeErrorWithoutArguments(
@@ -6340,7 +6329,7 @@ class CompileTimeErrorCode extends DiagnosticCode {
     hasPublishedDocs: true,
   );
 
-  /// See [CompileTimeErrorCode.TYPE_ARGUMENT_NOT_MATCHING_BOUNDS].
+  /// See [CompileTimeErrorCode.typeArgumentNotMatchingBounds].
   ///
   /// Parameters:
   /// String p0: the name of the type parameter
@@ -6492,9 +6481,6 @@ class CompileTimeErrorCode extends DiagnosticCode {
     uniqueName: 'UNCHECKED_USE_OF_NULLABLE_VALUE_IN_YIELD_EACH',
   );
 
-  @Deprecated("Please use undefinedClass")
-  static const CompileTimeErrorCode UNDEFINED_CLASS = undefinedClass;
-
   /// Parameters:
   /// String p0: the name of the annotation
   static const CompileTimeErrorTemplate<
@@ -6526,7 +6512,7 @@ class CompileTimeErrorCode extends DiagnosticCode {
     withArguments: _withArgumentsUndefinedClass,
   );
 
-  /// Same as [CompileTimeErrorCode.UNDEFINED_CLASS], but to catch using
+  /// Same as [CompileTimeErrorCode.undefinedClass], but to catch using
   /// "boolean" instead of "bool" in order to improve the correction message.
   ///
   /// Parameters:
@@ -6945,7 +6931,7 @@ class CompileTimeErrorCode extends DiagnosticCode {
     withArguments: _withArgumentsUndefinedSuperSetter,
   );
 
-  /// This is a specialization of [INSTANCE_ACCESS_TO_STATIC_MEMBER] that is used
+  /// This is a specialization of [instanceAccessToStaticMember] that is used
   /// when we are able to find the name defined in a supertype. It exists to
   /// provide a more informative error message.
   ///
@@ -11470,7 +11456,7 @@ class WarningCode extends DiagnosticCode {
     withArguments: _withArgumentsReturnTypeInvalidForCatchError,
   );
 
-  /// There is also a [ParserErrorCode.EXPERIMENT_NOT_ENABLED] code which
+  /// There is also a [ParserErrorCode.experimentNotEnabled] code which
   /// catches some cases of constructor tearoff features (like
   /// `List<int>.filled;`). Other constructor tearoff cases are not realized
   /// until resolution (like `List.filled;`).

pkg/analyzer/messages.yaml

@@ -8749,7 +8749,7 @@ CompileTimeErrorCode:
     hasPublishedDocs: true
     comment: |-
       The parameters of this error code must be kept in sync with those of
-      [CompileTimeErrorCode.INVALID_OVERRIDE].
+      [CompileTimeErrorCode.invalidOverride].
     documentation: |-
       #### Description
 
@@ -8844,7 +8844,7 @@ CompileTimeErrorCode:
     hasPublishedDocs: true
     comment: |-
       The parameters of this error code must be kept in sync with those of
-      [CompileTimeErrorCode.INVALID_OVERRIDE].
+      [CompileTimeErrorCode.invalidOverride].
   INVALID_INLINE_FUNCTION_TYPE:
     parameters: none
     problemMessage: "Inline function types can't be used for parameters in a generic function type."
@@ -16375,7 +16375,7 @@ CompileTimeErrorCode:
     correctionMessage: "Try using a type that is the same as or a subclass of '#p1'."
     hasPublishedDocs: true
     comment: |-
-      See [CompileTimeErrorCode.TYPE_ARGUMENT_NOT_MATCHING_BOUNDS].
+      See [CompileTimeErrorCode.typeArgumentNotMatchingBounds].
     documentation: |-
       #### Description
 
@@ -16702,7 +16702,7 @@ CompileTimeErrorCode:
     isUnresolvedIdentifier: true
     hasPublishedDocs: true
     comment: |-
-      Same as [CompileTimeErrorCode.UNDEFINED_CLASS], but to catch using
+      Same as [CompileTimeErrorCode.undefinedClass], but to catch using
       "boolean" instead of "bool" in order to improve the correction message.
   UNDEFINED_CONSTRUCTOR_IN_INITIALIZER:
     parameters:
@@ -17714,7 +17714,7 @@ CompileTimeErrorCode:
     correctionMessage: "Try adding '#p0.' before the name."
     hasPublishedDocs: true
     comment: |-
-      This is a specialization of [INSTANCE_ACCESS_TO_STATIC_MEMBER] that is used
+      This is a specialization of [instanceAccessToStaticMember] that is used
       when we are able to find the name defined in a supertype. It exists to
       provide a more informative error message.
     documentation: |-
@@ -27394,7 +27394,7 @@ WarningCode:
     correctionMessage: "Try updating your pubspec.yaml to set the minimum SDK constraint to 2.15 or higher, and running 'pub get'."
     hasPublishedDocs: true
     comment: |-
-      There is also a [ParserErrorCode.EXPERIMENT_NOT_ENABLED] code which
+      There is also a [ParserErrorCode.experimentNotEnabled] code which
       catches some cases of constructor tearoff features (like
       `List<int>.filled;`). Other constructor tearoff cases are not realized
       until resolution (like `List.filled;`).

pkg/analyzer/tool/messages/error_code_info.dart

@@ -36,12 +36,6 @@ const List<ErrorClassInfo> errorClasses = [
     file: codesFile,
     name: 'CompileTimeErrorCode',
     type: 'COMPILE_TIME_ERROR',
-    deprecatedSnakeCaseNames: {
-      'INSTANCE_ACCESS_TO_STATIC_MEMBER', // Referenced by `messages.yaml`.
-      'INVALID_OVERRIDE', // Referenced by `messages.yaml`.
-      'TYPE_ARGUMENT_NOT_MATCHING_BOUNDS', // Referenced by `messages.yaml`.
-      'UNDEFINED_CLASS', // Referenced by `messages.yaml`.
-    },
   ),
   ErrorClassInfo(
     file: scannerErrorFile,
@@ -73,7 +67,6 @@ const List<ErrorClassInfo> errorClasses = [
     severity: 'ERROR',
     includeCfeMessages: true,
     deprecatedSnakeCaseNames: {
-      'EXPERIMENT_NOT_ENABLED', // Referenced by `messages.yaml`.
       'UNEXPECTED_TOKEN', // Referenced by `package:dart_style`.
     },
   ),