[analysis_server] Disallow inlining SDK code

Fixes #60308

Change-Id: Ic813b309f57464f16e3285e594ec4ec18f14f4e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442120
Reviewed-by: Keerti Parthasarathy <[email protected]>
Commit-Queue: Keerti Parthasarathy <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: DanTup

pkg/analysis_server/lib/src/services/refactoring/legacy/inline_method.dart

@@ -303,6 +303,12 @@ class InlineMethodRefactoringImpl extends RefactoringImpl
     }
     var methodElement = _methodElement!;
 
+    // Disallow inlining SDK code.
+    if (methodElement.library.isInSdk) {
+      result = RefactoringStatus.fatal("Can't inline SDK code.");
+      return result;
+    }
+
     // Disallow inlining an augmented method.
     var methodFragment = methodElement.firstFragment;
     if (methodFragment.nextFragment != null) {

pkg/analysis_server/test/services/refactoring/legacy/inline_method_test.dart

@@ -351,6 +351,17 @@ void f() {
     return _assertConditionsFatal("Can't inline a class method reference.");
   }
 
+  Future<void> test_bad_sdkCode() async {
+    await indexTestUnit(r'''
+void f() {
+  print('');
+}
+''');
+    _createRefactoring('print');
+    // error
+    return _assertInvalidSelectionSdkCode();
+  }
+
   Future<void> test_bad_severalReturns() async {
     await indexTestUnit(r'''
 test() {
@@ -2267,6 +2278,10 @@ class _InlineMethodTest extends RefactoringTest {
     );
   }
 
+  Future<void> _assertInvalidSelectionSdkCode() {
+    return _assertConditionsFatal("Can't inline SDK code.");
+  }
+
   Future<void> _assertSuccessfulRefactoring(String expectedCode) async {
     var status = await refactoring.checkInitialConditions();
     assertRefactoringStatusOK(status);