[tests] Adding ddc and vm specific hot reload differences.

Change-Id: If2a398bc8020438b7c46e58cba03180bfa61b660
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407180
Commit-Queue: Mark Zhou <[email protected]>
Reviewed-by: Nicholas Shahan <[email protected]>

Author: Markzipan

pkg/reload_test/lib/reload_test_utils.dart

@@ -9,3 +9,7 @@
 export 'src/_reload_utils_api.dart'
     if (dart.library.io) 'src/_vm_reload_utils.dart'
     if (dart.library.js_interop) 'src/_ddc_reload_utils.dart';
+
+bool get isVmRuntime => const bool.fromEnvironment('dart.library.io');
+
+bool get isDdcRuntime => const bool.fromEnvironment('dart.library.js_interop');

tests/hot_reload/change_instance_format4/main.0.dart

@@ -10,7 +10,8 @@ import 'package:reload_test/reload_test_utils.dart';
 
 // Tests reload succeeds when instance format changes.
 // Change: Bar {c:42}, Foo : Bar {d, e} -> Foo {c:42}
-// Validate: c keeps the value in the retained Foo object.
+// In the VM: c keeps the value in the retained Foo object.
+// For DDC: c adopts the value in the newly declared field in Bar.
 
 class Bar {
   var c;
@@ -29,5 +30,9 @@ Future<void> main() async {
   Expect.equals(42, f.c);
   await hotReload();
 
-  Expect.equals(42, f.c);
+  if (isVmRuntime) {
+    Expect.equals(42, f.c);
+  } else if (isDdcRuntime) {
+    Expect.isNull(f.c);
+  }
 }

tests/hot_reload/change_instance_format4/main.1.dart

@@ -10,7 +10,8 @@ import 'package:reload_test/reload_test_utils.dart';
 
 // Tests reload succeeds when instance format changes.
 // Change: Bar {c:42}, Foo : Bar {d, e} -> Foo {c:42}
-// Validate: c keeps the value in the retained Foo object.
+// In the VM: c keeps the value in the retained Foo object.
+// For DDC: c adopts the value in the newly declared field in Bar.
 
 class Foo {
   var c;
@@ -24,13 +25,17 @@ Future<void> main() async {
   Expect.equals(42, f.c);
   await hotReload();
 
-  Expect.equals(42, f.c);
+  if (isVmRuntime) {
+    Expect.equals(42, f.c);
+  } else if (isDdcRuntime) {
+    Expect.isNull(f.c);
+  }
 }
 
 /** DIFF **/
 /*
- // Change: Bar {c:42}, Foo : Bar {d, e} -> Foo {c:42}
- // Validate: c keeps the value in the retained Foo object.
+ // In the VM: c keeps the value in the retained Foo object.
+ // For DDC: c adopts the value in the newly declared field in Bar.
  
 -class Bar {
 +class Foo {

tests/hot_reload/change_instance_format7_ddc/config.json

@@ -0,0 +1,6 @@
+{
+  "exclude": ["vm"],
+  "expectedErrors": {
+    "1": "type parameters have changed"
+  }
+}

tests/hot_reload/change_instance_format7_ddc/main.0.dart

@@ -0,0 +1,23 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:expect/expect.dart';
+import 'package:reload_test/reload_test_utils.dart';
+
+// Adapted from:
+// https://github.com/dart-lang/sdk/blob/1a486499bf73ee5b007abbe522b94869a1f36d02/runtime/vm/isolate_reload_test.cc#L4051
+
+// Tests reload succeeds when type parameters are changed for allocated class.
+// Change: Foo<A,B> {a, b} -> Foo<A> {a}
+// Validate: return value from main is correct.
+// This test is rejected at compile-time in DDC (vs at runtime for the VM).
+
+class Foo<A, B> {
+  var a;
+  var b;
+}
+
+Future<void> main() async {
+  await hotReload(expectRejection: true);
+}

tests/hot_reload/change_instance_format7_ddc/main.1.reject.dart

@@ -0,0 +1,36 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:expect/expect.dart';
+import 'package:reload_test/reload_test_utils.dart';
+
+// Adapted from:
+// https://github.com/dart-lang/sdk/blob/1a486499bf73ee5b007abbe522b94869a1f36d02/runtime/vm/isolate_reload_test.cc#L4051
+
+// Tests reload succeeds when type parameters are changed for allocated class.
+// Change: Foo<A,B> {a, b} -> Foo<A> {a}
+// Validate: return value from main is correct.
+// This test is rejected at compile-time in DDC (vs at runtime for the VM).
+
+class Foo<A> {
+  var a;
+}
+
+Future<void> main() async {
+  await hotReload(expectRejection: true);
+}
+
+/** DIFF **/
+/*
+ // Validate: return value from main is correct.
+ // This test is rejected at compile-time in DDC (vs at runtime for the VM).
+ 
+-class Foo<A, B> {
++class Foo<A> {
+   var a;
+-  var b;
+ }
+ 
+ Future<void> main() async {
+*/

tests/hot_reload/change_instance_format7_vm/config.json

@@ -0,0 +1,4 @@
+{
+  "exclude": ["d8", "chrome"]
+}
+

tests/hot_reload/change_instance_format7_vm/main.0.dart

@@ -0,0 +1,23 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:expect/expect.dart';
+import 'package:reload_test/reload_test_utils.dart';
+
+// Adapted from:
+// https://github.com/dart-lang/sdk/blob/1a486499bf73ee5b007abbe522b94869a1f36d02/runtime/vm/isolate_reload_test.cc#L4051
+
+// Tests reload succeeds when type parameters are changed for allocated class.
+// Change: Foo<A,B> {a, b} -> Foo<A> {a}
+// Validate: return value from main is correct.
+// Please note: This test works because no instances are created from Foo.
+
+class Foo<A, B> {
+  var a;
+  var b;
+}
+
+Future<void> main() async {
+  await hotReload();
+}

tests/hot_reload/change_instance_format7_vm/main.1.dart

@@ -0,0 +1,36 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:expect/expect.dart';
+import 'package:reload_test/reload_test_utils.dart';
+
+// Adapted from:
+// https://github.com/dart-lang/sdk/blob/1a486499bf73ee5b007abbe522b94869a1f36d02/runtime/vm/isolate_reload_test.cc#L4051
+
+// Tests reload succeeds when type parameters are changed for allocated class.
+// Change: Foo<A,B> {a, b} -> Foo<A> {a}
+// Validate: return value from main is correct.
+// Please note: This test works because no instances are created from Foo.
+
+class Foo<A> {
+  var a;
+}
+
+Future<void> main() async {
+  await hotReload();
+}
+
+/** DIFF **/
+/*
+ // Validate: return value from main is correct.
+ // Please note: This test works because no instances are created from Foo.
+ 
+-class Foo<A, B> {
++class Foo<A> {
+   var a;
+-  var b;
+ }
+ 
+ Future<void> main() async {
+*/

tests/hot_reload/mixin_changed/main.0.dart

@@ -8,6 +8,10 @@ import 'package:reload_test/reload_test_utils.dart';
 // Adapted from:
 // https://github.com/dart-lang/sdk/blob/1a486499bf73ee5b007abbe522b94869a1f36d02/runtime/vm/isolate_reload_test.cc#L917
 
+// B gets its implementation of 'func' from mixin2.
+// For the VM, the saved instance of B retains its old field value from mixin1.
+// For DDC, the field is updated to read from mixin2's.
+
 mixin Mixin1 {
   var field = 'mixin1';
   func() => 'mixin1';
@@ -21,10 +25,12 @@ Future<void> main() async {
   Expect.equals('mixin1', saved.func());
   await hotReload();
 
-  // The saved instance of B retains its old field value from mixin1,
-  // but it gets the new implementation of func from mixin2.
   var newer = B();
-  Expect.equals('mixin1', saved.field);
+  if (isVmRuntime) {
+    Expect.equals('mixin1', saved.field);
+  } else if (isDdcRuntime) {
+    Expect.equals('mixin2', saved.field);
+  }
   Expect.equals('mixin2', saved.func());
   Expect.equals('mixin2', newer.field);
   Expect.equals('mixin2', newer.func());