Elements. Fix for lazy loading methods.

Bug: https://buganizer.corp.google.com/issues/389978393
Change-Id: I9693b77e5e67b53b5be8c0eb4bc4aafb5f7a27cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404502
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -5695,8 +5695,7 @@ abstract class InstanceElementImpl2 extends ElementImpl2
   @override
   List<MethodElement> methods = [];
 
-  @override
-  List<MethodElementImpl2> methods2 = [];
+  final List<MethodElementImpl2> internal_methods2 = [];
 
   @override
   InstanceElement2 get baseElement => this;
@@ -5766,6 +5765,12 @@ abstract class InstanceElementImpl2 extends ElementImpl2
   @override
   Metadata get metadata2 => firstFragment.metadata2;
 
+  @override
+  List<MethodElementImpl2> get methods2 {
+    _readMembers();
+    return internal_methods2;
+  }
+
   @override
   String? get name3 => firstFragment.name;
 
@@ -6522,7 +6527,7 @@ abstract class InterfaceElementImpl2 extends InstanceElementImpl2
 
   @override
   List<ConstructorElement2> get constructors2 {
-    firstFragment.constructors; // TODO(scheglov): remove eventually
+    _readMembers();
     return constructors
         .map((constructor) =>
             (constructor.declaration as ConstructorElementImpl).element)

pkg/analyzer/lib/src/summary2/bundle_reader.dart

@@ -1379,7 +1379,7 @@ class LibraryReader {
         fragment.element = element;
       } else {
         var element = MethodElementImpl2(reference2, fragment.name2, fragment);
-        _currentInstanceElement.methods2.add(element);
+        _currentInstanceElement.internal_methods2.add(element);
       }
 
       var linkedData = MethodElementLinkedData(

pkg/analyzer/lib/src/summary2/element_builder.dart

@@ -1255,7 +1255,7 @@ class ElementBuilder extends ThrowingAstVisitor<void> {
             fragment.name2,
             fragment,
           );
-          enclosingBuilder.element.methods2.add(element);
+          enclosingBuilder.element.internal_methods2.add(element);
         }
       }
     }

pkg/analyzer/test/src/summary/elements/class_test.dart

@@ -18432,6 +18432,61 @@ library
 ''');
   }
 
+  test_class_lazy_constructors() async {
+    var library = await buildLibrary('''
+class A {
+  A.named();
+}
+''');
+
+    var constructors = library.getClass2('A')!.constructors2;
+    expect(constructors, hasLength(1));
+  }
+
+  test_class_lazy_fields() async {
+    var library = await buildLibrary('''
+class A {
+  int foo = 0;
+}
+''');
+
+    var fields = library.getClass2('A')!.fields2;
+    expect(fields, hasLength(1));
+  }
+
+  test_class_lazy_getters() async {
+    var library = await buildLibrary('''
+class A {
+  int foo = 0;
+}
+''');
+
+    var getters = library.getClass2('A')!.getters2;
+    expect(getters, hasLength(1));
+  }
+
+  test_class_lazy_methods() async {
+    var library = await buildLibrary('''
+class A {
+  void foo() {}
+}
+''');
+
+    var methods = library.getClass2('A')!.methods2;
+    expect(methods, hasLength(1));
+  }
+
+  test_class_lazy_setters() async {
+    var library = await buildLibrary('''
+class A {
+  int foo = 0;
+}
+''');
+
+    var setters = library.getClass2('A')!.setters2;
+    expect(setters, hasLength(1));
+  }
+
   test_class_method_abstract() async {
     var library = await buildLibrary('abstract class C { f(); }');
     checkElementText(library, r'''