[analysis_server] Fix URI/path comparisons for Windows in the Scheduler

We can't use `uri.path` to get a file path from a `file:///` URI because on Windows it will be incorrect. Instead, we should use `toFilePath()`... however, it's possible in future we'll have non-file URIs here (macros etc.), so it's better to compare URIs directly.

Fixes #59615

Change-Id: I9b4badb96edc9f7dae57b1fa399d0e4fef8bb86a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397620
Reviewed-by: Keerti Parthasarathy <[email protected]>
Reviewed-by: Jaime Wren <[email protected]>
Commit-Queue: Keerti Parthasarathy <[email protected]>

Author: DanTup

pkg/analysis_server/lib/src/lsp/handlers/commands/abstract_refactor.dart

@@ -178,6 +178,7 @@ abstract class AbstractRefactorCommandHandler extends SimpleEditCommandHandler
     }
 
     if (parameters['kind'] is! String ||
+        // TODO(dantup): We should migrate this to URIs.
         parameters['path'] is! String ||
         (parameters['docVersion'] is! int?) ||
         parameters['offset'] is! int ||

pkg/analysis_server/lib/src/server/message_scheduler.dart

@@ -383,18 +383,19 @@ final class MessageScheduler {
     if (params == null) {
       return;
     }
-    var uri = params.textDocument.uri;
+    var documentChangeUri = params.textDocument.uri;
 
-    String? getDocumentPath(List<lsp.LSPAny?> args) {
+    Uri? getRefactorUri(List<lsp.LSPAny?> args) {
       // TODO(keertip): extract method in AbstractRefactorCommandHandler
       // and use that instead.
       String? path;
       if (args.length == 6) {
         path = args[1] as String?;
       } else if (args.length == 1 && args[0] is Map<String, Object?>) {
-        path = (args.single as Map<String, Object?>).values.first as String;
+        path = (args.single as Map<String, Object?>)['path'] as String?;
       }
-      return path;
+
+      return path != null ? Uri.file(path) : null;
     }
 
     void checkAndCancelRefactor(LspMessage lspMessage) {
@@ -403,8 +404,8 @@ final class MessageScheduler {
       if (execParams != null &&
           execParams.command == Commands.performRefactor) {
         var args = execParams.arguments ?? [];
-        String? path = getDocumentPath(args);
-        if (path == uri.path) {
+        var refactorUri = getRefactorUri(args);
+        if (refactorUri == documentChangeUri) {
           lspMessage.cancellationToken?.cancel(
             code: lsp.ErrorCodes.ContentModified.toJson(),
           );
@@ -419,8 +420,8 @@ final class MessageScheduler {
       var request = lspMessage.message as lsp.RequestMessage;
       var renameParams = _getRenameParams(request);
       if (renameParams != null) {
-        var path = renameParams.textDocument.uri.path;
-        if (path == uri.path) {
+        var renameUri = renameParams.textDocument.uri;
+        if (renameUri == documentChangeUri) {
           lspMessage.cancellationToken?.cancel(
             code: lsp.ErrorCodes.ContentModified.toJson(),
           );