[analyzer] Remove Element2.location

The completion code was no longer using this (we use `ElementLocation2` directly in the completion handler now), and the navigation check was just to ensure we didn't include MultiplyDefinedElements in navigation results.

Change-Id: I8412ec60d3d56386a7ced3d78c3a7428313df5d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402101
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: DanTup

pkg/analysis_server/lib/src/services/completion/dart/dart_completion_suggestion.dart

@@ -4,12 +4,10 @@
 
 import 'package:analysis_server/src/protocol_server.dart'
     show CompletionSuggestion;
-import 'package:analyzer/dart/element/element2.dart';
 
 /// An extension of [CompletionSuggestion] that includes additional
 /// Dart-specific fields that are not part of the JSON protocol.
 class DartCompletionSuggestion extends CompletionSuggestion {
-  final ElementLocation? elementLocation;
   final List<Uri> requiredImports;
   final String? colorHex;
 
@@ -39,7 +37,6 @@ class DartCompletionSuggestion extends CompletionSuggestion {
     super.parameterType,
     super.libraryUri,
     super.isNotImported,
-    required this.elementLocation,
     this.requiredImports = const [],
     this.colorHex,
   });

pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart

@@ -152,7 +152,6 @@ class SuggestionBuilder {
         false,
         false,
         displayText: displayText,
-        elementLocation: null, // type.element is Null for FunctionType.
       ),
     );
   }
@@ -728,7 +727,6 @@ class SuggestionBuilder {
       parameterType: type,
       replacementLength: replacementLength,
       element: convertElement2(parameter),
-      elementLocation: parameter.location,
     );
 
     if (parameter is FieldFormalParameterElement2) {
@@ -850,7 +848,6 @@ class SuggestionBuilder {
       element.metadata2.hasDeprecated,
       false,
       displayText: displayText,
-      elementLocation: element.location,
       requiredImports: overrideImports.toList(),
     );
     suggestion.element = protocol.convertElement2(element);
@@ -928,7 +925,6 @@ class SuggestionBuilder {
         false,
         // Let the user know that we are going to insert a complete statement.
         displayText: displayText,
-        elementLocation: method.location,
       ),
       textToMatchOverride: 'setState',
     );
@@ -1522,9 +1518,7 @@ class SuggestionBuilder {
     ElementLocation? elementLocation;
     if (element is! LocalVariableElement2 ||
         (element is FormalParameterElement &&
-            element.enclosingElement2 != null)) {
-      elementLocation = element.location;
-    }
+            element.enclosingElement2 != null)) {}
 
     return _ElementCompletionData(
       isDeprecated: element.hasOrInheritsDeprecated,
@@ -1799,7 +1793,6 @@ class _CompletionSuggestionBuilderImpl implements CompletionSuggestionBuilder {
       defaultArgumentListTextRanges: element.defaultArgumentList?.ranges,
       libraryUri: libraryUriStr,
       isNotImported: isNotImported ? true : null,
-      elementLocation: element.elementLocation,
       requiredImports: requiredImports,
       colorHex: element.colorHex,
     );

pkg/analyzer/lib/dart/element/element2.dart

@@ -54,7 +54,6 @@ import 'package:analyzer/dart/element/element.dart'
         DirectiveUri,
         ElementAnnotation,
         ElementKind,
-        ElementLocation,
         LibraryLanguageVersion,
         NamespaceCombinator;
 import 'package:analyzer/dart/element/nullability_suffix.dart';
@@ -436,11 +435,6 @@ abstract class Element2 {
   /// in a single library.
   LibraryElement2? get library2;
 
-  /// The location of this element in the element model.
-  ///
-  /// The object can be used to locate this element at a later time.
-  ElementLocation? get location;
-
   /// The name to use for lookup in maps.
   ///
   /// It is usually the same as [name3], with a few special cases.

pkg/analyzer/lib/src/dart/element/element.dart

@@ -3337,11 +3337,6 @@ abstract class ElementImpl2 implements Element2 {
   @override
   bool get isPublic => !isPrivate;
 
-  @override
-  ElementLocation? get location {
-    return ElementLocationImpl.fromElement(this);
-  }
-
   @override
   String? get lookupName {
     return name3;
@@ -5576,9 +5571,6 @@ abstract class InstanceElementImpl2 extends ElementImpl2
   @override
   LibraryElement2 get library2 => firstFragment.library2!;
 
-  @override
-  ElementLocation? get location => firstFragment.location;
-
   @override
   List<ElementAnnotation> get metadata => firstFragment.metadata;
 
@@ -8700,9 +8692,6 @@ class MultiplyDefinedElementImpl2 extends ElementImpl2
   @override
   LibraryElement2 get library2 => libraryFragment.element;
 
-  @override
-  ElementLocation? get location => null;
-
   @override
   Element2 get nonSynthetic2 => this;
 

pkg/analyzer_plugin/lib/src/utilities/navigation/navigation_dart.dart

@@ -145,7 +145,7 @@ class _DartNavigationCollector {
     if (fragment.element == DynamicElementImpl.instance) {
       return;
     }
-    if (fragment.element.location == null) {
+    if (fragment.element is MultiplyDefinedElement2) {
       return;
     }