Elements. Add LibraryElement2.uri

We used it often enough, and the question "what is the URI of the library" makes sense.

Change-Id: I58baebd7b32154ae7a2f90770e4edcade8a49a63
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395680
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/services/completion/dart/override_helper.dart

@@ -36,7 +36,7 @@ class OverrideHelper {
     var interface = inheritanceManager.getInterface2(interfaceElement);
     var interfaceMap = interface.map2;
     var namesToOverride = _namesToOverride(
-      interfaceElement.library2.firstFragment.source.uri,
+      interfaceElement.library2.uri,
       interface,
     );
 

pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart

@@ -172,7 +172,7 @@ class ElementMatcher {
       for (var libraryImport in part.libraryImports2) {
         // TODO(brianwilkerson): Filter based on combinators to help avoid making
         //  invalid suggestions.
-        var uri = libraryImport.importedLibrary2?.firstFragment.source.uri;
+        var uri = libraryImport.importedLibrary2?.uri;
         if (uri != null) {
           // The [uri] is `null` if the literal string is not a valid URI.
           importedUris.add(uri);

pkg/analysis_server/lib/src/services/correction/fix/data_driven/rename_parameter.dart

@@ -142,7 +142,7 @@ extension on MethodDeclaration {
       var enclosingElement = element.enclosingElement2;
       if (enclosingElement is InterfaceElement2) {
         var name = Name(
-          enclosingElement.library2.firstFragment.source.uri,
+          enclosingElement.library2.uri,
           element.name3!,
         );
         return inheritanceManager.getInherited4(enclosingElement, name);

pkg/analysis_server/lib/src/services/refactoring/move_top_level_to_file.dart

@@ -215,7 +215,7 @@ class MoveTopLevelToFile extends RefactoringProducer {
         var hasShowCombinator =
             import.combinators.whereType<ShowElementCombinator>().isNotEmpty;
         builder.importLibrary(
-          library.firstFragment.source.uri,
+          library.uri,
           prefix: import.prefix2?.element.name3,
           showName: element.name3,
           useShow: hasShowCombinator,

pkg/analysis_server/test/services/refactoring/agnostic/change_method_signature_test.dart

@@ -131,7 +131,7 @@ class AbstractChangeMethodSignatureTest extends AbstractContextTest {
 
   String _referenceToString(Reference reference) {
     var selfLibrary = refactoringContext.resolvedLibraryResult.element2;
-    var selfUriStr = '${selfLibrary.firstFragment.source.uri}';
+    var selfUriStr = '${selfLibrary.uri}';
 
     var name = reference.name;
     if (name == selfUriStr) {

pkg/analysis_server/test/src/utilities/selection_coverage_test.dart

@@ -247,7 +247,7 @@ class SelectionCoverageTest {
           var overridden = inheritanceManager.getOverridden4(
             visitedNodeList.enclosingElement2 as InterfaceElement2,
             Name(
-              visitedNodeList.library2!.firstFragment.source.uri,
+              visitedNodeList.library2!.uri,
               visitedNodeList.name3!,
             ),
           );

pkg/analysis_server/tool/code_completion/flutter_metrics.dart

@@ -141,9 +141,7 @@ class FlutterDataCollector extends RecursiveAstVisitor<void> {
       var childWidget = element.enclosingElement2.name3!;
       var library = element.library2;
       if (library != null &&
-          !library.firstFragment.source.uri.toString().startsWith(
-            'package:flutter/',
-          )) {
+          !library.uri.toString().startsWith('package:flutter/')) {
         childWidget = 'user-defined';
       }
       data.recordWidgetCreation(childWidget, parentWidget);

pkg/analyzer/lib/dart/element/element2.dart

@@ -1510,6 +1510,11 @@ abstract class LibraryElement2 implements Element2, Annotatable {
 
   /// The [TypeSystem] that is used in this library.
   TypeSystem get typeSystem;
+
+  /// The canonical URI of the library.
+  ///
+  /// This is the same URI as `firstFragment.source.uri` returns.
+  Uri get uri;
 }
 
 /// An `export` directive within a library fragment.

pkg/analyzer/lib/src/dart/element/element.dart

@@ -6788,6 +6788,9 @@ class LibraryElementImpl extends ElementImpl
     ];
   }
 
+  @override
+  Uri get uri => firstFragment.source.uri;
+
   List<CompilationUnitElementImpl> get _partUnits {
     var result = <CompilationUnitElementImpl>[];
 

pkg/analyzer/lib/src/dart/element/inheritance_manager3.dart

@@ -1319,8 +1319,7 @@ class Name {
   }
 
   factory Name.forLibrary(LibraryElement2? library, String name) {
-    var uri = library?.firstFragment.source.uri;
-    return Name(uri, name);
+    return Name(library?.uri, name);
   }
 
   Name._internal(this.libraryUri, this.name, this.isPublic, this.hashCode);