Elements. Write 'hasNonFinalField' flag into text expectations.

I plan to compute it during linking, store into summary, and manifest.

Change-Id: Iae69629a02df9e700919a0f9a50143e213c122be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445804
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -228,43 +228,6 @@ class ClassElementImpl extends InterfaceElementImpl implements ClassElement {
     return constructors.any((c) => !c.isFactory && c.isConst);
   }
 
-  @override
-  @trackedDirectlyExpensive
-  bool get hasNonFinalField {
-    globalResultRequirements?.record_classElement_hasNonFinalField(
-      element: this,
-    );
-
-    var classesToVisit = <InterfaceElementImpl>[];
-    var visitedClasses = <InterfaceElementImpl>{};
-    classesToVisit.add(this);
-    while (classesToVisit.isNotEmpty) {
-      var currentElement = classesToVisit.removeAt(0);
-      if (visitedClasses.add(currentElement)) {
-        // check fields
-        for (var field in currentElement.fields) {
-          if (!field.isFinal &&
-              !field.isConst &&
-              !field.isStatic &&
-              !field.isSynthetic) {
-            return true;
-          }
-        }
-        // check mixins
-        for (var mixinType in currentElement.mixins) {
-          classesToVisit.add(mixinType.element);
-        }
-        // check super
-        var supertype = currentElement.supertype;
-        if (supertype != null) {
-          classesToVisit.add(supertype.element);
-        }
-      }
-    }
-    // not found
-    return false;
-  }
-
   @override
   @trackedIncludedInId
   bool get isAbstract {
@@ -4673,6 +4636,42 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
     ];
   }
 
+  @trackedDirectlyExpensive
+  bool get hasNonFinalField {
+    globalResultRequirements?.record_interfaceElement_hasNonFinalField(
+      element: this,
+    );
+
+    var classesToVisit = <InterfaceElementImpl>[];
+    var visitedClasses = <InterfaceElementImpl>{};
+    classesToVisit.add(this);
+    while (classesToVisit.isNotEmpty) {
+      var currentElement = classesToVisit.removeAt(0);
+      if (visitedClasses.add(currentElement)) {
+        // check fields
+        for (var field in currentElement.fields) {
+          if (!field.isFinal &&
+              !field.isConst &&
+              !field.isStatic &&
+              !field.isSynthetic) {
+            return true;
+          }
+        }
+        // check mixins
+        for (var mixinType in currentElement.mixins) {
+          classesToVisit.add(mixinType.element);
+        }
+        // check super
+        var supertype = currentElement.supertype;
+        if (supertype != null) {
+          classesToVisit.add(supertype.element);
+        }
+      }
+    }
+    // not found
+    return false;
+  }
+
   InheritanceManager3 get inheritanceManager {
     return library.session.inheritanceManager;
   }

pkg/analyzer/lib/src/fine/requirements.dart

@@ -799,12 +799,6 @@ class RequirementsManifest {
     // TODO(scheglov): implement.
   }
 
-  void record_classElement_hasNonFinalField({
-    required ClassElementImpl element,
-  }) {
-    // TODO(scheglov): implement.
-  }
-
   void record_fieldElement_getter({
     required FieldElementImpl element,
     String? name,
@@ -1071,6 +1065,12 @@ class RequirementsManifest {
     requirements.requestedConstructors[constructorName] = constructorId;
   }
 
+  void record_interfaceElement_hasNonFinalField({
+    required InterfaceElementImpl element,
+  }) {
+    // TODO(scheglov): implement.
+  }
+
   /// Record that all accessible extensions inside a [LibraryFragmentImpl]
   /// are requested, which means dependency on all extensions exported
   /// from [importedLibraries].

pkg/analyzer/test/src/summary/element_text.dart

@@ -987,6 +987,7 @@ class _Element2Writer extends _AbstractElementWriter {
           _sink.writeIf(e.isInterface, 'interface ');
           _sink.writeIf(e.isFinal, 'final ');
           _writeNotSimplyBounded(e);
+          _sink.writeIf(e.hasNonFinalField, 'hasNonFinalField ');
           _sink.writeIf(e.isMixinClass, 'mixin ');
           _sink.write('class ');
           _sink.writeIf(e.isMixinApplication, 'alias ');
@@ -1009,6 +1010,7 @@ class _Element2Writer extends _AbstractElementWriter {
         case MixinElementImpl():
           _sink.writeIf(e.isBase, 'base ');
           _writeNotSimplyBounded(e);
+          _sink.writeIf(e.hasNonFinalField, 'hasNonFinalField ');
           _sink.write('mixin ');
       }