[analyzer][cfe] Create 'getter-setter-error' feature flag

Part of #58578

Change-Id: I819d4b86761f60d59a8aa95a1dfba1c280499992
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396581
Reviewed-by: Michael Thomsen <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>

Author: chloestefantsova

pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart

@@ -106,6 +106,14 @@ enum ExperimentalFlag {
     experimentReleasedVersion: const Version(2, 14),
   ),
 
+  getterSetterError(
+    name: 'getter-setter-error',
+    isEnabledByDefault: false,
+    isExpired: false,
+    experimentEnabledVersion: defaultLanguageVersion,
+    experimentReleasedVersion: defaultLanguageVersion,
+  ),
+
   inferenceUpdate1(
     name: 'inference-update-1',
     isEnabledByDefault: true,

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -99,7 +99,7 @@ import 'package:meta/meta.dart';
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 423;
+  static const int DATA_VERSION = 424;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/dart/analysis/experiments.g.dart

@@ -29,6 +29,7 @@ final _knownFeatures = <String, ExperimentalFeature>{
   EnableString.enum_shorthands: ExperimentalFeatures.enum_shorthands,
   EnableString.extension_methods: ExperimentalFeatures.extension_methods,
   EnableString.generic_metadata: ExperimentalFeatures.generic_metadata,
+  EnableString.getter_setter_error: ExperimentalFeatures.getter_setter_error,
   EnableString.inference_update_1: ExperimentalFeatures.inference_update_1,
   EnableString.inference_update_2: ExperimentalFeatures.inference_update_2,
   EnableString.inference_update_3: ExperimentalFeatures.inference_update_3,
@@ -98,6 +99,9 @@ class EnableString {
   /// String to enable the experiment "generic-metadata"
   static const String generic_metadata = 'generic-metadata';
 
+  /// String to enable the experiment "getter-setter-error"
+  static const String getter_setter_error = 'getter-setter-error';
+
   /// String to enable the experiment "inference-update-1"
   static const String inference_update_1 = 'inference-update-1';
 
@@ -298,8 +302,19 @@ class ExperimentalFeatures {
     releaseVersion: Version.parse('2.14.0'),
   );
 
-  static final inference_update_1 = ExperimentalFeature(
+  static final getter_setter_error = ExperimentalFeature(
     index: 12,
+    enableString: EnableString.getter_setter_error,
+    isEnabledByDefault: IsEnabledByDefault.getter_setter_error,
+    isExpired: IsExpired.getter_setter_error,
+    documentation:
+        'Stop reporting errors about mismatching types in a getter/setter pair.',
+    experimentalReleaseVersion: null,
+    releaseVersion: null,
+  );
+
+  static final inference_update_1 = ExperimentalFeature(
+    index: 13,
     enableString: EnableString.inference_update_1,
     isEnabledByDefault: IsEnabledByDefault.inference_update_1,
     isExpired: IsExpired.inference_update_1,
@@ -310,7 +325,7 @@ class ExperimentalFeatures {
   );
 
   static final inference_update_2 = ExperimentalFeature(
-    index: 13,
+    index: 14,
     enableString: EnableString.inference_update_2,
     isEnabledByDefault: IsEnabledByDefault.inference_update_2,
     isExpired: IsExpired.inference_update_2,
@@ -320,7 +335,7 @@ class ExperimentalFeatures {
   );
 
   static final inference_update_3 = ExperimentalFeature(
-    index: 14,
+    index: 15,
     enableString: EnableString.inference_update_3,
     isEnabledByDefault: IsEnabledByDefault.inference_update_3,
     isExpired: IsExpired.inference_update_3,
@@ -331,7 +346,7 @@ class ExperimentalFeatures {
   );
 
   static final inference_update_4 = ExperimentalFeature(
-    index: 15,
+    index: 16,
     enableString: EnableString.inference_update_4,
     isEnabledByDefault: IsEnabledByDefault.inference_update_4,
     isExpired: IsExpired.inference_update_4,
@@ -341,7 +356,7 @@ class ExperimentalFeatures {
   );
 
   static final inference_using_bounds = ExperimentalFeature(
-    index: 16,
+    index: 17,
     enableString: EnableString.inference_using_bounds,
     isEnabledByDefault: IsEnabledByDefault.inference_using_bounds,
     isExpired: IsExpired.inference_using_bounds,
@@ -352,7 +367,7 @@ class ExperimentalFeatures {
   );
 
   static final inline_class = ExperimentalFeature(
-    index: 17,
+    index: 18,
     enableString: EnableString.inline_class,
     isEnabledByDefault: IsEnabledByDefault.inline_class,
     isExpired: IsExpired.inline_class,
@@ -362,7 +377,7 @@ class ExperimentalFeatures {
   );
 
   static final macros = ExperimentalFeature(
-    index: 18,
+    index: 19,
     enableString: EnableString.macros,
     isEnabledByDefault: IsEnabledByDefault.macros,
     isExpired: IsExpired.macros,
@@ -372,7 +387,7 @@ class ExperimentalFeatures {
   );
 
   static final named_arguments_anywhere = ExperimentalFeature(
-    index: 19,
+    index: 20,
     enableString: EnableString.named_arguments_anywhere,
     isEnabledByDefault: IsEnabledByDefault.named_arguments_anywhere,
     isExpired: IsExpired.named_arguments_anywhere,
@@ -382,7 +397,7 @@ class ExperimentalFeatures {
   );
 
   static final native_assets = ExperimentalFeature(
-    index: 20,
+    index: 21,
     enableString: EnableString.native_assets,
     isEnabledByDefault: IsEnabledByDefault.native_assets,
     isExpired: IsExpired.native_assets,
@@ -392,7 +407,7 @@ class ExperimentalFeatures {
   );
 
   static final non_nullable = ExperimentalFeature(
-    index: 21,
+    index: 22,
     enableString: EnableString.non_nullable,
     isEnabledByDefault: IsEnabledByDefault.non_nullable,
     isExpired: IsExpired.non_nullable,
@@ -402,7 +417,7 @@ class ExperimentalFeatures {
   );
 
   static final nonfunction_type_aliases = ExperimentalFeature(
-    index: 22,
+    index: 23,
     enableString: EnableString.nonfunction_type_aliases,
     isEnabledByDefault: IsEnabledByDefault.nonfunction_type_aliases,
     isExpired: IsExpired.nonfunction_type_aliases,
@@ -412,7 +427,7 @@ class ExperimentalFeatures {
   );
 
   static final null_aware_elements = ExperimentalFeature(
-    index: 23,
+    index: 24,
     enableString: EnableString.null_aware_elements,
     isEnabledByDefault: IsEnabledByDefault.null_aware_elements,
     isExpired: IsExpired.null_aware_elements,
@@ -422,7 +437,7 @@ class ExperimentalFeatures {
   );
 
   static final patterns = ExperimentalFeature(
-    index: 24,
+    index: 25,
     enableString: EnableString.patterns,
     isEnabledByDefault: IsEnabledByDefault.patterns,
     isExpired: IsExpired.patterns,
@@ -432,7 +447,7 @@ class ExperimentalFeatures {
   );
 
   static final record_use = ExperimentalFeature(
-    index: 25,
+    index: 26,
     enableString: EnableString.record_use,
     isEnabledByDefault: IsEnabledByDefault.record_use,
     isExpired: IsExpired.record_use,
@@ -442,7 +457,7 @@ class ExperimentalFeatures {
   );
 
   static final records = ExperimentalFeature(
-    index: 26,
+    index: 27,
     enableString: EnableString.records,
     isEnabledByDefault: IsEnabledByDefault.records,
     isExpired: IsExpired.records,
@@ -452,7 +467,7 @@ class ExperimentalFeatures {
   );
 
   static final sealed_class = ExperimentalFeature(
-    index: 27,
+    index: 28,
     enableString: EnableString.sealed_class,
     isEnabledByDefault: IsEnabledByDefault.sealed_class,
     isExpired: IsExpired.sealed_class,
@@ -462,7 +477,7 @@ class ExperimentalFeatures {
   );
 
   static final set_literals = ExperimentalFeature(
-    index: 28,
+    index: 29,
     enableString: EnableString.set_literals,
     isEnabledByDefault: IsEnabledByDefault.set_literals,
     isExpired: IsExpired.set_literals,
@@ -472,7 +487,7 @@ class ExperimentalFeatures {
   );
 
   static final spread_collections = ExperimentalFeature(
-    index: 29,
+    index: 30,
     enableString: EnableString.spread_collections,
     isEnabledByDefault: IsEnabledByDefault.spread_collections,
     isExpired: IsExpired.spread_collections,
@@ -482,7 +497,7 @@ class ExperimentalFeatures {
   );
 
   static final super_parameters = ExperimentalFeature(
-    index: 30,
+    index: 31,
     enableString: EnableString.super_parameters,
     isEnabledByDefault: IsEnabledByDefault.super_parameters,
     isExpired: IsExpired.super_parameters,
@@ -492,7 +507,7 @@ class ExperimentalFeatures {
   );
 
   static final test_experiment = ExperimentalFeature(
-    index: 31,
+    index: 32,
     enableString: EnableString.test_experiment,
     isEnabledByDefault: IsEnabledByDefault.test_experiment,
     isExpired: IsExpired.test_experiment,
@@ -503,7 +518,7 @@ class ExperimentalFeatures {
   );
 
   static final triple_shift = ExperimentalFeature(
-    index: 32,
+    index: 33,
     enableString: EnableString.triple_shift,
     isEnabledByDefault: IsEnabledByDefault.triple_shift,
     isExpired: IsExpired.triple_shift,
@@ -513,7 +528,7 @@ class ExperimentalFeatures {
   );
 
   static final unnamed_libraries = ExperimentalFeature(
-    index: 33,
+    index: 34,
     enableString: EnableString.unnamed_libraries,
     isEnabledByDefault: IsEnabledByDefault.unnamed_libraries,
     isExpired: IsExpired.unnamed_libraries,
@@ -523,7 +538,7 @@ class ExperimentalFeatures {
   );
 
   static final unquoted_imports = ExperimentalFeature(
-    index: 34,
+    index: 35,
     enableString: EnableString.unquoted_imports,
     isEnabledByDefault: IsEnabledByDefault.unquoted_imports,
     isExpired: IsExpired.unquoted_imports,
@@ -533,7 +548,7 @@ class ExperimentalFeatures {
   );
 
   static final variance = ExperimentalFeature(
-    index: 35,
+    index: 36,
     enableString: EnableString.variance,
     isEnabledByDefault: IsEnabledByDefault.variance,
     isExpired: IsExpired.variance,
@@ -543,7 +558,7 @@ class ExperimentalFeatures {
   );
 
   static final wildcard_variables = ExperimentalFeature(
-    index: 36,
+    index: 37,
     enableString: EnableString.wildcard_variables,
     isEnabledByDefault: IsEnabledByDefault.wildcard_variables,
     isExpired: IsExpired.wildcard_variables,
@@ -593,6 +608,9 @@ class IsEnabledByDefault {
   /// Default state of the experiment "generic-metadata"
   static const bool generic_metadata = true;
 
+  /// Default state of the experiment "getter-setter-error"
+  static const bool getter_setter_error = false;
+
   /// Default state of the experiment "inference-update-1"
   static const bool inference_update_1 = true;
 
@@ -709,6 +727,9 @@ class IsExpired {
   /// Expiration status of the experiment "generic-metadata"
   static const bool generic_metadata = true;
 
+  /// Expiration status of the experiment "getter-setter-error"
+  static const bool getter_setter_error = false;
+
   /// Expiration status of the experiment "inference-update-1"
   static const bool inference_update_1 = true;
 
@@ -826,6 +847,10 @@ mixin _CurrentState {
   /// Current state for the flag "generic-metadata"
   bool get generic_metadata => isEnabled(ExperimentalFeatures.generic_metadata);
 
+  /// Current state for the flag "getter-setter-error"
+  bool get getter_setter_error =>
+      isEnabled(ExperimentalFeatures.getter_setter_error);
+
   /// Current state for the flag "inference-update-1"
   bool get inference_update_1 =>
       isEnabled(ExperimentalFeatures.inference_update_1);

pkg/front_end/lib/src/api_prototype/experimental_flags_generated.dart

@@ -169,6 +169,15 @@ class ExperimentalFlag {
     experimentReleasedVersion: const Version(2, 14),
   );
 
+  static const ExperimentalFlag getterSetterError = const ExperimentalFlag(
+    name: 'getter-setter-error',
+    isEnabledByDefault: false,
+    isExpired: false,
+    enabledVersion: defaultLanguageVersion,
+    experimentEnabledVersion: defaultLanguageVersion,
+    experimentReleasedVersion: defaultLanguageVersion,
+  );
+
   static const ExperimentalFlag inferenceUpdate1 = const ExperimentalFlag(
     name: 'inference-update-1',
     isEnabledByDefault: true,
@@ -529,6 +538,12 @@ class GlobalFeatures {
         ExperimentalFlag.genericMetadata,
       );
 
+  GlobalFeature? _getterSetterError;
+  GlobalFeature get getterSetterError =>
+      _getterSetterError ??= _computeGlobalFeature(
+        ExperimentalFlag.getterSetterError,
+      );
+
   GlobalFeature? _inferenceUpdate1;
   GlobalFeature get inferenceUpdate1 =>
       _inferenceUpdate1 ??= _computeGlobalFeature(
@@ -772,6 +787,14 @@ class LibraryFeatures {
         libraryVersion,
       );
 
+  LibraryFeature? _getterSetterError;
+  LibraryFeature get getterSetterError =>
+      _getterSetterError ??= globalFeatures._computeLibraryFeature(
+        ExperimentalFlag.getterSetterError,
+        canonicalUri,
+        libraryVersion,
+      );
+
   LibraryFeature? _inferenceUpdate1;
   LibraryFeature get inferenceUpdate1 =>
       _inferenceUpdate1 ??= globalFeatures._computeLibraryFeature(
@@ -1001,6 +1024,8 @@ class LibraryFeatures {
         return extensionMethods;
       case shared.ExperimentalFlag.genericMetadata:
         return genericMetadata;
+      case shared.ExperimentalFlag.getterSetterError:
+        return getterSetterError;
       case shared.ExperimentalFlag.inferenceUpdate1:
         return inferenceUpdate1;
       case shared.ExperimentalFlag.inferenceUpdate2:
@@ -1083,6 +1108,8 @@ ExperimentalFlag? parseExperimentalFlag(String flag) {
       return ExperimentalFlag.extensionMethods;
     case "generic-metadata":
       return ExperimentalFlag.genericMetadata;
+    case "getter-setter-error":
+      return ExperimentalFlag.getterSetterError;
     case "inference-update-1":
       return ExperimentalFlag.inferenceUpdate1;
     case "inference-update-2":
@@ -1164,6 +1191,8 @@ final Map<ExperimentalFlag, bool> defaultExperimentalFlags = {
       ExperimentalFlag.extensionMethods.isEnabledByDefault,
   ExperimentalFlag.genericMetadata:
       ExperimentalFlag.genericMetadata.isEnabledByDefault,
+  ExperimentalFlag.getterSetterError:
+      ExperimentalFlag.getterSetterError.isEnabledByDefault,
   ExperimentalFlag.inferenceUpdate1:
       ExperimentalFlag.inferenceUpdate1.isEnabledByDefault,
   ExperimentalFlag.inferenceUpdate2:
@@ -1229,6 +1258,7 @@ const Map<shared.ExperimentalFlag, ExperimentalFlag> sharedExperimentalFlags = {
   shared.ExperimentalFlag.enumShorthands: ExperimentalFlag.enumShorthands,
   shared.ExperimentalFlag.extensionMethods: ExperimentalFlag.extensionMethods,
   shared.ExperimentalFlag.genericMetadata: ExperimentalFlag.genericMetadata,
+  shared.ExperimentalFlag.getterSetterError: ExperimentalFlag.getterSetterError,
   shared.ExperimentalFlag.inferenceUpdate1: ExperimentalFlag.inferenceUpdate1,
   shared.ExperimentalFlag.inferenceUpdate2: ExperimentalFlag.inferenceUpdate2,
   shared.ExperimentalFlag.inferenceUpdate3: ExperimentalFlag.inferenceUpdate3,

tools/experimental_features.yaml

@@ -148,6 +148,9 @@ features:
   enum-shorthands:
     help: "Shorter dot syntax for enum values."
 
+  getter-setter-error:
+    help: "Stop reporting errors about mismatching types in a getter/setter pair."
+
 # Experiment flag only used for testing.
   test-experiment:
     help: >-