[vm] Don't feed the simulator's registers into ProfilerNativeStackWalker.

Default the simulators to --no-profile-vm same as the non-simulators.

TEST=vm/dart/stream_timeline_to_test
Bug: #61811
Change-Id: I26cf956e240ffa542f3d52345e680404bc2d2021
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/457840
Commit-Queue: Ryan Macnak <[email protected]>
Reviewed-by: Alexander Aprelev <[email protected]>

Author: rmacnak-google

runtime/tests/vm/dart/gc/splay_test.dart

@@ -35,7 +35,7 @@
 // VMOptions=--profiler --no_load_cse --no_dead_store_elimination
 // VMOptions=--profiler --test_il_serialization
 // VMOptions=--profiler --dontneed_on_sweep
-// VMOptions=--profiler --sim_buffer_memory
+// VMOptions=--sim_buffer_memory
 
 import "splay_common.dart";
 

runtime/vm/profiler.cc

@@ -46,11 +46,7 @@ DEFINE_FLAG(int,
             max_profile_depth,
             Sample::kPCArraySizeInWords* kMaxSamplesPerTick,
             "Maximum number stack frames walked. Minimum 2. Maximum 255.");
-#if defined(DART_INCLUDE_SIMULATOR)
-DEFINE_FLAG(bool, profile_vm, true, "Always collect native stack traces.");
-#else
 DEFINE_FLAG(bool, profile_vm, false, "Always collect native stack traces.");
-#endif
 DEFINE_FLAG(bool,
             profile_vm_allocation,
             false,
@@ -1478,7 +1474,7 @@ void Profiler::SampleThread(Thread* thread,
   if (in_dart_code) {
     // If we're in Dart code, use the Dart stack pointer.
 #if defined(DART_INCLUDE_SIMULATOR)
-    if (FLAG_use_simulator) {
+    if (FLAG_use_simulator && !FLAG_profile_vm) {
       Simulator* simulator = isolate->simulator();
       sp = simulator->get_register(SPREG);
       fp = simulator->get_register(FPREG);