Skip to content

Commit 3b7cd31

Browse files
jensjohaCommit Queue
authored andcommitted
[CFE] Fix bug in benchmarker where it used the last comparison (and not the combined) to signal if anything was significant
It only resulted in it saying "no change" after it had printed changes, but still. Change-Id: I198265fe89bdb473eff3a2725e2a17323f560fbd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449800 Reviewed-by: Johnni Winther <[email protected]> Commit-Queue: Jens Johansen <[email protected]>
1 parent e01fad7 commit 3b7cd31

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/front_end/tool/benchmarker.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ bool _compare(List<Map<String, num>> from, List<Map<String, num>> to) {
236236
}
237237
}
238238
if (fromForCaption.isEmpty || toForCaption.isEmpty) continue;
239-
somethingWasSignificant = _compareSingle(
239+
somethingWasSignificant |= _compareSingle(
240240
toForCaption,
241241
fromForCaption,
242242
caption,

0 commit comments

Comments
 (0)