Skip to content

Commit 3c26fcf

Browse files
sstricklCommit Queue
authored andcommitted
[vm] Delimit and escape string constants when disassembling to stdout.
TEST=ci (only affects output used for debugging the VM) Change-Id: If9732db5695a19943ecf88362deb96a93a2bd843 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/454000 Reviewed-by: Ryan Macnak <[email protected]> Commit-Queue: Tess Strickland <[email protected]>
1 parent dabcb98 commit 3c26fcf

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

runtime/vm/compiler/assembler/disassembler.cc

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,12 @@ void DisassembleToStdout::ConsumeInstruction(char* hex_buffer,
5050
}
5151
THR_Print("%s", human_buffer);
5252
if (object != nullptr) {
53-
THR_Print(" %s", object->ToCString());
53+
if (object->IsString()) {
54+
*object = String::EscapeSpecialCharacters(String::Cast(*object));
55+
THR_Print(" \"%s\"", object->ToCString());
56+
} else {
57+
THR_Print(" %s", object->ToCString());
58+
}
5459
}
5560
THR_Print("\n");
5661
}

0 commit comments

Comments
 (0)