[lints] address diagnostics related to strict_top_level_inference

Change-Id: I228058202855900f0adba73c1ab04d35180a6e5d
Tested: this is an analyzer diagnostic only change
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414900
Reviewed-by: Nate Bosch <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Nate Biggs <[email protected]>
Reviewed-by: Ben Konyi <[email protected]>

Author: devoncarew

DEPS

@@ -129,7 +129,7 @@ vars = {
   ### /third_party/pkg dependencies
   # 'tools/rev_sdk_deps.dart' will rev pkg dependencies to their latest; put an
   # EOL comment after a dependency to instead pin at the current revision.
-  "core_rev": "15c7fe9958b95998ba2f5a4ad1beab66b9d815fb",
+  "core_rev": "9f4321008457d16674c0faabfe49327a2bb0cd29",
   "dartdoc_rev": "c41b86b98ca935ec3c29cdb04cb190df30afb242",
   "ecosystem_rev": "a3cc42d999acc95af96a48d155d7749d92cecb92",
   "flute_rev": "e4ea0459a7debae5e9592c85141707b01fac86c9",

pkg/analysis_server/tool/benchmark_tools/language_server_benchmark.dart

@@ -130,7 +130,7 @@ abstract class DartLanguageServerBenchmark {
     }
   }
 
-  void _checkLongRunningRequests(timer) {
+  void _checkLongRunningRequests(Timer timer) {
     bool reportedSomething = false;
     for (MapEntry<int, OutstandingRequest> waitingFor
         in _outstandingRequestsWithId.entries) {

pkg/analyzer/analysis_options.yaml

@@ -35,6 +35,9 @@ analyzer:
     # About 30 violations of this in lib/.
     provide_deprecation_message: ignore
 
+    # ~3,500 violations in test/.
+    strict_top_level_inference: ignore
+
     # Ignoring this for all developers means developers don't need to ignore
     # TODOs in their IDE settings.
     todo: ignore

pkg/analyzer_plugin/test/integration/support/integration_tests.dart

@@ -38,7 +38,7 @@ Matcher isMapOf(Matcher keyMatcher, Matcher valueMatcher) =>
 Matcher isOneOf(List<Matcher> choiceMatchers) => _OneOf(choiceMatchers);
 
 /// Assert that [actual] matches [matcher].
-void outOfTestExpect(actual, Matcher matcher,
+void outOfTestExpect(dynamic actual, Matcher matcher,
     {String? reason, skip, bool verbose = false}) {
   var matchState = {};
   try {
@@ -49,8 +49,8 @@ void outOfTestExpect(actual, Matcher matcher,
   fail(_defaultFailFormatter(actual, matcher, reason, matchState, verbose));
 }
 
-String _defaultFailFormatter(
-    actual, Matcher matcher, String? reason, Map matchState, bool verbose) {
+String _defaultFailFormatter(dynamic actual, Matcher matcher, String? reason,
+    Map matchState, bool verbose) {
   var description = StringDescription();
   description.add('Expected: ').addDescriptionOf(matcher).add('\n');
   description.add('  Actual: ').addDescriptionOf(actual).add('\n');
@@ -306,7 +306,7 @@ class MatchesJsonObject extends _RecursiveMatcher {
       description.add(this.description);
 
   @override
-  void populateMismatches(item, List<MismatchDescriber> mismatches) {
+  void populateMismatches(dynamic item, List<MismatchDescriber> mismatches) {
     if (item is! Map) {
       mismatches.add(simpleDescription('is not a map'));
       return;
@@ -344,7 +344,7 @@ class MatchesJsonObject extends _RecursiveMatcher {
   /// Check the type of a field called [key], having value [value], using
   /// [valueMatcher]. If it doesn't match, record a closure in [mismatches]
   /// which can describe the mismatch.
-  void _checkField(String key, value, Matcher valueMatcher,
+  void _checkField(String key, Object? value, Matcher valueMatcher,
       List<MismatchDescriber> mismatches) {
     checkSubstructure(
         value,
@@ -757,7 +757,7 @@ abstract class _RecursiveMatcher extends Matcher {
   /// the mismatch. [describeSubstructure] is used to describe which
   /// substructure did not match.
   void checkSubstructure(
-      item,
+      Object? item,
       Matcher matcher,
       List<MismatchDescriber> mismatches,
       Description Function(Description description) describeSubstructure) {
@@ -806,7 +806,7 @@ abstract class _RecursiveMatcher extends Matcher {
   }
 
   @override
-  bool matches(item, Map matchState) {
+  bool matches(dynamic item, Map matchState) {
     var mismatches = <MismatchDescriber>[];
     populateMismatches(item, mismatches);
     if (mismatches.isEmpty) {
@@ -819,7 +819,7 @@ abstract class _RecursiveMatcher extends Matcher {
 
   /// Populate [mismatches] with descriptions of all the ways in which [item]
   /// does not match.
-  void populateMismatches(item, List<MismatchDescriber> mismatches);
+  void populateMismatches(dynamic item, List<MismatchDescriber> mismatches);
 
   /// Create a [MismatchDescriber] describing a mismatch with a simple string.
   MismatchDescriber simpleDescription(String description) =>

pkg/build_integration/test/file_system/multi_root_test.dart

@@ -14,7 +14,7 @@ import 'package:test/test.dart';
 
 var root = Uri.parse('org-dartlang-test:///');
 
-main() {
+void main() {
   late MemoryFileSystem memoryFs;
   late MultiRootFileSystem multiRoot;
 

pkg/build_integration/test/file_system/single_root_test.dart

@@ -9,7 +9,7 @@ import 'package:front_end/src/api_unstable/build_integration.dart';
 import 'package:front_end/src/api_prototype/memory_file_system.dart';
 import 'package:test/test.dart';
 
-main() {
+void main() {
   var root = Uri.parse('org-dartlang-test:///');
   var fileSystem = SingleRootFileSystem(
       'single-root', root.resolve('A/B'), MemoryFileSystem(root));

pkg/dart2bytecode/analysis_options.yaml

@@ -3,3 +3,8 @@
 # BSD-style license that can be found in the LICENSE file.
 
 include: package:lints/core.yaml
+
+analyzer:
+  errors:
+    # ~75 violations in test/.
+    strict_top_level_inference: ignore

pkg/dart2bytecode/bin/dump_bytecode.dart

@@ -13,7 +13,7 @@ Usage: dump_bytecode input.bytecode
 Dumps bytecode file.
 ''';
 
-main(List<String> arguments) async {
+void main(List<String> arguments) async {
   if (arguments.length != 1) {
     print(_usage);
     exit(1);

pkg/dart2bytecode/lib/bytecode_generator.dart

@@ -3999,15 +3999,15 @@ class BytecodeGenerator extends RecursiveVisitor {
     return locals.tempIndexInFrame(node, tempIndex: 1);
   }
 
-  _saveContextForTryBlock(TreeNode node) {
+  void _saveContextForTryBlock(TreeNode node) {
     if (!locals.hasContextVar) {
       return;
     }
     asm.emitPush(locals.contextVarIndexInFrame);
     asm.emitPopLocal(_savedContextVar(node));
   }
 
-  _restoreContextForTryBlock(TreeNode node) {
+  void _restoreContextForTryBlock(TreeNode node) {
     if (!locals.hasContextVar) {
       return;
     }

pkg/dart2bytecode/lib/disassembler.dart

@@ -124,7 +124,7 @@ class BytecodeDisassembler {
     }
   }
 
-  _decodeUint32At(int pos) =>
+  int _decodeUint32At(int pos) =>
       _bytecode[pos] +
       (_bytecode[pos + 1] << 8) +
       (_bytecode[pos + 2] << 16) +