Make inline-method not inline references in combinators

An earlier CL fixed a bug where an inline-method refactor could be
initiated at a reference to a top-level function in an import
combinator.

This CL makes the corresponding change to prevent such references from
being changed when the refactor is initiated at the declaration site.

Change-Id: I769ff83ce946d971780474a9908e1ac63bd1e02d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434180
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: bwilkerson

pkg/analysis_server/lib/src/services/refactoring/legacy/inline_method.dart

@@ -702,6 +702,11 @@ class _ReferenceProcessor {
     if (!_shouldProcess()) {
       return;
     }
+    // References in a combinator list can't be inlined, but not doing so isn't
+    // an error.
+    if (nodeParent is Combinator) {
+      return;
+    }
     // If the element being inlined is async, ensure that the function
     // body that encloses the method is also async.
     if (ref._methodElement!.firstFragment.isAsynchronous) {

pkg/analysis_server/test/services/refactoring/legacy/inline_method_test.dart

@@ -243,7 +243,32 @@ void f() {
     );
   }
 
-  Future<void> test_bad_inShowCombinator() async {
+  Future<void> test_bad_inShowCombinator_atDeclaration() async {
+    var referencingFilePath = '$testPackageLibPath/a.dart';
+    newFile(referencingFilePath, '''
+import 'test.dart' show f;
+
+void g() {
+  f();
+}
+''');
+    await indexTestUnit(r'''
+void f() {
+  print(42);
+}
+''');
+    _createRefactoring('f(');
+    await _assertSuccessfulRefactoring('');
+    assertFileChangeResult(referencingFilePath, '''
+import 'test.dart' show f;
+
+void g() {
+  print(42);
+}
+''');
+  }
+
+  Future<void> test_bad_inShowCombinator_atShowCombinator() async {
     newFile('$testPackageLibPath/a.dart', '''
 void f() {
   print(42);