CQ. De-duplicate analysis of annotations in DeprecatedMemberUseFromSamePackage.

Change-Id: I6a3e1dcfb4dd61f794bf36bf2e87c42e4c1b279d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398940
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>

Author: scheglov

pkg/linter/lib/src/rules/deprecated_member_use_from_same_package.dart

@@ -107,26 +107,16 @@ class _RecursiveVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitClassDeclaration(ClassDeclaration node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedDeclaration(node, () {
       super.visitClassDeclaration(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
   void visitClassTypeAlias(ClassTypeAlias node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedDeclaration(node, () {
       super.visitClassTypeAlias(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
@@ -142,14 +132,9 @@ class _RecursiveVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitConstructorDeclaration(ConstructorDeclaration node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedDeclaration(node, () {
       super.visitConstructorDeclaration(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
@@ -160,26 +145,16 @@ class _RecursiveVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitDefaultFormalParameter(DefaultFormalParameter node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedFormalParameter(node, () {
       super.visitDefaultFormalParameter(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
   void visitEnumDeclaration(EnumDeclaration node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedDeclaration(node, () {
       super.visitEnumDeclaration(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
@@ -190,14 +165,9 @@ class _RecursiveVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitExtensionDeclaration(ExtensionDeclaration node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedDeclaration(node, () {
       super.visitExtensionDeclaration(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
@@ -208,14 +178,9 @@ class _RecursiveVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitExtensionTypeDeclaration(ExtensionTypeDeclaration node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedDeclaration(node, () {
       super.visitExtensionTypeDeclaration(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
@@ -231,26 +196,16 @@ class _RecursiveVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitFieldFormalParameter(FieldFormalParameter node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedFormalParameter(node, () {
       super.visitFieldFormalParameter(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
   void visitFunctionDeclaration(FunctionDeclaration node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedDeclaration(node, () {
       super.visitFunctionDeclaration(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
@@ -261,30 +216,16 @@ class _RecursiveVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitFunctionTypeAlias(FunctionTypeAlias node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedDeclaration(node, () {
       super.visitFunctionTypeAlias(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
   void visitGenericTypeAlias(GenericTypeAlias node) {
-    var element = node.declaredFragment?.element;
-    var hasDeprecated = (element is Annotatable)
-        ? (element! as Annotatable).metadata2.hasDeprecated
-        : false;
-
-    _deprecatedVerifier.pushInDeprecatedValue(hasDeprecated);
-
-    try {
+    _withDeprecatedDeclaration(node, () {
       super.visitGenericTypeAlias(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
@@ -307,14 +248,9 @@ class _RecursiveVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitMethodDeclaration(MethodDeclaration node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedDeclaration(node, () {
       super.visitMethodDeclaration(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
@@ -325,14 +261,9 @@ class _RecursiveVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitMixinDeclaration(MixinDeclaration node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedDeclaration(node, () {
       super.visitMixinDeclaration(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
@@ -362,14 +293,9 @@ class _RecursiveVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitSimpleFormalParameter(SimpleFormalParameter node) {
-    _deprecatedVerifier.pushInDeprecatedValue(
-        node.declaredFragment?.element.metadata2.hasDeprecated ?? false);
-
-    try {
+    _withDeprecatedFormalParameter(node, () {
       super.visitSimpleFormalParameter(node);
-    } finally {
-      _deprecatedVerifier.popInDeprecated();
-    }
+    });
   }
 
   @override
@@ -394,6 +320,37 @@ class _RecursiveVisitor extends RecursiveAstVisitor<void> {
       _deprecatedVerifier.popInDeprecated();
     }
   }
+
+  void _withDeprecatedDeclaration<T extends Declaration>(
+    T node,
+    void Function() recurse,
+  ) {
+    _withDeprecatedFragment(node.declaredFragment, recurse);
+  }
+
+  void _withDeprecatedFormalParameter<T extends FormalParameter>(
+    T node,
+    void Function() recurse,
+  ) {
+    _withDeprecatedFragment(node.declaredFragment, recurse);
+  }
+
+  void _withDeprecatedFragment(
+    Fragment? fragment,
+    void Function() recurse,
+  ) {
+    var isDeprecated = false;
+    if (fragment?.element case Annotatable annotatable) {
+      isDeprecated = annotatable.metadata2.hasDeprecated;
+    }
+
+    _deprecatedVerifier.pushInDeprecatedValue(isDeprecated);
+    try {
+      recurse();
+    } finally {
+      _deprecatedVerifier.popInDeprecated();
+    }
+  }
 }
 
 /// This [SimpleAstVisitor] visits the [CompilationUnit], and forwards the