[VM/dartdev] Escape VM options when running dartdev on Windows

jason-simmons · Commit Queue · commit 3e36557e3b0f · 2025-08-14T09:50:29.000-07:00
VM options may include flags like --packages that include file paths. TEST=ci Bug: flutter/flutter#173716 Change-Id: I0d88f5383a7d2daf27568ccfb5c8f447965592cd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445113 Commit-Queue: Jason Simmons <jsimmons@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
diff --git a/runtime/bin/dartdev.cc b/runtime/bin/dartdev.cc
@@ -658,7 +658,11 @@ class DartDev {
     // Copy in VM options if any.
     // Copy in any vm options that need to be passed to the execed process.
     for (intptr_t i = 0; i < num_vm_options; ++i) {
+#if defined(DART_HOST_OS_WINDOWS)
+      argv_[i + idx] = StringUtilsWin::ArgumentEscape(vm_options[i]);
+#else
       argv_[i + idx] = Utils::StrDup(vm_options[i]);
+#endif
     }
     idx += num_vm_options;
     {

Original file line number	Diff line number	Diff line change
`@@ -658,7 +658,11 @@ class DartDev {`
`658`	`658`	`// Copy in VM options if any.`
`659`	`659`	`// Copy in any vm options that need to be passed to the execed process.`
`660`	`660`	`for (intptr_t i = 0; i < num_vm_options; ++i) {`
	`661`	`+#if defined(DART_HOST_OS_WINDOWS)`
	`662`	`+ argv_[i + idx] = StringUtilsWin::ArgumentEscape(vm_options[i]);`
	`663`	`+#else`
`661`	`664`	`argv_[i + idx] = Utils::StrDup(vm_options[i]);`
	`665`	`+#endif`
`662`	`666`	`}`
`663`	`667`	`idx += num_vm_options;`
`664`	`668`	`{`