Parts. Un-deprecate LibraryElement.exportedLibraries/importedLibraries

They are used mostly as dependency tracking, because without combinators we don't know specific elements exported/imported. But for such dependency purpose CompilationUnitElement level "dependencies" are useless, so we should keep them at LibraryElement, but not add to CompilationUnitElement.

Change-Id: I14aaf14debaf167f29740e86d82ff2c02e241569
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389142
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 6.11.0-dev
+* Un-deprecated `LibraryElement.exportedLibraries`.
+* Un-deprecated `LibraryElement.importedLibraries`.
+
 ## 6.10.0
 * Deprecated `LibraryElement.accessibleExtensions`, use
   `CompilationUnitElement.accessibleExtensions` instead.

pkg/analyzer/lib/dart/element/element.dart

@@ -1916,7 +1916,6 @@ abstract class LibraryElement
   FunctionElement? get entryPoint;
 
   /// The libraries that are exported from this library.
-  @Deprecated('Use CompilationUnitElement.libraryExports')
   List<LibraryElement> get exportedLibraries;
 
   /// The export [Namespace] of this library.
@@ -1930,7 +1929,6 @@ abstract class LibraryElement
   ///
   /// This includes all of the libraries that are imported using a prefix, and
   /// those that are imported without a prefix.
-  @Deprecated('Use CompilationUnitElement.libraryImports')
   List<LibraryElement> get importedLibraries;
 
   /// Whether the library is an application that can be run in the browser.

pkg/analyzer/lib/src/dart/element/element.dart

@@ -5780,11 +5780,11 @@ class LibraryElementImpl extends LibraryOrAugmentationElementImpl
     return declarations.toList();
   }
 
-  @Deprecated('Use CompilationUnitElement.libraryExports')
   @override
   List<LibraryElementImpl> get exportedLibraries {
-    return libraryExports
-        .map((import) => import.exportedLibrary)
+    return fragments
+        .expand((fragment) => fragment.libraryExports)
+        .map((export) => export.exportedLibrary)
         .nonNulls
         .toSet()
         .toList();
@@ -5902,10 +5902,10 @@ class LibraryElementImpl extends LibraryOrAugmentationElementImpl
   @override
   String get identifier => '${_definingCompilationUnit.source.uri}';
 
-  @Deprecated('Use CompilationUnitElement.libraryImports')
   @override
   List<LibraryElementImpl> get importedLibraries {
-    return libraryImports
+    return fragments
+        .expand((fragment) => fragment.libraryImports)
         .map((import) => import.importedLibrary)
         .nonNulls
         .toSet()

pkg/analyzer/pubspec.yaml

@@ -1,5 +1,5 @@
 name: analyzer
-version: 6.10.0
+version: 6.11.0-dev
 description: >-
   This package provides a library that performs static analysis of Dart code.
 repository: https://github.com/dart-lang/sdk/tree/main/pkg/analyzer

pkg/analyzer_cli/lib/src/analyzer_impl.dart

@@ -71,18 +71,12 @@ class AnalyzerImpl {
       addCompilationUnitSource(unitElement, units);
     }
     // Add imported libraries.
-    var importedLibraries = library.units
-        .expand((unit) => unit.libraryImports)
-        .map((export) => export.importedLibrary)
-        .nonNulls;
+    var importedLibraries = library.importedLibraries;
     for (var child in importedLibraries) {
       addLibrarySources(child, libraries, units);
     }
     // Add exported libraries.
-    var exportedLibraries = library.units
-        .expand((unit) => unit.libraryExports)
-        .map((export) => export.exportedLibrary)
-        .nonNulls;
+    var exportedLibraries = library.exportedLibraries;
     for (var child in exportedLibraries) {
       addLibrarySources(child, libraries, units);
     }