Elements. Updates as needed for google3.

Change-Id: Ib76bf37a41d2fc0923ccddb1da37599589da3a5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396571
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/computer/computer_outline.dart

@@ -653,7 +653,7 @@ class _FunctionBodyOutlinesVisitor extends RecursiveAstVisitor<void> {
   /// Return `true` if the given [element] is a top-level member of the test
   /// package.
   bool _isInsideTestPackage(engine.TopLevelFunctionElement element) {
-    var parent = element.library2!;
+    var parent = element.library2;
     return parent.firstFragment.source.fullName.endsWith('test.dart');
   }
 }

pkg/analysis_server/lib/src/services/completion/dart/candidate_suggestion.dart

@@ -186,7 +186,8 @@ final class ConstructorSuggestion extends ExecutableSuggestion
 
     var className = enclosingClass.displayName;
 
-    var completion = element.displayName;
+    // TODO(scheglov): Wrong, if no name, should be no completion.
+    var completion = element.name3 ?? '';
     if (suggestUnnamedAsNew) {
       if (completion.isEmpty) {
         completion = 'new';

pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart

@@ -465,7 +465,7 @@ class DeclarationHelper {
       prefix: null,
       isNotImported: true,
     );
-    _addConstructors(library.asElement as LibraryElement, importData);
+    _addConstructors(library.asElement, importData);
   }
 
   /// Add members from all the applicable extensions that are visible in the
@@ -477,7 +477,7 @@ class DeclarationHelper {
     required bool includeMethods,
     required bool includeSetters,
   }) {
-    var libraryElement = library.asElement as LibraryElement;
+    var libraryElement = library.asElement;
     var applicableExtensions = library.exportNamespace.definedNames.values
         .whereType<ExtensionElement>()
         .applicableTo(
@@ -511,7 +511,7 @@ class DeclarationHelper {
       isNotImported: true,
     );
     _addExternalTopLevelDeclarations(
-      library: library.asElement as LibraryElement,
+      library: library.asElement,
       namespace: library.exportNamespace,
       importData: importData,
     );

pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart

@@ -741,7 +741,7 @@ class InScopeCompletionPass extends SimpleAstVisitor<void> {
       if (constructorElement == null) {
         return;
       }
-      var libraryElement = state.libraryElement.asElement as LibraryElement;
+      var libraryElement = state.libraryElement.asElement;
       declarationHelper(
         mustBeConstant: constructorElement.isConst,
       ).addPossibleRedirectionsInLibrary(constructorElement, libraryElement);

pkg/analysis_server/lib/src/services/refactoring/legacy/extract_method.dart

@@ -61,7 +61,7 @@ Future<void> addLibraryImports(
 
   // TODO(brianwilkerson): Use `targetLibrary2` everywhere below and rename it
   //  to `targetLibrary`.
-  var targetLibrary = targetLibrary2.asElement as LibraryElement;
+  var targetLibrary = targetLibrary2.asElement;
   var libUtils = CorrectionUtils(resolveResult);
   var eol = libUtils.endOfLine;
   // Prepare information about existing imports.

pkg/analysis_server/lib/src/services/search/hierarchy.dart

@@ -304,7 +304,7 @@ Future<List<FormalParameterElement>> getHierarchyNamedParameters2(
 ) async {
   var result = await getHierarchyNamedParameters(
     searchEngine,
-    element.asElement as ParameterElement,
+    element.asElement,
   );
   return result.map((e) => e.asElement2).toList();
 }

pkg/analyzer/lib/dart/analysis/session.dart

@@ -55,6 +55,11 @@ abstract class AnalysisSession {
   /// with the given library [element].
   SomeParsedLibraryResult getParsedLibraryByElement(LibraryElement element);
 
+  /// Return information about the results of parsing units of the library file
+  /// with the given library [element].
+  @experimental
+  SomeParsedLibraryResult getParsedLibraryByElement2(LibraryElement2 element);
+
   /// Return information about the results of parsing the file with the given
   /// absolute, normalized [path].
   SomeParsedUnitResult getParsedUnit(String path);

pkg/analyzer/lib/dart/constant/value.dart

@@ -71,6 +71,9 @@ abstract class DartObject {
   /// If this object is the value of a constant variable, the variable.
   VariableElement? get variable;
 
+  /// If this object is the value of a constant variable, the variable.
+  VariableElement2? get variable2;
+
   /// Return a representation of the value of the field with the given [name].
   ///
   /// Return `null` if either the object being represented does not have a field

pkg/analyzer/lib/dart/element/element.dart

@@ -515,6 +515,9 @@ abstract class DirectiveUri {}
 abstract class DirectiveUriWithLibrary extends DirectiveUriWithSource {
   /// The library referenced by the [source].
   LibraryElement get library;
+
+  /// The library referenced by the [source].
+  LibraryElement2 get library2;
 }
 
 /// [DirectiveUriWithRelativeUriString] that can be parsed into a relative URI.
@@ -1987,6 +1990,9 @@ abstract class LibraryExportElement implements _ExistingElement {
   /// the order in which they were specified.
   List<NamespaceCombinator> get combinators;
 
+  @override
+  CompilationUnitElement get enclosingElement3;
+
   /// The [LibraryElement], if [uri] is a [DirectiveUriWithLibrary].
   LibraryElement? get exportedLibrary;
 

pkg/analyzer/lib/dart/element/element2.dart

@@ -495,6 +495,13 @@ abstract class Element2 {
   /// be changed if doing so would improve the UX.
   String displayString2({bool multiline = false, bool preferTypeAlias = false});
 
+  /// Returns a display name for the given element that includes the path to the
+  /// compilation unit in which the type is defined. If [shortName] is `null`
+  /// then [displayName] will be used as the name of this element. Otherwise
+  /// the provided name will be used.
+  // TODO(brianwilkerson): Make the parameter optional.
+  String getExtendedDisplayName(String? shortName);
+
   /// Whether the element, assuming that it is within scope, is accessible to
   /// code in the given [library].
   ///
@@ -1165,6 +1172,28 @@ abstract class InstanceElement2
 
   /// Returns the setter from [setters2] that has the given [name].
   SetterElement? getSetter2(String name);
+
+  /// Returns the element representing the getter that results from looking up
+  /// the given [name] in this class with respect to the given [library],
+  /// or `null` if the look up fails.
+  ///
+  /// The behavior of this method is defined by the Dart Language Specification
+  /// in section 17.18 Lookup.
+  PropertyAccessorElement2? lookUpGetter2({
+    required String name,
+    required LibraryElement2 library,
+  });
+
+  /// Returns the element representing the method that results from looking up
+  /// the given [name] in this class with respect to the given [library],
+  /// or `null` if the look up fails.
+  ///
+  /// The behavior of this method is defined by the Dart Language Specification
+  /// in section 17.18 Lookup.
+  MethodElement2? lookUpMethod2({
+    required String name,
+    required LibraryElement2 library,
+  });
 }
 
 /// The portion of an [InstanceElement2] contributed by a single declaration.
@@ -1279,6 +1308,25 @@ abstract class InterfaceElement2 implements InstanceElement2 {
     required List<DartType> typeArguments,
     required NullabilitySuffix nullabilitySuffix,
   });
+
+  /// Returns the element representing the method that results from looking up
+  /// the given [methodName] in the superclass of this class with respect to the
+  /// given [library], or `null` if the look up fails.
+  ///
+  /// The behavior of this method is defined by the Dart Language Specification
+  /// in section 16.15.1:
+  /// <blockquote>
+  /// The result of looking up method <i>m</i> in class <i>C</i> with respect to
+  /// library <i>L</i> is:  If <i>C</i> declares an instance method named
+  /// <i>m</i> that is accessible to <i>L</i>, then that method is the result of
+  /// the lookup. Otherwise, if <i>C</i> has a superclass <i>S</i>, then the
+  /// result of the lookup is the result of looking up method <i>m</i> in
+  /// <i>S</i> with respect to <i>L</i>. Otherwise, we say that the lookup has
+  /// failed.
+  /// </blockquote>
+  // TODO(scheglov): Deprecate and remove it.
+  MethodElement2? lookUpInheritedMethod2(
+      String methodName, LibraryElement2 library);
 }
 
 /// The portion of an [InterfaceElement2] contributed by a single declaration.
@@ -1455,6 +1503,12 @@ abstract class LibraryElement2 implements Element2, Annotatable {
   /// of this element's parent.
   String get identifier;
 
+  /// The libraries that are imported into this library.
+  ///
+  /// This includes all of the libraries that are imported using a prefix, and
+  /// those that are imported without a prefix.
+  List<LibraryElement2> get importedLibraries2;
+
   /// Whether the library is the `dart:async` library.
   bool get isDartAsync;
 
@@ -1902,6 +1956,9 @@ abstract class MethodElement2 implements ExecutableElement2 {
   /// The test might be based on the name of the executable element, in which
   /// case the result will be correct when the name is legal.
   bool get isOperator;
+
+  @override
+  LibraryElement2 get library2;
 }
 
 /// The portion of a [MethodElement2] contributed by a single declaration.
@@ -2352,6 +2409,9 @@ abstract class TopLevelFunctionElement implements ExecutableElement2 {
   ///
   /// A top-level function is an entry point if it has the name `main`.
   bool get isEntryPoint;
+
+  @override
+  LibraryElement2 get library2;
 }
 
 /// The portion of a [TopLevelFunctionElement] contributed by a single