Skip to content

Commit 3fe4dae

Browse files
srawlinsCommit Queue
authored andcommitted
linter: Apply show directives to private imports
Change-Id: Ibb4f7605dec04775f85e1fcd3d6bbc429af14127 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409205 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Samuel Rawlins <[email protected]> Reviewed-by: Phil Quitslund <[email protected]>
1 parent 8a21984 commit 3fe4dae

10 files changed

+28
-20
lines changed

pkg/linter/lib/src/ast.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@ import 'package:analyzer/dart/element/element2.dart';
1212
import 'package:analyzer/dart/element/visitor.dart';
1313
import 'package:analyzer/dart/element/visitor2.dart';
1414
import 'package:analyzer/file_system/file_system.dart';
15-
import 'package:analyzer/src/lint/constants.dart'; // ignore: implementation_imports
16-
import 'package:analyzer/src/workspace/workspace.dart'; // ignore: implementation_imports
15+
import 'package:analyzer/src/lint/constants.dart' // ignore: implementation_imports
16+
show ExpressionExtension;
17+
import 'package:analyzer/src/workspace/workspace.dart' // ignore: implementation_imports
18+
show WorkspacePackage;
1719
import 'package:path/path.dart' as path;
1820

1921
import 'analyzer.dart';

pkg/linter/lib/src/extensions.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,14 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
import 'package:analyzer/dart/analysis/features.dart';
6+
import 'package:analyzer/dart/ast/ast.dart';
67
import 'package:analyzer/dart/ast/token.dart';
78
import 'package:analyzer/dart/constant/value.dart';
89
import 'package:analyzer/dart/element/element2.dart';
910
import 'package:analyzer/dart/element/type.dart';
1011
import 'package:analyzer/file_system/physical_file_system.dart';
11-
import 'package:analyzer/src/dart/ast/ast.dart'; // ignore: implementation_imports
12+
import 'package:analyzer/src/dart/ast/ast.dart' // ignore: implementation_imports
13+
show FunctionDeclarationImpl;
1214
import 'package:analyzer/src/dart/element/type.dart' // ignore: implementation_imports
1315
show InvalidTypeImpl;
1416
import 'package:collection/collection.dart';

pkg/linter/lib/src/rules.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// ignore: implementation_imports
6-
import 'package:analyzer/src/lint/registry.dart';
5+
import 'package:analyzer/src/lint/registry.dart' // ignore: implementation_imports
6+
show Registry;
77

88
import 'rules/always_declare_return_types.dart';
99
import 'rules/always_put_control_body_on_new_line.dart';

pkg/linter/lib/src/rules/analyzer_use_new_elements.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import 'package:analyzer/dart/ast/ast.dart';
66
import 'package:analyzer/dart/ast/visitor.dart';
77
import 'package:analyzer/dart/element/element2.dart';
88
import 'package:analyzer/dart/element/type.dart';
9-
import 'package:analyzer/src/dart/element/type_visitor.dart'; // ignore: implementation_imports
9+
import 'package:analyzer/src/dart/element/type_visitor.dart' // ignore: implementation_imports
10+
show RecursiveTypeVisitor;
1011

1112
import '../analyzer.dart';
1213
import '../extensions.dart';

pkg/linter/lib/src/rules/avoid_redundant_argument_values.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
import 'package:analyzer/dart/ast/ast.dart';
66
import 'package:analyzer/dart/ast/visitor.dart';
77
import 'package:analyzer/dart/element/element2.dart';
8-
import 'package:analyzer/src/lint/constants.dart'; // ignore: implementation_imports
8+
import 'package:analyzer/src/lint/constants.dart' // ignore: implementation_imports
9+
show ExpressionExtension;
910
import 'package:collection/collection.dart';
1011

1112
import '../analyzer.dart';

pkg/linter/lib/src/rules/avoid_renaming_method_parameters.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@
55
import 'dart:math' as math;
66

77
import 'package:analyzer/dart/analysis/features.dart';
8+
import 'package:analyzer/dart/ast/ast.dart';
89
import 'package:analyzer/dart/ast/visitor.dart';
910
import 'package:analyzer/dart/element/element2.dart';
10-
// ignore: implementation_imports
11-
import 'package:analyzer/src/dart/ast/ast.dart';
1211

1312
import '../analyzer.dart';
1413
import '../extensions.dart';

pkg/linter/lib/src/rules/avoid_returning_this.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
import 'package:analyzer/dart/ast/ast.dart';
56
import 'package:analyzer/dart/ast/visitor.dart';
67
import 'package:analyzer/dart/element/type.dart';
7-
import 'package:analyzer/src/dart/ast/ast.dart'; // ignore: implementation_imports
88

99
import '../analyzer.dart';
1010
import '../extensions.dart';

pkg/linter/lib/src/rules/avoid_types_as_parameter_names.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import 'package:analyzer/dart/ast/ast.dart';
66
import 'package:analyzer/dart/ast/token.dart';
77
import 'package:analyzer/dart/ast/visitor.dart';
88
import 'package:analyzer/dart/element/element2.dart';
9-
// ignore: implementation_imports
10-
import 'package:analyzer/src/dart/element/extensions.dart';
9+
import 'package:analyzer/src/dart/element/extensions.dart' // ignore: implementation_imports
10+
show Element2Extension;
1111

1212
import '../analyzer.dart';
1313
import '../util/scope.dart';

pkg/linter/lib/src/rules/deprecated_member_use_from_same_package.dart

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,17 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
/// @docImport 'package:analyzer/src/error/deprecated_member_use_verifier.dart';
6+
library;
7+
58
import 'package:analyzer/dart/ast/ast.dart';
69
import 'package:analyzer/dart/ast/syntactic_entity.dart';
710
import 'package:analyzer/dart/ast/visitor.dart';
811
import 'package:analyzer/dart/element/element2.dart';
9-
// ignore: implementation_imports
10-
import 'package:analyzer/src/error/deprecated_member_use_verifier.dart';
11-
// ignore: implementation_imports
12-
import 'package:analyzer/src/workspace/workspace.dart';
12+
import 'package:analyzer/src/error/deprecated_member_use_verifier.dart' // ignore: implementation_imports
13+
show BaseDeprecatedMemberUseVerifier;
14+
import 'package:analyzer/src/workspace/workspace.dart' // ignore: implementation_imports
15+
show WorkspacePackage;
1316

1417
import '../analyzer.dart';
1518

pkg/linter/lib/src/rules/document_ignores.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44

55
import 'package:analyzer/dart/ast/ast.dart';
66
import 'package:analyzer/dart/ast/visitor.dart';
7-
// ignore: implementation_imports
8-
import 'package:analyzer/src/ignore_comments/ignore_info.dart';
9-
// ignore: implementation_imports
10-
import 'package:analyzer/src/utilities/extensions/string.dart';
7+
import 'package:analyzer/src/ignore_comments/ignore_info.dart' // ignore: implementation_imports
8+
show CommentTokenExtension, CompilationUnitExtension, IgnoredDiagnosticComment;
9+
import 'package:analyzer/src/utilities/extensions/string.dart' // ignore: implementation_imports
10+
show IntExtension;
1111

1212
import '../analyzer.dart';
1313

0 commit comments

Comments
 (0)