[cfe] Issue 60121: Fix bug with isWildcard flag for formals.

The `isWildcard` flag for formals was being set as `false` since it
was checking that the parameter was `_` after the formal was
lowered already into something like `#wc0#formal`.

Tested: Existing VM tests that have been updated.
Fixes: #60121
Bug: #60121
Change-Id: I4df96d47ef8b6af8ece634360d14a19d1cb9d916
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410161
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>
Reviewed-by: Derek Xu <[email protected]>

Author: kallentu

pkg/front_end/lib/src/kernel/body_builder.dart

@@ -5464,8 +5464,7 @@ class BodyBuilder extends StackListenerImpl
           offsetForToken(nameToken),
           fileUri: uri,
           hasImmediatelyDeclaredInitializer: initializerStart != null,
-          isWildcard: libraryFeatures.wildcardVariables.isEnabled &&
-              parameterName == '_');
+          isWildcard: isWildcard);
     }
     VariableDeclaration variable = parameter.build(libraryBuilder);
     Expression? initializer = name?.initializer;

pkg/front_end/testcases/general/await_complex.dart.strong.expect

@@ -39,7 +39,7 @@ static final field core::bool assertStatementsEnabled = (() → core::bool {
     assert(false);
     return false;
   }
-  on core::Object catch(final core::Object _#wc0#formal) {
+  on core::Object catch(final wildcard core::Object _#wc0#formal) {
     return true;
   }
 })(){() → core::bool};

pkg/front_end/testcases/general/await_complex.dart.strong.modular.expect

@@ -39,7 +39,7 @@ static final field core::bool assertStatementsEnabled = (() → core::bool {
     assert(false);
     return false;
   }
-  on core::Object catch(final core::Object _#wc0#formal) {
+  on core::Object catch(final wildcard core::Object _#wc0#formal) {
     return true;
   }
 })(){() → core::bool};

pkg/front_end/testcases/general/await_complex.dart.strong.transformed.expect

@@ -39,7 +39,7 @@ static final field core::bool assertStatementsEnabled = (() → core::bool {
     assert(false);
     return false;
   }
-  on core::Object catch(final core::Object _#wc0#formal) {
+  on core::Object catch(final wildcard core::Object _#wc0#formal) {
     return true;
   }
 })(){() → core::bool};

pkg/front_end/testcases/general/bad_setter_abstract.dart.strong.expect

@@ -151,7 +151,7 @@ static method test() → dynamic {
     invalid-expression "The class 'B' is abstract and can't be instantiated.";
     threw = false;
   }
-  on core::Error catch(final core::Error _#wc0#formal) {
+  on core::Error catch(final wildcard core::Error _#wc0#formal) {
   }
   if(!threw) {
     throw "Expected an error above.";

pkg/front_end/testcases/general/bad_setter_abstract.dart.strong.modular.expect

@@ -151,7 +151,7 @@ static method test() → dynamic {
     invalid-expression "The class 'B' is abstract and can't be instantiated.";
     threw = false;
   }
-  on core::Error catch(final core::Error _#wc0#formal) {
+  on core::Error catch(final wildcard core::Error _#wc0#formal) {
   }
   if(!threw) {
     throw "Expected an error above.";

pkg/front_end/testcases/general/bad_setter_abstract.dart.strong.transformed.expect

@@ -151,7 +151,7 @@ static method test() → dynamic {
     invalid-expression "The class 'B' is abstract and can't be instantiated.";
     threw = false;
   }
-  on core::Error catch(final core::Error _#wc0#formal) {
+  on core::Error catch(final wildcard core::Error _#wc0#formal) {
   }
   if(!threw) {
     throw "Expected an error above.";

pkg/front_end/testcases/general/issue34899.dart.strong.expect

@@ -10,7 +10,7 @@ class Foo<T extends core::Object? = dynamic> extends core::Object {
     : self::Foo::quux = quux, self::Foo::t = t, super core::Object::•()
     ;
   method call() → asy::Future<self::Foo::T%>
-    return this.{self::Foo::quux}{() → asy::Future<dynamic>}(){() → asy::Future<dynamic>}.{asy::Future::then}<self::Foo::T%>((dynamic _#wc0#formal) → self::Foo::T% => this.{self::Foo::t}{self::Foo::T%}){((dynamic) → FutureOr<self::Foo::T%>, {onError: core::Function?}) → asy::Future<self::Foo::T%>};
+    return this.{self::Foo::quux}{() → asy::Future<dynamic>}(){() → asy::Future<dynamic>}.{asy::Future::then}<self::Foo::T%>((wildcard dynamic _#wc0#formal) → self::Foo::T% => this.{self::Foo::t}{self::Foo::T%}){((dynamic) → FutureOr<self::Foo::T%>, {onError: core::Function?}) → asy::Future<self::Foo::T%>};
 }
 class Bar extends core::Object {
   field self::Foo<self::Baz> qux = throw "";

pkg/front_end/testcases/general/issue34899.dart.strong.modular.expect

@@ -10,7 +10,7 @@ class Foo<T extends core::Object? = dynamic> extends core::Object {
     : self::Foo::quux = quux, self::Foo::t = t, super core::Object::•()
     ;
   method call() → asy::Future<self::Foo::T%>
-    return this.{self::Foo::quux}{() → asy::Future<dynamic>}(){() → asy::Future<dynamic>}.{asy::Future::then}<self::Foo::T%>((dynamic _#wc0#formal) → self::Foo::T% => this.{self::Foo::t}{self::Foo::T%}){((dynamic) → FutureOr<self::Foo::T%>, {onError: core::Function?}) → asy::Future<self::Foo::T%>};
+    return this.{self::Foo::quux}{() → asy::Future<dynamic>}(){() → asy::Future<dynamic>}.{asy::Future::then}<self::Foo::T%>((wildcard dynamic _#wc0#formal) → self::Foo::T% => this.{self::Foo::t}{self::Foo::T%}){((dynamic) → FutureOr<self::Foo::T%>, {onError: core::Function?}) → asy::Future<self::Foo::T%>};
 }
 class Bar extends core::Object {
   field self::Foo<self::Baz> qux = throw "";

pkg/front_end/testcases/general/issue34899.dart.strong.transformed.expect

@@ -10,7 +10,7 @@ class Foo<T extends core::Object? = dynamic> extends core::Object {
     : self::Foo::quux = quux, self::Foo::t = t, super core::Object::•()
     ;
   method call() → asy::Future<self::Foo::T%>
-    return this.{self::Foo::quux}{() → asy::Future<dynamic>}(){() → asy::Future<dynamic>}.{asy::Future::then}<self::Foo::T%>((dynamic _#wc0#formal) → self::Foo::T% => this.{self::Foo::t}{self::Foo::T%}){((dynamic) → FutureOr<self::Foo::T%>, {onError: core::Function?}) → asy::Future<self::Foo::T%>};
+    return this.{self::Foo::quux}{() → asy::Future<dynamic>}(){() → asy::Future<dynamic>}.{asy::Future::then}<self::Foo::T%>((wildcard dynamic _#wc0#formal) → self::Foo::T% => this.{self::Foo::t}{self::Foo::T%}){((dynamic) → FutureOr<self::Foo::T%>, {onError: core::Function?}) → asy::Future<self::Foo::T%>};
 }
 class Bar extends core::Object {
   field self::Foo<self::Baz> qux = throw "";