analyzer: rename Lint*Context classes

For the analyzer plugin APIs, these classes should not have the word
'Lint' in them, as they are used for all analysis rules, whether they
report lints or warnings.

* LinterContext                    -> RuleContext
* LinterContextWithParsedResults   -> RuleContextWithParsedResults
* LinterContextWithResolvedResults -> RuleContextWithResolvedResults
* LintRuleUnitContext              -> RuleUnitContext

I'm open to better names for these. Some of these suffer from a
chain-of-nouns name (a "RuleUnitContext" is a Context for a Unit for
a Rule). So we could go with "UnitContextForRule" and "ContextForRule"
or other ideas like that.

Only RuleContext and RuleUnitContext will be public API.

Change-Id: I5550736beaba7e39b36e7b5584ca6d023aa4d02b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/431703
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart

@@ -273,24 +273,24 @@ class BulkFixProcessor {
         }
         if (parsedLibrary is ParsedLibraryResult) {
           var errorListener = RecordingErrorListener();
-          var unitContexts = <LintRuleUnitContext>[];
+          var contextUnits = <RuleContextUnit>[];
 
           for (var parsedUnit in parsedLibrary.units) {
             var errorReporter = ErrorReporter(
               errorListener,
               StringSource(parsedUnit.content, null),
             );
-            unitContexts.add(
-              LintRuleUnitContext(
+            contextUnits.add(
+              RuleContextUnit(
                 file: parsedUnit.file,
                 content: parsedUnit.content,
                 errorReporter: errorReporter,
                 unit: parsedUnit.unit,
               ),
             );
           }
-          for (var unitContext in unitContexts) {
-            _computeParsedResultLint(unitContext, unitContexts);
+          for (var unitContext in contextUnits) {
+            _computeParsedResultLint(unitContext, contextUnits);
           }
           await _fixErrorsInParsedLibrary(
             parsedLibrary,
@@ -531,11 +531,13 @@ class BulkFixProcessor {
   /// Computes lint for lint rules with names [_syntacticLintCodes] (rules that
   /// do not require [ResolvedUnitResult]s).
   void _computeParsedResultLint(
-    LintRuleUnitContext currentUnit,
-    List<LintRuleUnitContext> allUnits,
+    RuleContextUnit currentUnit,
+    List<RuleContextUnit> allUnits,
   ) {
     var nodeRegistry = RuleVisitorRegistry(enableTiming: false);
-    var context = LinterContextWithParsedResults(allUnits, currentUnit);
+    // TODO(srawlins): We are passing `currentUnit` in as `definingUnit`. Seems
+    // wrong.
+    var context = RuleContextWithParsedResults(allUnits, currentUnit);
     var lintRules =
         _syntacticLintCodes
             .map((name) => Registry.ruleRegistry.getRule(name))

pkg/analysis_server_plugin/lib/src/plugin_server.dart

@@ -321,15 +321,15 @@ class PluginServer {
     var errorReporter = ErrorReporter(
         listener, unitResult.libraryElement2.firstFragment.source);
 
-    var currentUnit = LintRuleUnitContext(
+    var currentUnit = RuleContextUnit(
       file: unitResult.file,
       content: unitResult.content,
       errorReporter: errorReporter,
       unit: unitResult.unit,
     );
     var allUnits = [
       for (var unitResult in libraryResult.units)
-        LintRuleUnitContext(
+        RuleContextUnit(
           file: unitResult.file,
           content: unitResult.content,
           errorReporter: errorReporter,
@@ -341,7 +341,7 @@ class PluginServer {
     // `benchhmark.dart` script does.
     var nodeRegistry = RuleVisitorRegistry(enableTiming: false);
 
-    var context = LinterContextWithResolvedResults(
+    var context = RuleContextWithResolvedResults(
       allUnits,
       currentUnit,
       libraryResult.element2.typeProvider,

pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart

@@ -381,11 +381,11 @@ class LibraryAnalyzer {
 
   void _computeLints() {
     var definingUnit = _libraryElement.definingCompilationUnit;
-    var analysesToContextUnits = <FileAnalysis, LintRuleUnitContext>{};
-    LintRuleUnitContext? definingContextUnit;
+    var analysesToContextUnits = <FileAnalysis, RuleContextUnit>{};
+    RuleContextUnit? definingContextUnit;
     WorkspacePackageImpl? workspacePackage;
     for (var fileAnalysis in _libraryFiles.values) {
-      var linterContextUnit = LintRuleUnitContext(
+      var linterContextUnit = RuleContextUnit(
         file: fileAnalysis.file.resource,
         content: fileAnalysis.file.content,
         unit: fileAnalysis.unit,
@@ -402,7 +402,7 @@ class LibraryAnalyzer {
     definingContextUnit ??= allUnits.first;
 
     var nodeRegistry = RuleVisitorRegistry(enableTiming: _enableLintRuleTiming);
-    var context = LinterContextWithResolvedResults(
+    var context = RuleContextWithResolvedResults(
       allUnits,
       definingContextUnit,
       _typeProvider,