[DAS] Fixes Add missing Switch cases not importing src libraries

Fixes: #60531
Change-Id: I6ca063aeaad2b6ce994c8637da653561231b1fdf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451340
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/correction/dart/add_missing_switch_cases.dart

@@ -5,6 +5,7 @@
 import 'package:analysis_server/src/services/correction/fix.dart';
 import 'package:analysis_server_plugin/edit/dart/correction_producer.dart';
 import 'package:analyzer/dart/ast/ast.dart';
+import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/diagnostic/diagnostic.dart';
 import 'package:analyzer/src/generated/exhaustiveness.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
@@ -57,9 +58,8 @@ class AddMissingSwitchCases extends ResolvedCorrectionProducer {
   /// Returns whether [parts] references an enum field where either the enum
   /// class itself or the missing field is not reachable because it's private.
   bool _hasInaccessibleEnumMemberPart(List<MissingPatternPart> parts) {
-    for (var part in parts) {
-      if (part is MissingPatternEnumValuePart &&
-          (part.enumElement2.isPrivate || part.value2.isPrivate) &&
+    for (var part in parts.whereType<MissingPatternEnumValuePart>()) {
+      if ((part.enumElement2.isPrivate || part.value2.isPrivate) &&
           libraryElement2 != part.enumElement2.library) {
         return true;
       }
@@ -68,6 +68,21 @@ class AddMissingSwitchCases extends ResolvedCorrectionProducer {
     return false;
   }
 
+  /// Returns whether [parts] references a type from within a `src/` library
+  /// that is not from the current project.
+  Future<bool> _hasInaccessibleTypePart(List<MissingPatternPart> parts) async {
+    for (var part in parts.whereType<MissingPatternTypePart>()) {
+      if (part.type.element case Element(:var name?) && var element) {
+        var declarations = await getTopLevelDeclarations(name);
+        if (!declarations.containsValue(element)) {
+          return true;
+        }
+      }
+    }
+
+    return false;
+  }
+
   Future<void> _switchExpression({
     required ChangeBuilder builder,
     required SwitchExpression node,
@@ -80,6 +95,16 @@ class AddMissingSwitchCases extends ResolvedCorrectionProducer {
     // of the switch. For instance, an enum with a private member can't be
     // matched outside of its library.
     var needsDefault = false;
+    for (var patternParts in patternPartsList.toList()) {
+      if (_hasInaccessibleEnumMemberPart(patternParts)) {
+        needsDefault = true;
+        patternPartsList.remove(patternParts);
+      }
+      if (await _hasInaccessibleTypePart(patternParts)) {
+        patternPartsList.remove(patternParts);
+        needsDefault = true;
+      }
+    }
 
     await builder.addDartFileEdit(file, (builder) {
       builder.insertCaseClauseAtEnd(
@@ -89,11 +114,6 @@ class AddMissingSwitchCases extends ResolvedCorrectionProducer {
         rightBracket: node.rightBracket,
         (builder) {
           for (var patternParts in patternPartsList) {
-            if (_hasInaccessibleEnumMemberPart(patternParts)) {
-              needsDefault = true;
-              continue;
-            }
-
             builder.write(lineIndent);
             builder.write(singleIndent);
             builder.writeln('// TODO: Handle this case.');

pkg/analysis_server/test/src/services/correction/fix/add_missing_switch_cases_test.dart

@@ -5,6 +5,7 @@
 import 'package:analysis_server/src/services/correction/fix.dart';
 import 'package:analyzer/diagnostic/diagnostic.dart';
 import 'package:analyzer/src/error/codes.dart';
+import 'package:analyzer/utilities/package_config_file_builder.dart';
 import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
 import 'package:linter/src/lint_names.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -354,6 +355,44 @@ int f(num x) {
     int() => throw UnimplementedError(),
   };
 }
+''');
+  }
+
+  Future<void> test_sealed_impl() async {
+    var otherRoot = getFolder('$packagesRootPath/other');
+    newFile('$otherRoot/lib/src/private.dart', '''
+sealed class A {}
+sealed class B implements A {}
+abstract final class C implements B {}
+final class CImpl extends B implements C {}
+''');
+    newFile('$otherRoot/lib/exposed.dart', '''
+export 'src/private.dart' show A, B, C;
+''');
+    updateTestPubspecFile('''
+name: test
+dependencies:
+  other: any
+''');
+    writeTestPackageConfig(
+      config: PackageConfigFileBuilder()
+        ..add(name: 'other', rootPath: otherRoot.path),
+    );
+    await resolveTestCode('''
+import 'package:other/exposed.dart';
+
+int f(A a) => switch (a) {
+};
+''');
+    await assertHasFix('''
+import 'package:other/exposed.dart';
+
+int f(A a) => switch (a) {
+  // TODO: Handle this case.
+  C() => throw UnimplementedError(),
+  // TODO: Handle this case.
+  _ => throw UnimplementedError(),
+};
 ''');
   }
 }