Skip to content

Commit 433231c

Browse files
stereotype441Commit Queue
authored andcommitted
[front end] Remove template... declarations.
This is part of a series of CLs that will standardize CFE error reporting to always use `codeFoo.withArguments(...)` when reporting errors that take arguments and `codeFoo` when reporting errors that don't take arguments, rather than `templateFoo.withArguments(...)` when reporting errors that take arguments and `messageFoo` when reporting errors that don't take arguments. This change will have two advantages: - It will lend greater consistency to the CFE codebase, by allowing the same `code...` objects to be used both to name error codes (e.g., in test expectations) and to report errors. This will allow everything associated with a certain error code to be found using a single invocation of "Find References" in the editor, rather than having to search separately for uses of the code and the message or template. - It should hopefully make the experience of writing code that reports errors more pleasant, since it will no longer be necessary to look up an error to see whether it takes arguments before using it; instead, the developer will be able to type the name of the message `code...` declaration, and then use autocompletion to see whether `.withArguments(...)` is required. In this CL, the `template...` declarations that define errors are removed, since they are no longer used (the equivalent `code...` declarations are used instead). In follow-up CLs, a similar set of changes will be made to replace references to `message...` declarations with references to the corresponding `code...` declaration. Change-Id: I14210cdf7b972b142b16477c46e3484eda879ef6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442733 Commit-Queue: Paul Berry <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
1 parent 8e1dd8d commit 433231c

File tree

3 files changed

+5
-2306
lines changed

3 files changed

+5
-2306
lines changed

0 commit comments

Comments
 (0)