analyzer_testing: Rename PubPackageResolutionTest.ignoredErrorCodes to ignoredDiagnosticCodes

Change-Id: I0a951ecbf8aa74d1c00df99e0f5bdab84bb00dde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430542
Reviewed-by: Keerti Parthasarathy <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analyzer_testing/lib/src/analysis_rule/pub_package_resolution.dart

@@ -152,7 +152,7 @@ class PubPackageResolutionTest with MockPackagesMixin, ResourceProviderMixin {
   List<String> get experiments => experimentsForTests;
 
   /// Error codes that by default should be ignored in test expectations.
-  List<DiagnosticCode> get ignoredErrorCodes => [
+  List<DiagnosticCode> get ignoredDiagnosticCodes => [
     WarningCode.UNUSED_ELEMENT,
     WarningCode.UNUSED_FIELD,
     WarningCode.UNUSED_LOCAL_VARIABLE,
@@ -184,7 +184,7 @@ class PubPackageResolutionTest with MockPackagesMixin, ResourceProviderMixin {
   /// The diagnostics that were computed during analysis.
   List<Diagnostic> get _diagnostics =>
       result.errors
-          .where((e) => !ignoredErrorCodes.any((c) => e.errorCode == c))
+          .where((e) => !ignoredDiagnosticCodes.any((c) => e.errorCode == c))
           .toList();
 
   Folder get _sdkRoot => newFolder('/sdk');

pkg/linter/test/rules/always_put_control_body_on_new_line_test.dart

@@ -16,7 +16,7 @@ void main() {
 @reflectiveTest
 class AlwaysPutControlBodyOnNewLineTest extends LintRuleTest {
   @override
-  List<DiagnosticCode> get ignoredErrorCodes => [
+  List<DiagnosticCode> get ignoredDiagnosticCodes => [
     WarningCode.DEAD_CODE,
     WarningCode.UNUSED_LOCAL_VARIABLE,
   ];

pkg/linter/test/rules/combinators_ordering_test.dart

@@ -16,7 +16,9 @@ void main() {
 @reflectiveTest
 class CombinatorsOrderingTest extends LintRuleTest {
   @override
-  List<DiagnosticCode> get ignoredErrorCodes => [WarningCode.UNUSED_IMPORT];
+  List<DiagnosticCode> get ignoredDiagnosticCodes => [
+    WarningCode.UNUSED_IMPORT,
+  ];
 
   @override
   String get lintRule => LintNames.combinators_ordering;

pkg/linter/test/rules/deprecated_member_use_from_same_package_test.dart

@@ -16,7 +16,7 @@ void main() {
 @reflectiveTest
 class DeprecatedMemberUseFromSamePackageTest extends LintRuleTest {
   @override
-  List<DiagnosticCode> get ignoredErrorCodes => [
+  List<DiagnosticCode> get ignoredDiagnosticCodes => [
     HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE,
     HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE,
     WarningCode.UNUSED_LOCAL_VARIABLE,

pkg/linter/test/rules/library_prefixes_test.dart

@@ -16,7 +16,7 @@ void main() {
 @reflectiveTest
 class LibraryPrefixesTest extends LintRuleTest {
   @override
-  List<DiagnosticCode> get ignoredErrorCodes => [
+  List<DiagnosticCode> get ignoredDiagnosticCodes => [
     WarningCode.UNUSED_IMPORT,
     WarningCode.UNUSED_LOCAL_VARIABLE,
   ];

pkg/linter/test/rules/no_leading_underscores_for_library_prefixes_test.dart

@@ -16,7 +16,7 @@ void main() {
 @reflectiveTest
 class NoLeadingUnderscoresForLibraryPrefixesTest extends LintRuleTest {
   @override
-  List<DiagnosticCode> get ignoredErrorCodes => [
+  List<DiagnosticCode> get ignoredDiagnosticCodes => [
     WarningCode.UNUSED_IMPORT,
     WarningCode.UNUSED_LOCAL_VARIABLE,
   ];

pkg/linter/test/rules/no_leading_underscores_for_local_identifiers_test.dart

@@ -16,9 +16,9 @@ void main() {
 @reflectiveTest
 class NoLeadingUnderscoresForLocalIdentifiersTest extends LintRuleTest {
   @override
-  List<DiagnosticCode> get ignoredErrorCodes => [
+  List<DiagnosticCode> get ignoredDiagnosticCodes => [
     WarningCode.UNUSED_CATCH_STACK,
-    ...super.ignoredErrorCodes,
+    ...super.ignoredDiagnosticCodes,
   ];
 
   @override