Skip to content

Commit 449ecbb

Browse files
rmacnak-googleCommit Queue
authored andcommitted
[build] Add missing inputs to //runtime:generate_version_cc_file.
Change-Id: I268524b08f89c54dee1570c2637369facc1cd54e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/435262 Reviewed-by: Alexander Aprelev <[email protected]> Commit-Queue: Ryan Macnak <[email protected]>
1 parent 9c5ef89 commit 449ecbb

File tree

2 files changed

+29
-9
lines changed

2 files changed

+29
-9
lines changed

runtime/BUILD.gn

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,26 @@ action("generate_version_cc_file") {
375375
"../tools/VERSION",
376376
"vm/version_in.cc",
377377
]
378+
379+
# This list must be kept in sync with the VM_SNAPSHOT_FILES in
380+
# tools/make_version.py.
381+
inputs += [
382+
"vm/app_snapshot.cc",
383+
"vm/app_snapshot.h",
384+
"vm/dart.cc",
385+
"vm/dart_api_impl.cc",
386+
"vm/datastream.h",
387+
"vm/image_snapshot.cc",
388+
"vm/image_snapshot.h",
389+
"vm/object.cc",
390+
"vm/object.h",
391+
"vm/raw_object.cc",
392+
"vm/raw_object.h",
393+
"vm/snapshot.cc",
394+
"vm/snapshot.h",
395+
"vm/symbols.cc",
396+
"vm/symbols.h",
397+
]
378398
if (dart_version_git_info) {
379399
inputs += [ "$default_git_folder/logs/HEAD" ]
380400
}

tools/make_version.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,24 @@
1515

1616
# When these files change, snapshots created by the VM are potentially no longer
1717
# backwards-compatible.
18+
# This list must be kept in sync with the inputs to generate_version_cc_file in
19+
# runtime/BUILD.gn.
1820
VM_SNAPSHOT_FILES = [
19-
# Header files.
20-
'app_snapshot.h',
21-
'datastream.h',
22-
'image_snapshot.h',
23-
'object.h',
24-
'raw_object.h',
25-
'snapshot.h',
26-
'symbols.h',
27-
# Source files.
2821
'app_snapshot.cc',
22+
'app_snapshot.h',
2923
'dart.cc',
3024
'dart_api_impl.cc',
25+
'datastream.h',
3126
'image_snapshot.cc',
27+
'image_snapshot.h',
3228
'object.cc',
29+
'object.h',
3330
'raw_object.cc',
31+
'raw_object.h',
3432
'snapshot.cc',
33+
'snapshot.h',
3534
'symbols.cc',
35+
'symbols.h',
3636
]
3737

3838

0 commit comments

Comments
 (0)