[analyzer] Update SDK constraint to ^3.9.0, format.

Change-Id: I79fe556112b6b9e471b043bf668677c9654b80d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447004
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/CHANGELOG.md

@@ -1,4 +1,5 @@
 ## 8.2.0-dev
+* Updated SDK constraint to `^3.9.0`.
 * Deprecate `Diagnostic.data`. Instead, please use an expando to attach data to
   the `Diagnostic` object.
 * Deprecate `CatchClauseParameter.declaredElement` and `CatchClauseParameter.declaredElement2`.

pkg/analyzer/lib/dart/analysis/analysis_options.dart

@@ -88,11 +88,10 @@ final class GitPluginSource implements PluginSource {
 
   @override
   String toYaml({required String name}) {
-    var buffer =
-        StringBuffer()
-          ..writeln('  $name:')
-          ..writeln('    git:')
-          ..writeln('      url: $_url');
+    var buffer = StringBuffer()
+      ..writeln('  $name:')
+      ..writeln('    git:')
+      ..writeln('      url: $_url');
     if (_ref != null) {
       buffer.writeln('      ref: $_ref');
     }
@@ -109,7 +108,8 @@ final class PathPluginSource implements PluginSource {
   PathPluginSource({required String path}) : _path = path;
 
   @override
-  String toYaml({required String name}) => '''
+  String toYaml({required String name}) =>
+      '''
   $name:
     path: $_path
 ''';

pkg/analyzer/lib/dart/analysis/utilities.dart

@@ -84,10 +84,11 @@ ParseStringResult parseString({
   var source = StringSource(content, path ?? '');
   var reader = CharSequenceReader(content);
   var diagnosticCollector = RecordingDiagnosticListener();
-  var scanner = Scanner(source, reader, diagnosticCollector)..configureFeatures(
-    featureSetForOverriding: featureSet,
-    featureSet: featureSet,
-  );
+  var scanner = Scanner(source, reader, diagnosticCollector)
+    ..configureFeatures(
+      featureSetForOverriding: featureSet,
+      featureSet: featureSet,
+    );
   var token = scanner.tokenize();
   var languageVersion = LibraryLanguageVersion(
     package: ExperimentStatus.currentVersion,

pkg/analyzer/lib/file_system/memory_file_system.dart

@@ -39,14 +39,12 @@ class MemoryResourceProvider implements ResourceProvider {
   MemoryResourceProvider({
     pathos.Context? context,
     this.delayWatcherInitialization,
-  }) : _pathContext =
-           context ??=
-               pathos.style == pathos.Style.windows
-                   // On Windows, ensure that the current drive matches
-                   // the drive inserted by ResourceProvider.convertPath
-                   // so that packages are mapped to the correct drive
-                   ? pathos.Context(current: 'C:\\')
-                   : pathos.context;
+  }) : _pathContext = context ??= pathos.style == pathos.Style.windows
+           // On Windows, ensure that the current drive matches
+           // the drive inserted by ResourceProvider.convertPath
+           // so that packages are mapped to the correct drive
+           ? pathos.Context(current: 'C:\\')
+           : pathos.context;
 
   @override
   pathos.Context get pathContext => _pathContext;

pkg/analyzer/lib/file_system/physical_file_system.dart

@@ -311,14 +311,11 @@ class _PhysicalFolder extends _PhysicalResource implements Folder {
     var watcher = DirectoryWatcher(_entry.path);
     var events = watcher.events.handleError(
       (Object error) {},
-      test:
-          (error) =>
-              error is io.FileSystemException &&
-              // Don't suppress "Directory watcher closed," so the outer
-              // listener can see the interruption & act on it.
-              !error.message.startsWith(
-                "Directory watcher closed unexpectedly",
-              ),
+      test: (error) =>
+          error is io.FileSystemException &&
+          // Don't suppress "Directory watcher closed," so the outer
+          // listener can see the interruption & act on it.
+          !error.message.startsWith("Directory watcher closed unexpectedly"),
     );
     return ResourceWatcher(
       events.transform(_exceptionTransformer),

pkg/analyzer/lib/instrumentation/log_adapter.dart

@@ -70,8 +70,9 @@ class InstrumentationLogAdapter implements InstrumentationService {
     Object exception,
     StackTrace stackTrace,
   ) {
-    String timeStamp =
-        time == null ? 'null' : time.millisecondsSinceEpoch.toString();
+    String timeStamp = time == null
+        ? 'null'
+        : time.millisecondsSinceEpoch.toString();
     String exceptionText = exception.toString();
     String stackTraceText = stackTrace.toString();
     _instrumentationLogger.log(

pkg/analyzer/lib/src/analysis_options/code_style_options.dart

@@ -99,10 +99,9 @@ class CodeStyleOptionsImpl implements CodeStyleOptions {
   bool _isLintEnabled(String name) => options.isLintEnabled(name);
 
   /// Returns the preferred lint quote, otherwise `null`.
-  String? _lintQuote() =>
-      _isLintEnabled('prefer_single_quotes')
-          ? "'"
-          : _isLintEnabled('prefer_double_quotes')
-          ? '"'
-          : null;
+  String? _lintQuote() => _isLintEnabled('prefer_single_quotes')
+      ? "'"
+      : _isLintEnabled('prefer_double_quotes')
+      ? '"'
+      : null;
 }

pkg/analyzer/lib/src/analysis_options/options_file_validator.dart

@@ -331,19 +331,19 @@ class _AnalyzerTopLevelOptionsValidator extends _TopLevelOptionValidator {
 /// values in the section, and whether each value is a valid string.
 class _CannotIgnoreOptionValidator extends OptionsValidator {
   /// Lazily populated set of diagnostic code names.
-  static final Set<String> _diagnosticCodes =
-      diagnosticCodeValues.map((DiagnosticCode code) => code.name).toSet();
+  static final Set<String> _diagnosticCodes = diagnosticCodeValues
+      .map((DiagnosticCode code) => code.name)
+      .toSet();
 
   /// The diagnostic code names that existed, but were removed.
   /// We don't want to report these, this breaks clients.
   // TODO(scheglov): https://github.com/flutter/flutter/issues/141576
   static const Set<String> _removedDiagnosticCodes = {'MISSING_RETURN'};
 
   /// Lazily populated set of lint code names.
-  late final Set<String> _lintCodes =
-      Registry.ruleRegistry.rules
-          .map((rule) => rule.name.toUpperCase())
-          .toSet();
+  late final Set<String> _lintCodes = Registry.ruleRegistry.rules
+      .map((rule) => rule.name.toUpperCase())
+      .toSet();
 
   @override
   void validate(DiagnosticReporter reporter, YamlMap options) {
@@ -474,8 +474,9 @@ class _EnableExperimentsValidator extends OptionsValidator {
         AnalysisOptionsFile.enableExperiment,
       );
       if (experimentNames is YamlList) {
-        var flags =
-            experimentNames.nodes.map((node) => node.toString()).toList();
+        var flags = experimentNames.nodes
+            .map((node) => node.toString())
+            .toList();
         for (var validationResult in validateFlags(flags)) {
           var flagIndex = validationResult.stringIndex;
           var span = experimentNames.nodes[flagIndex].span;
@@ -575,19 +576,19 @@ class _ErrorFilterOptionValidator extends OptionsValidator {
       legalValues.quotedAndCommaSeparatedWithAnd;
 
   /// Lazily populated set of diagnostic code names.
-  static final Set<String> _diagnosticCodes =
-      diagnosticCodeValues.map((DiagnosticCode code) => code.name).toSet();
+  static final Set<String> _diagnosticCodes = diagnosticCodeValues
+      .map((DiagnosticCode code) => code.name)
+      .toSet();
 
   /// The diagnostic code names that existed, but were removed.
   /// We don't want to report these, this breaks clients.
   // TODO(scheglov): https://github.com/flutter/flutter/issues/141576
   static const Set<String> _removedDiagnosticCodes = {'MISSING_RETURN'};
 
   /// Lazily populated set of lint code names.
-  late final Set<String> _lintCodes =
-      Registry.ruleRegistry.rules
-          .map((rule) => rule.name.toUpperCase())
-          .toSet();
+  late final Set<String> _lintCodes = Registry.ruleRegistry.rules
+      .map((rule) => rule.name.toUpperCase())
+      .toSet();
 
   @override
   void validate(DiagnosticReporter reporter, YamlMap options) {
@@ -1080,10 +1081,9 @@ class _TopLevelOptionValidator extends OptionsValidator {
   _TopLevelOptionValidator(this.pluginName, this.supportedOptions)
     : assert(supportedOptions.isNotEmpty),
       _valueProposal = supportedOptions.quotedAndCommaSeparatedWithAnd,
-      _warningCode =
-          supportedOptions.length == 1
-              ? AnalysisOptionsWarningCode.unsupportedOptionWithLegalValue
-              : AnalysisOptionsWarningCode.unsupportedOptionWithLegalValues;
+      _warningCode = supportedOptions.length == 1
+          ? AnalysisOptionsWarningCode.unsupportedOptionWithLegalValue
+          : AnalysisOptionsWarningCode.unsupportedOptionWithLegalValues;
 
   @override
   void validate(DiagnosticReporter reporter, YamlMap options) {

pkg/analyzer/lib/src/analysis_rule/rule_context.dart

@@ -44,31 +44,27 @@ final class RuleContextWithParsedResults implements RuleContext {
   bool get isInTestDirectory => false;
 
   @override
-  LibraryElement get libraryElement =>
-      throw UnsupportedError(
-        'RuleContext with parsed results does not include a LibraryElement',
-      );
+  LibraryElement get libraryElement => throw UnsupportedError(
+    'RuleContext with parsed results does not include a LibraryElement',
+  );
 
   @override
   WorkspacePackage? get package => null;
 
   @override
-  TypeProvider get typeProvider =>
-      throw UnsupportedError(
-        'RuleContext with parsed results does not include a TypeProvider',
-      );
+  TypeProvider get typeProvider => throw UnsupportedError(
+    'RuleContext with parsed results does not include a TypeProvider',
+  );
 
   @override
-  TypeSystem get typeSystem =>
-      throw UnsupportedError(
-        'RuleContext with parsed results does not include a TypeSystem',
-      );
+  TypeSystem get typeSystem => throw UnsupportedError(
+    'RuleContext with parsed results does not include a TypeSystem',
+  );
 
   @override
-  bool isFeatureEnabled(Feature feature) =>
-      throw UnsupportedError(
-        'RuleContext with parsed results does not include a LibraryElement',
-      );
+  bool isFeatureEnabled(Feature feature) => throw UnsupportedError(
+    'RuleContext with parsed results does not include a LibraryElement',
+  );
 }
 
 /// A [RuleContext] for a library, resolved into [ResolvedUnitResult]s.

pkg/analyzer/lib/src/clients/dart_style/rewrite_cascade.dart

@@ -15,15 +15,13 @@ ExpressionStatement fixCascadeByParenthesizingTarget({
   assert(cascadeExpression.cascadeSections.length == 1);
 
   var newTarget = ParenthesizedExpressionImpl(
-    leftParenthesis:
-        Token(TokenType.OPEN_PAREN, 0)
-          ..previous = expressionStatement.beginToken.previous
-          ..next = cascadeExpression.target.beginToken,
+    leftParenthesis: Token(TokenType.OPEN_PAREN, 0)
+      ..previous = expressionStatement.beginToken.previous
+      ..next = cascadeExpression.target.beginToken,
     expression: cascadeExpression.target,
-    rightParenthesis:
-        Token(TokenType.CLOSE_PAREN, 0)
-          ..previous = cascadeExpression.target.endToken
-          ..next = expressionStatement.semicolon,
+    rightParenthesis: Token(TokenType.CLOSE_PAREN, 0)
+      ..previous = cascadeExpression.target.endToken
+      ..next = expressionStatement.semicolon,
   );
 
   return ExpressionStatementImpl(
@@ -86,10 +84,9 @@ ExpressionImpl insertCascadeTargetIntoExpression({
         cascadeTarget: cascadeTarget,
       ),
       // If we've reached the end, replace the `..` operator with `.`
-      operator:
-          expressionTarget == cascadeTarget
-              ? _synthesizeToken(TokenType.PERIOD, expression.operator!)
-              : expression.operator,
+      operator: expressionTarget == cascadeTarget
+          ? _synthesizeToken(TokenType.PERIOD, expression.operator!)
+          : expression.operator,
       methodName: expression.methodName,
       typeArguments: expression.typeArguments,
       argumentList: expression.argumentList,
@@ -102,10 +99,9 @@ ExpressionImpl insertCascadeTargetIntoExpression({
         cascadeTarget: cascadeTarget,
       ),
       // If we've reached the end, replace the `..` operator with `.`
-      operator:
-          expressionTarget == cascadeTarget
-              ? _synthesizeToken(TokenType.PERIOD, expression.operator)
-              : expression.operator,
+      operator: expressionTarget == cascadeTarget
+          ? _synthesizeToken(TokenType.PERIOD, expression.operator)
+          : expression.operator,
       propertyName: expression.propertyName,
     );
   }