[messages] Move non-shared errors out of pkg/_fe_analyzer_shared.

Changes `pkg/front_end/tool/generate_messages_lib.dart` so that only
shared and "pseudoShared" messages are generated to
`pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart`. The
remaining front end messages are generated to
`pkg/front_end/lib/src/codes/cfe_codes_generated.dart`.

Previously, a heuristic was used to try to guess which messages
*might* be sharable, which resulted in a lot of messages being put in
`pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart` that
were not actually shared.

This change paves the way for sharing more messages between the
analyzer and CFE, by making it clear which messages are shared and
which ones aren't.

A few import statements had to be adjusted as part of this change, to
account for the fact that a lot of generated code was moved.

Change-Id: I6a6a69641fdc79dcf92f25c980c5a0de9196be4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449608
Reviewed-by: Ömer Ağacan <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/_fe_analyzer_shared/lib/src/messages/codes.dart

@@ -15,7 +15,6 @@ import 'severity.dart' show CfeSeverity;
 import '../util/relativize.dart' as util show isWindows, relativizeUri;
 
 import 'conversions.dart' as conversions;
-import 'codes.dart' as conversions show relativizeUri;
 
 part 'codes_generated.dart';
 

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -4,15 +4,15 @@
 
 // ignore_for_file: implementation_imports
 
-import 'package:_fe_analyzer_shared/src/messages/codes.dart'
+import 'package:_js_interop_checks/js_interop_checks.dart'
+    show JsInteropDiagnosticReporter;
+import 'package:_js_interop_checks/src/js_interop.dart' as js_interop;
+import 'package:front_end/src/codes/cfe_codes.dart'
     show
         codeJsInteropExportDartInterfaceHasNonEmptyJSExportValue,
         codeJsInteropExportDisallowedMember,
         codeJsInteropExportMemberCollision,
         codeJsInteropExportNoExportableMembers;
-import 'package:_js_interop_checks/js_interop_checks.dart'
-    show JsInteropDiagnosticReporter;
-import 'package:_js_interop_checks/src/js_interop.dart' as js_interop;
 import 'package:kernel/ast.dart';
 
 enum ExportStatus { exportError, exportable, nonExportable }

pkg/_js_interop_checks/lib/src/transformations/export_checker.dart

@@ -3,14 +3,16 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:_fe_analyzer_shared/src/messages/codes.dart'
-    show Message, LocatedMessage, codeWasmImportOrExportInUserCode;
+    show Message, LocatedMessage;
 import 'package:_js_interop_checks/js_interop_checks.dart';
 import 'package:_js_interop_checks/src/js_interop.dart' as jsInteropHelper;
 import 'package:_js_interop_checks/src/transformations/shared_interop_transformer.dart';
 import 'package:front_end/src/api_prototype/const_conditional_simplifier.dart'
     show ConstConditionalSimplifier;
 import 'package:front_end/src/api_prototype/constant_evaluator.dart'
     as constantEvaluator show ConstantEvaluator;
+import 'package:front_end/src/codes/cfe_codes.dart'
+    show codeWasmImportOrExportInUserCode;
 import 'package:kernel/ast.dart';
 import 'package:kernel/class_hierarchy.dart';
 import 'package:kernel/clone.dart';

pkg/dart2wasm/lib/target.dart

@@ -7,10 +7,10 @@ library front_end.kernel_generator;
 
 import 'dart:typed_data';
 
-import 'package:_fe_analyzer_shared/src/messages/codes.dart'
-    show codeMissingMain, noLength;
+import 'package:_fe_analyzer_shared/src/messages/codes.dart' show noLength;
 import 'package:_fe_analyzer_shared/src/messages/severity.dart'
     show CfeSeverity;
+import 'package:front_end/src/codes/cfe_codes.dart' show codeMissingMain;
 import 'package:kernel/ast.dart' show Component;
 import 'package:kernel/class_hierarchy.dart' show ClassHierarchy;
 import 'package:kernel/core_types.dart' show CoreTypes;

pkg/front_end/lib/src/api_prototype/kernel_generator.dart

@@ -2,12 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:_fe_analyzer_shared/src/messages/codes.dart'
-    show codeMissingMain;
 import 'package:_fe_analyzer_shared/src/messages/diagnostic_message.dart'
     show DiagnosticMessageHandler;
 import 'package:_fe_analyzer_shared/src/messages/severity.dart'
     show CfeSeverity;
+import 'package:front_end/src/codes/cfe_codes.dart' show codeMissingMain;
 import 'package:kernel/kernel.dart' show Component;
 import 'package:kernel/target/targets.dart' show Target;
 

pkg/front_end/lib/src/api_unstable/dart2js.dart

@@ -4,10 +4,14 @@
 
 import 'package:_fe_analyzer_shared/src/messages/codes.dart';
 import 'package:_fe_analyzer_shared/src/messages/severity.dart';
+import 'package:_fe_analyzer_shared/src/scanner/token.dart' show Token;
 import 'package:kernel/ast.dart' show Constant, DartType;
 
 import 'package:_fe_analyzer_shared/src/messages/conversions.dart'
     as conversions;
+import 'package:_fe_analyzer_shared/src/messages/codes.dart'
+    as conversions
+    show relativizeUri;
 import 'type_labeler.dart';
 
 export 'package:_fe_analyzer_shared/src/messages/codes.dart';