Elements. Deprecate InterfaceTypeImpl.element

Change-Id: Iff7d90a8d614a6069ec7f13810c8bd6600cfcc1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/418919
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/api.txt

@@ -3080,7 +3080,7 @@ package:analyzer/dart/element/element.dart:
     new (constructor: DirectiveUri Function())
   DirectiveUriWithLibrary (class extends DirectiveUriWithSource):
     new (constructor: DirectiveUriWithLibrary Function())
-    library (getter: LibraryElement)
+    library (getter: LibraryElement, deprecated)
     library2 (getter: LibraryElement2)
   DirectiveUriWithRelativeUri (class extends DirectiveUriWithRelativeUriString):
     new (constructor: DirectiveUriWithRelativeUri Function())
@@ -3097,7 +3097,7 @@ package:analyzer/dart/element/element.dart:
     unit (getter: CompilationUnitElement, deprecated)
   Element (class extends Object implements AnalysisTarget):
     new (constructor: Element Function())
-    children (getter: List<Element>)
+    children (getter: List<Element>, deprecated)
     context (getter: AnalysisContext@2)
     declaration (getter: Element?)
     displayName (getter: String)
@@ -3135,7 +3135,7 @@ package:analyzer/dart/element/element.dart:
     isPublic (getter: bool)
     isSynthetic (getter: bool)
     kind (getter: ElementKind)
-    library (getter: LibraryElement?)
+    library (getter: LibraryElement?, deprecated)
     location (getter: ElementLocation?)
     metadata (getter: List<ElementAnnotation>)
     name (getter: String?)
@@ -3148,7 +3148,7 @@ package:analyzer/dart/element/element.dart:
     accept (method: T? Function<T>(ElementVisitor<T>), deprecated)
     getDisplayString (method: String Function({bool multiline, bool withNullability}))
     getExtendedDisplayName (method: String Function(String?))
-    isAccessibleIn (method: bool Function(LibraryElement))
+    isAccessibleIn (method: bool Function(LibraryElement), deprecated)
     thisOrAncestorMatching (method: E? Function<E extends Element>(bool Function(Element)), deprecated)
     thisOrAncestorMatching3 (method: E? Function<E extends Element>(bool Function(Element)), deprecated)
     thisOrAncestorOfType (method: E? Function<E extends Element>(), deprecated)
@@ -3369,7 +3369,7 @@ package:analyzer/dart/element/element.dart:
     new (constructor: LabelElement Function())
     enclosingElement3 (getter: ExecutableElement, deprecated)
     name (getter: String)
-  LibraryElement (class extends Object implements _ExistingElement):
+  LibraryElement (class extends Object implements _ExistingElement, deprecated):
     new (constructor: LibraryElement Function())
     definingCompilationUnit (getter: CompilationUnitElement, deprecated)
     enclosingElement3 (getter: Null)
@@ -3520,7 +3520,7 @@ package:analyzer/dart/element/element.dart:
     new (constructor: TypeParameterizedElement Function())
     isSimplyBounded (getter: bool)
     typeParameters (getter: List<TypeParameterElement>, deprecated)
-  UndefinedElement (class extends Object implements Element):
+  UndefinedElement (class extends Object implements Element, deprecated):
     new (constructor: UndefinedElement Function())
   UriReferencedElement (class extends Object implements _ExistingElement):
     new (constructor: UriReferencedElement Function())
@@ -3541,7 +3541,7 @@ package:analyzer/dart/element/element.dart:
   _ExistingElement (class extends Object implements Element):
     new (constructor: _ExistingElement Function())
     declaration (getter: Element)
-    library (getter: LibraryElement)
+    library (getter: LibraryElement, deprecated)
     librarySource (getter: Source)
     source (getter: Source)
 package:analyzer/dart/element/element2.dart:
@@ -5260,7 +5260,7 @@ package:analyzer/src/dart/constant/evaluation.dart:
     new (constructor: ConstantEvaluationTarget Function())
     context (getter: AnalysisContext@2)
     isConstantEvaluated (getter: bool)
-    library (getter: LibraryElement?)
+    library (getter: LibraryElement?, deprecated)
     library2 (getter: LibraryElement2?)
 package:analyzer/src/dart/resolver/scope.dart:
   Namespace (class extends Object):

pkg/analyzer/lib/dart/element/element.dart

@@ -22,6 +22,7 @@
 /// children of the element representing the class.
 ///
 /// Every complete element structure is rooted by an instance of the class
+// ignore:deprecated_member_use_from_same_package
 /// [LibraryElement]. A library element represents a single Dart library. Every
 /// library is defined by one or more compilation units (the library and all of
 /// its parts). The compilation units are represented by the class
@@ -338,11 +339,12 @@ abstract class DeferredImportElementPrefix implements ImportElementPrefix {}
 /// Clients may not extend, implement or mix-in this class.
 abstract class DirectiveUri {}
 
-/// [DirectiveUriWithSource] that references a [LibraryElement].
+/// [DirectiveUriWithSource] that references a [LibraryElement2].
 ///
 /// Clients may not extend, implement or mix-in this class.
 abstract class DirectiveUriWithLibrary extends DirectiveUriWithSource {
   /// The library referenced by the [source].
+  @Deprecated('Use library2 instead')
   LibraryElement get library;
 
   /// The library referenced by the [source].
@@ -414,6 +416,7 @@ abstract class Element implements AnalysisTarget {
   /// A list of this element's children.
   ///
   /// There is no guarantee of the order in which the children will be included.
+  @Deprecated('Use Element2 instead')
   List<Element> get children;
 
   /// The analysis context in which this element is defined.
@@ -566,6 +569,7 @@ abstract class Element implements AnalysisTarget {
   /// This will be the element itself if it is a library element. This will be
   /// `null` if this element is [MultiplyDefinedElement2] that is not contained
   /// in a library.
+  @Deprecated('Use Element2 instead')
   LibraryElement? get library;
 
   /// The location of this element in the element model.
@@ -668,6 +672,7 @@ abstract class Element implements AnalysisTarget {
   /// A declaration <i>m</i> is accessible to a library <i>L</i> if <i>m</i> is
   /// declared in <i>L</i> or if <i>m</i> is public.
   /// </blockquote>
+  @Deprecated('Use Element2 instead')
   bool isAccessibleIn(LibraryElement library);
 
   /// Returns either this element or the most immediate ancestor of this element
@@ -1648,6 +1653,7 @@ abstract class LabelElement implements Element {
 /// A library.
 ///
 /// Clients may not extend, implement or mix-in this class.
+@Deprecated('Use LibraryElement2 instead')
 abstract class LibraryElement implements _ExistingElement {
   /// The compilation unit that defines this library.
   @Deprecated(elementModelDeprecationMsg)
@@ -2304,6 +2310,7 @@ abstract class TypeParameterizedElement implements _ExistingElement {
 /// elements do not make sense and will return useless results.
 ///
 /// Clients may not extend, implement or mix-in this class.
+@Deprecated('Not used anymore')
 abstract class UndefinedElement implements Element {}
 
 /// An element included into a library using some URI.
@@ -2382,6 +2389,7 @@ abstract class _ExistingElement implements Element {
   @override
   Element get declaration;
 
+  @Deprecated('Use Element2 instead')
   @override
   LibraryElement get library;
 

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: analyzer_use_new_elements
-
 import 'dart:collection';
 
 import 'package:_fe_analyzer_shared/src/base/analyzer_public_api.dart';
@@ -535,6 +533,7 @@ abstract class ConstantEvaluationTarget extends AnalysisTarget {
   bool get isConstantEvaluated;
 
   /// The library with this constant.
+  @Deprecated('Use library2 instead')
   LibraryElement? get library;
 
   /// The library with this constant.
@@ -3171,7 +3170,7 @@ class _InstanceCreationEvaluator {
     var superclass = definingType.superclass;
     if (superclass != null && !superclass.isDartCoreObject) {
       var superConstructor = superclass
-          .lookUpConstructor2(superName, _constructor.library.asElement2)
+          .lookUpConstructor2(superName, _constructor.library)
           ?.asElement;
       if (superConstructor == null) {
         return null;