Start renaming the DartFixKind constants

The two typedefs are because those two fix kinds are used internally.

Change-Id: I4124bcb0c4def4339cefc4add47d4e309f3d9588
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/453403
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: bwilkerson

pkg/analysis_server/lib/src/services/correction/dart/add_async.dart

@@ -32,7 +32,7 @@ class AddAsync extends ResolvedCorrectionProducer {
       CorrectionApplicability.singleLocation;
 
   @override
-  FixKind get fixKind => DartFixKind.ADD_ASYNC;
+  FixKind get fixKind => DartFixKind.addAsync;
 
   @override
   Future<void> compute(ChangeBuilder builder) async {

pkg/analysis_server/lib/src/services/correction/dart/add_await.dart

@@ -35,7 +35,7 @@ class AddAwait extends ResolvedCorrectionProducer {
       CorrectionApplicability.singleLocation;
 
   @override
-  FixKind get fixKind => DartFixKind.ADD_AWAIT;
+  FixKind get fixKind => DartFixKind.addAwait;
 
   FunctionBody? get _functionBodyIfNotAsync {
     var body = node.thisOrAncestorOfType<FunctionBody>();

pkg/analysis_server/lib/src/services/correction/dart/add_call_super.dart

@@ -24,7 +24,7 @@ class AddCallSuper extends ResolvedCorrectionProducer {
   List<String> get fixArguments => [_addition];
 
   @override
-  FixKind get fixKind => DartFixKind.ADD_CALL_SUPER;
+  FixKind get fixKind => DartFixKind.addCallSuper;
 
   @override
   Future<void> compute(ChangeBuilder builder) async {

pkg/analysis_server/lib/src/services/correction/dart/add_class_modifier.dart

@@ -21,22 +21,22 @@ class AddClassModifier extends ResolvedCorrectionProducer {
     : this._(
         context: context,
         modifier: 'base',
-        fixKind: DartFixKind.ADD_CLASS_MODIFIER_BASE,
-        multiFixKind: DartFixKind.ADD_CLASS_MODIFIER_BASE_MULTI,
+        fixKind: DartFixKind.addClassModifierBase,
+        multiFixKind: DartFixKind.addClassModifierBaseMulti,
       );
   AddClassModifier.finalModifier({required CorrectionProducerContext context})
     : this._(
         context: context,
         modifier: 'final',
-        fixKind: DartFixKind.ADD_CLASS_MODIFIER_FINAL,
-        multiFixKind: DartFixKind.ADD_CLASS_MODIFIER_FINAL_MULTI,
+        fixKind: DartFixKind.addClassModifierFinal,
+        multiFixKind: DartFixKind.addClassModifierFinalMulti,
       );
   AddClassModifier.sealedModifier({required CorrectionProducerContext context})
     : this._(
         context: context,
         modifier: 'sealed',
-        fixKind: DartFixKind.ADD_CLASS_MODIFIER_SEALED,
-        multiFixKind: DartFixKind.ADD_CLASS_MODIFIER_SEALED_MULTI,
+        fixKind: DartFixKind.addClassModifierSealed,
+        multiFixKind: DartFixKind.addClassModifierSealedMulti,
       );
 
   AddClassModifier._({

pkg/analysis_server/lib/src/services/correction/dart/add_const.dart

@@ -24,10 +24,10 @@ class AddConst extends ResolvedCorrectionProducer {
       CorrectionApplicability.automatically;
 
   @override
-  FixKind get fixKind => DartFixKind.ADD_CONST;
+  FixKind get fixKind => DartFixKind.addConst;
 
   @override
-  FixKind get multiFixKind => DartFixKind.ADD_CONST_MULTI;
+  FixKind get multiFixKind => DartFixKind.addConstMulti;
 
   @override
   Future<void> compute(ChangeBuilder builder) async {

pkg/analysis_server/lib/src/services/correction/dart/add_diagnostic_property_reference.dart

@@ -29,11 +29,10 @@ class AddDiagnosticPropertyReference extends ResolvedCorrectionProducer {
   AssistKind get assistKind => DartAssistKind.addDiagnosticPropertyReference;
 
   @override
-  FixKind get fixKind => DartFixKind.ADD_DIAGNOSTIC_PROPERTY_REFERENCE;
+  FixKind get fixKind => DartFixKind.addDiagnosticPropertyReference;
 
   @override
-  FixKind get multiFixKind =>
-      DartFixKind.ADD_DIAGNOSTIC_PROPERTY_REFERENCE_MULTI;
+  FixKind get multiFixKind => DartFixKind.addDiagnosticPropertyReferenceMulti;
 
   @override
   Future<void> compute(ChangeBuilder builder) async {

pkg/analysis_server/lib/src/services/correction/dart/add_empty_argument_list.dart

@@ -16,10 +16,10 @@ class AddEmptyArgumentList extends ResolvedCorrectionProducer {
       CorrectionApplicability.automatically;
 
   @override
-  FixKind get fixKind => DartFixKind.ADD_EMPTY_ARGUMENT_LIST;
+  FixKind get fixKind => DartFixKind.addEmptyArgumentList;
 
   @override
-  FixKind get multiFixKind => DartFixKind.ADD_EMPTY_ARGUMENT_LIST_MULTI;
+  FixKind get multiFixKind => DartFixKind.addEmptyArgumentListMulti;
 
   @override
   Future<void> compute(ChangeBuilder builder) async {

pkg/analysis_server/lib/src/services/correction/dart/add_enum_constant.dart

@@ -25,7 +25,7 @@ class AddEnumConstant extends ResolvedCorrectionProducer {
   List<String> get fixArguments => [_constantName];
 
   @override
-  FixKind get fixKind => DartFixKind.ADD_ENUM_CONSTANT;
+  FixKind get fixKind => DartFixKind.addEnumConstant;
 
   @override
   Future<void> compute(ChangeBuilder builder) async {

pkg/analysis_server/lib/src/services/correction/dart/add_eol_at_end_of_file.dart

@@ -18,7 +18,7 @@ class AddEolAtEndOfFile extends ResolvedCorrectionProducer {
       CorrectionApplicability.singleLocation;
 
   @override
-  FixKind get fixKind => DartFixKind.ADD_EOL_AT_END_OF_FILE;
+  FixKind get fixKind => DartFixKind.addEolAtEndOfFile;
 
   @override
   Future<void> compute(ChangeBuilder builder) async {

pkg/analysis_server/lib/src/services/correction/dart/add_explicit_call.dart

@@ -18,10 +18,10 @@ class AddExplicitCall extends ResolvedCorrectionProducer {
       CorrectionApplicability.automatically;
 
   @override
-  FixKind get fixKind => DartFixKind.ADD_EXPLICIT_CALL;
+  FixKind get fixKind => DartFixKind.addExplicitCall;
 
   @override
-  FixKind get multiFixKind => DartFixKind.ADD_EXPLICIT_CALL_MULTI;
+  FixKind get multiFixKind => DartFixKind.addExplicitCallMulti;
 
   @override
   Future<void> compute(ChangeBuilder builder) async {