[linter] Dot shorthands: Update do_not_use_environment lint.

Adds an extra case for `DotShorthandConstructorInvocation`s so that the lint fires on `.hasEnvironment(...)` and `.fromEnvironment(...)`.

Tests added and passing.

Fixes: #60903
Bug: #60893
Change-Id: I9e85c766c0009cb7a2807ce3b32d802dd47550fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434480
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/linter/lib/src/rules/do_not_use_environment.dart

@@ -5,6 +5,7 @@
 import 'package:analyzer/analysis_rule/rule_context.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
+import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';
@@ -21,6 +22,7 @@ class DoNotUseEnvironment extends LintRule {
   @override
   void registerNodeProcessors(NodeLintRegistry registry, RuleContext context) {
     var visitor = _Visitor(this);
+    registry.addDotShorthandConstructorInvocation(this, visitor);
     registry.addInstanceCreationExpression(this, visitor);
   }
 }
@@ -30,6 +32,32 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   _Visitor(this.rule);
 
+  void reportIfUsingEnvironment(
+    AstNode node,
+    String constructorName,
+    DartType staticType,
+  ) {
+    if (((staticType.isDartCoreBool ||
+                staticType.isDartCoreInt ||
+                staticType.isDartCoreString) &&
+            constructorName == 'fromEnvironment') ||
+        (staticType.isDartCoreBool && constructorName == 'hasEnvironment')) {
+      rule.reportAtNode(node);
+    }
+  }
+
+  @override
+  void visitDotShorthandConstructorInvocation(
+    DotShorthandConstructorInvocation node,
+  ) {
+    var nameNode = node.constructorName;
+    var staticType = node.staticType;
+    if (staticType == null) {
+      return;
+    }
+    reportIfUsingEnvironment(nameNode, nameNode.name, staticType);
+  }
+
   @override
   void visitInstanceCreationExpression(InstanceCreationExpression node) {
     var constructorNameNode = node.constructorName;
@@ -44,13 +72,6 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (constructorName == null) {
       return;
     }
-
-    if (((staticType.isDartCoreBool ||
-                staticType.isDartCoreInt ||
-                staticType.isDartCoreString) &&
-            constructorName == 'fromEnvironment') ||
-        (staticType.isDartCoreBool && constructorName == 'hasEnvironment')) {
-      rule.reportAtNode(constructorNameNode);
-    }
+    reportIfUsingEnvironment(constructorNameNode, constructorName, staticType);
   }
 }

pkg/linter/test/rules/do_not_use_environment_test.dart

@@ -27,6 +27,28 @@ void f() {
     );
   }
 
+  test_dotShorthand_fromEnvironment() async {
+    await assertDiagnostics(
+      r'''
+void f() {
+  bool x = .fromEnvironment('key');
+}
+''',
+      [lint(23, 15)],
+    );
+  }
+
+  test_dotShorthand_hasEnvironment() async {
+    await assertDiagnostics(
+      r'''
+void f() {
+  bool x = .hasEnvironment('key');
+}
+''',
+      [lint(23, 14)],
+    );
+  }
+
   test_hasEnvironment() async {
     await assertDiagnostics(
       r'''