[analyzer] Change ErrorCodeInfo.toAnalyzerCode to accept ErrorClassInfo.

Previously, `ErrorCodeInfo.toAnalyzerCode` didn't know anything about
the error class it was generating an analyzer code for, other than the
class name (which was passed in via a `className` parameter). Changing
this parameter to an `ErrorClassInfo` type paves the way for a
follow-up CL in which I plan to generalize
`ErrorCodeInfo.toAnalyzerCode` so that it can generate analyzer error
codes that support `.withArguments()` (similar to how CFE error
formatting works).

To make this work, I had to create an instance of `ErrorClassInfo` in
`generate_lints.dart`, to represent the linter class `LinterLintCode`.

Change-Id: I160e27a46602da13f4757393fdaad4bc2f15d50e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442165
Auto-Submit: Paul Berry <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: stereotype441

pkg/analyzer/tool/messages/error_code_info.dart

@@ -602,14 +602,14 @@ abstract class ErrorCodeInfo {
   ///
   /// [diagnosticCode] is the name of the error code to be generated.
   String toAnalyzerCode(
-    String className,
+    ErrorClassInfo errorClassInfo,
     String diagnosticCode, {
     String? sharedNameReference,
     required bool useExplicitConst,
   }) {
     var out = StringBuffer();
     if (useExplicitConst) out.writeln('const ');
-    out.writeln('$className(');
+    out.writeln('${errorClassInfo.name}(');
     out.writeln(
       '${sharedNameReference ?? "'${sharedName ?? diagnosticCode}'"},',
     );

pkg/analyzer/tool/messages/generate.dart

@@ -158,7 +158,7 @@ library;
           out.writeln('  static const ${errorClass.name} $errorName =');
           out.writeln(
             errorCodeInfo.toAnalyzerCode(
-              errorClass.name,
+              errorClass,
               errorName,
               useExplicitConst: file.shouldUseExplicitConst,
             ),

pkg/linter/tool/generate_lints.dart

@@ -23,6 +23,17 @@ const String generatedCodesPath = 'linter/lib/src/lint_codes.g.dart';
 
 const String generatedNamesPath = 'linter/lib/src/lint_names.g.dart';
 
+const lintCodesFile = GeneratedErrorCodeFile(
+  path: generatedCodesPath,
+  preferredImportUri: 'package:linter/src/lint_codes.dart',
+);
+
+const linterLintCodeInfo = ErrorClassInfo(
+  file: lintCodesFile,
+  name: 'LinterLintCode',
+  type: 'LINT',
+);
+
 GeneratedFile get generatedCodesFile =>
     GeneratedFile(generatedCodesPath, (pkgRoot) async {
       var out = StringBuffer('''
@@ -61,7 +72,7 @@ class LinterLintCode extends LintCode {
         out.writeln('  static const LintCode $errorName =');
         out.writeln(
           codeInfo.toAnalyzerCode(
-            'LinterLintCode',
+            linterLintCodeInfo,
             errorName,
             sharedNameReference: 'LintNames.$lintName',
             useExplicitConst: false,