[cfe] Mark super initializing parameters erroneous due initializers

chloestefantsova · Commit Queue · commit 4e9d539c0d39 · 2025-06-04T01:18:21.000-07:00
Change-Id: I7cf43027a9058f64f41331c9f0b9f9529651d48d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432341 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
diff --git a/pkg/front_end/lib/src/kernel/kernel_helper.dart b/pkg/front_end/lib/src/kernel/kernel_helper.dart
@@ -271,6 +271,7 @@ class DelayedDefaultValueCloner {
             synthesizedParameter.fileOffset,
             synthesizedParameter.name?.length ?? 1,
             _libraryBuilder.fileUri);
+        synthesizedParameter.isErroneouslyInitialized = true;
       }
     }
   }
diff --git a/pkg/front_end/testcases/super_parameters/default_values.dart.strong.expect b/pkg/front_end/testcases/super_parameters/default_values.dart.strong.expect
@@ -84,7 +84,7 @@ class S5 extends core::Object {
     ;
 }
 class C5 extends self::S5 {
-  constructor •([core::int x = #C4]) → self::C5
+  constructor •([erroneously-initialized core::int x = #C4]) → self::C5
     : super self::S5::•(x)
     ;
 }
@@ -101,7 +101,7 @@ class C6 extends self::S6 {
     ;
 }
 class D6 extends self::C6 {
-  constructor •([core::int x = #C4]) → self::D6
+  constructor •([erroneously-initialized core::int x = #C4]) → self::D6
     : super self::C6::•(x)
     ;
 }
@@ -166,7 +166,7 @@ class S5b extends core::Object {
     ;
 }
 class C5b extends self::S5b {
-  constructor •({core::int x = #C4}) → self::C5b
+  constructor •({erroneously-initialized core::int x = #C4}) → self::C5b
     : super self::S5b::•(x: x)
     ;
 }
@@ -183,7 +183,7 @@ class C6b extends self::S6b {
     ;
 }
 class D6b extends self::C6b {
-  constructor •({core::int x = #C4}) → self::D6b
+  constructor •({erroneously-initialized core::int x = #C4}) → self::D6b
     : super self::C6b::•(x: x)
     ;
 }
@@ -247,7 +247,7 @@ class Ap extends core::Object {
     ;
 }
 class Bp extends self::Ap {
-  constructor •([core::int x = #C4]) → self::Bp
+  constructor •([erroneously-initialized core::int x = #C4]) → self::Bp
     : super self::Ap::•(x)
     ;
   constructor req(core::int x) → self::Bp
@@ -260,7 +260,7 @@ class An extends core::Object {
     ;
 }
 class Bn extends self::An {
-  constructor •({core::int x = #C4}) → self::Bn
+  constructor •({erroneously-initialized core::int x = #C4}) → self::Bn
     : super self::An::•(x: x)
     ;
   constructor req({required core::int x}) → self::Bn
diff --git a/pkg/front_end/testcases/super_parameters/default_values.dart.strong.modular.expect b/pkg/front_end/testcases/super_parameters/default_values.dart.strong.modular.expect
@@ -84,7 +84,7 @@ class S5 extends core::Object {
     ;
 }
 class C5 extends self::S5 {
-  constructor •([core::int x = #C4]) → self::C5
+  constructor •([erroneously-initialized core::int x = #C4]) → self::C5
     : super self::S5::•(x)
     ;
 }
@@ -101,7 +101,7 @@ class C6 extends self::S6 {
     ;
 }
 class D6 extends self::C6 {
-  constructor •([core::int x = #C4]) → self::D6
+  constructor •([erroneously-initialized core::int x = #C4]) → self::D6
     : super self::C6::•(x)
     ;
 }
@@ -166,7 +166,7 @@ class S5b extends core::Object {
     ;
 }
 class C5b extends self::S5b {
-  constructor •({core::int x = #C4}) → self::C5b
+  constructor •({erroneously-initialized core::int x = #C4}) → self::C5b
     : super self::S5b::•(x: x)
     ;
 }
@@ -183,7 +183,7 @@ class C6b extends self::S6b {
     ;
 }
 class D6b extends self::C6b {
-  constructor •({core::int x = #C4}) → self::D6b
+  constructor •({erroneously-initialized core::int x = #C4}) → self::D6b
     : super self::C6b::•(x: x)
     ;
 }
@@ -247,7 +247,7 @@ class Ap extends core::Object {
     ;
 }
 class Bp extends self::Ap {
-  constructor •([core::int x = #C4]) → self::Bp
+  constructor •([erroneously-initialized core::int x = #C4]) → self::Bp
     : super self::Ap::•(x)
     ;
   constructor req(core::int x) → self::Bp
@@ -260,7 +260,7 @@ class An extends core::Object {
     ;
 }
 class Bn extends self::An {
-  constructor •({core::int x = #C4}) → self::Bn
+  constructor •({erroneously-initialized core::int x = #C4}) → self::Bn
     : super self::An::•(x: x)
     ;
   constructor req({required core::int x}) → self::Bn
diff --git a/pkg/front_end/testcases/super_parameters/default_values.dart.strong.outline.expect b/pkg/front_end/testcases/super_parameters/default_values.dart.strong.outline.expect
@@ -75,7 +75,7 @@ class S5 extends core::Object {
     ;
 }
 class C5 extends self::S5 {
-  constructor •([core::int x = null]) → self::C5
+  constructor •([erroneously-initialized core::int x = null]) → self::C5
     ;
 }
 class S6 extends core::Object {
@@ -89,7 +89,7 @@ class C6 extends self::S6 {
     ;
 }
 class D6 extends self::C6 {
-  constructor •([core::int x = null]) → self::D6
+  constructor •([erroneously-initialized core::int x = null]) → self::D6
     ;
 }
 class S7 extends core::Object {
@@ -143,7 +143,7 @@ class S5b extends core::Object {
     ;
 }
 class C5b extends self::S5b {
-  constructor •({core::int x = null}) → self::C5b
+  constructor •({erroneously-initialized core::int x = null}) → self::C5b
     ;
 }
 class S6b extends core::Object {
@@ -157,7 +157,7 @@ class C6b extends self::S6b {
     ;
 }
 class D6b extends self::C6b {
-  constructor •({core::int x = null}) → self::D6b
+  constructor •({erroneously-initialized core::int x = null}) → self::D6b
     ;
 }
 class S7b extends core::Object {
@@ -213,7 +213,7 @@ class Ap extends core::Object {
     ;
 }
 class Bp extends self::Ap {
-  constructor •([core::int x = null]) → self::Bp
+  constructor •([erroneously-initialized core::int x = null]) → self::Bp
     ;
   constructor req(core::int x) → self::Bp
     ;
@@ -223,7 +223,7 @@ class An extends core::Object {
     ;
 }
 class Bn extends self::An {
-  constructor •({core::int x = null}) → self::Bn
+  constructor •({erroneously-initialized core::int x = null}) → self::Bn
     ;
   constructor req({required core::int x}) → self::Bn
     ;
diff --git a/pkg/front_end/testcases/super_parameters/default_values.dart.strong.transformed.expect b/pkg/front_end/testcases/super_parameters/default_values.dart.strong.transformed.expect
@@ -84,7 +84,7 @@ class S5 extends core::Object {
     ;
 }
 class C5 extends self::S5 {
-  constructor •([core::int x = #C4]) → self::C5
+  constructor •([erroneously-initialized core::int x = #C4]) → self::C5
     : super self::S5::•(x)
     ;
 }
@@ -101,7 +101,7 @@ class C6 extends self::S6 {
     ;
 }
 class D6 extends self::C6 {
-  constructor •([core::int x = #C4]) → self::D6
+  constructor •([erroneously-initialized core::int x = #C4]) → self::D6
     : super self::C6::•(x)
     ;
 }
@@ -166,7 +166,7 @@ class S5b extends core::Object {
     ;
 }
 class C5b extends self::S5b {
-  constructor •({core::int x = #C4}) → self::C5b
+  constructor •({erroneously-initialized core::int x = #C4}) → self::C5b
     : super self::S5b::•(x: x)
     ;
 }
@@ -183,7 +183,7 @@ class C6b extends self::S6b {
     ;
 }
 class D6b extends self::C6b {
-  constructor •({core::int x = #C4}) → self::D6b
+  constructor •({erroneously-initialized core::int x = #C4}) → self::D6b
     : super self::C6b::•(x: x)
     ;
 }
@@ -247,7 +247,7 @@ class Ap extends core::Object {
     ;
 }
 class Bp extends self::Ap {
-  constructor •([core::int x = #C4]) → self::Bp
+  constructor •([erroneously-initialized core::int x = #C4]) → self::Bp
     : super self::Ap::•(x)
     ;
   constructor req(core::int x) → self::Bp
@@ -260,7 +260,7 @@ class An extends core::Object {
     ;
 }
 class Bn extends self::An {
-  constructor •({core::int x = #C4}) → self::Bn
+  constructor •({erroneously-initialized core::int x = #C4}) → self::Bn
     : super self::An::•(x: x)
     ;
   constructor req({required core::int x}) → self::Bn

Original file line number	Diff line number	Diff line change
`@@ -271,6 +271,7 @@ class DelayedDefaultValueCloner {`
`271`	`271`	`synthesizedParameter.fileOffset,`
`272`	`272`	`synthesizedParameter.name?.length ?? 1,`
`273`	`273`	`_libraryBuilder.fileUri);`
	`274`	`+ synthesizedParameter.isErroneouslyInitialized = true;`
`274`	`275`	`}`
`275`	`276`	`}`
`276`	`277`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ class S5 extends core::Object {`
`84`	`84`	`;`
`85`	`85`	`}`
`86`	`86`	`class C5 extends self::S5 {`
`87`		`- constructor •([core::int x = #C4]) → self::C5`
	`87`	`+ constructor •([erroneously-initialized core::int x = #C4]) → self::C5`
`88`	`88`	`: super self::S5::•(x)`
`89`	`89`	`;`
`90`	`90`	`}`
`@@ -101,7 +101,7 @@ class C6 extends self::S6 {`
`101`	`101`	`;`
`102`	`102`	`}`
`103`	`103`	`class D6 extends self::C6 {`
`104`		`- constructor •([core::int x = #C4]) → self::D6`
	`104`	`+ constructor •([erroneously-initialized core::int x = #C4]) → self::D6`
`105`	`105`	`: super self::C6::•(x)`
`106`	`106`	`;`
`107`	`107`	`}`
`@@ -166,7 +166,7 @@ class S5b extends core::Object {`
`166`	`166`	`;`
`167`	`167`	`}`
`168`	`168`	`class C5b extends self::S5b {`
`169`		`- constructor •({core::int x = #C4}) → self::C5b`
	`169`	`+ constructor •({erroneously-initialized core::int x = #C4}) → self::C5b`
`170`	`170`	`: super self::S5b::•(x: x)`
`171`	`171`	`;`
`172`	`172`	`}`
`@@ -183,7 +183,7 @@ class C6b extends self::S6b {`
`183`	`183`	`;`
`184`	`184`	`}`
`185`	`185`	`class D6b extends self::C6b {`
`186`		`- constructor •({core::int x = #C4}) → self::D6b`
	`186`	`+ constructor •({erroneously-initialized core::int x = #C4}) → self::D6b`
`187`	`187`	`: super self::C6b::•(x: x)`
`188`	`188`	`;`
`189`	`189`	`}`
`@@ -247,7 +247,7 @@ class Ap extends core::Object {`
`247`	`247`	`;`
`248`	`248`	`}`
`249`	`249`	`class Bp extends self::Ap {`
`250`		`- constructor •([core::int x = #C4]) → self::Bp`
	`250`	`+ constructor •([erroneously-initialized core::int x = #C4]) → self::Bp`
`251`	`251`	`: super self::Ap::•(x)`
`252`	`252`	`;`
`253`	`253`	`constructor req(core::int x) → self::Bp`
`@@ -260,7 +260,7 @@ class An extends core::Object {`
`260`	`260`	`;`
`261`	`261`	`}`
`262`	`262`	`class Bn extends self::An {`
`263`		`- constructor •({core::int x = #C4}) → self::Bn`
	`263`	`+ constructor •({erroneously-initialized core::int x = #C4}) → self::Bn`
`264`	`264`	`: super self::An::•(x: x)`
`265`	`265`	`;`
`266`	`266`	`constructor req({required core::int x}) → self::Bn`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ class S5 extends core::Object {`
`75`	`75`	`;`
`76`	`76`	`}`
`77`	`77`	`class C5 extends self::S5 {`
`78`		`- constructor •([core::int x = null]) → self::C5`
	`78`	`+ constructor •([erroneously-initialized core::int x = null]) → self::C5`
`79`	`79`	`;`
`80`	`80`	`}`
`81`	`81`	`class S6 extends core::Object {`
`@@ -89,7 +89,7 @@ class C6 extends self::S6 {`
`89`	`89`	`;`
`90`	`90`	`}`
`91`	`91`	`class D6 extends self::C6 {`
`92`		`- constructor •([core::int x = null]) → self::D6`
	`92`	`+ constructor •([erroneously-initialized core::int x = null]) → self::D6`
`93`	`93`	`;`
`94`	`94`	`}`
`95`	`95`	`class S7 extends core::Object {`
`@@ -143,7 +143,7 @@ class S5b extends core::Object {`
`143`	`143`	`;`
`144`	`144`	`}`
`145`	`145`	`class C5b extends self::S5b {`
`146`		`- constructor •({core::int x = null}) → self::C5b`
	`146`	`+ constructor •({erroneously-initialized core::int x = null}) → self::C5b`
`147`	`147`	`;`
`148`	`148`	`}`
`149`	`149`	`class S6b extends core::Object {`
`@@ -157,7 +157,7 @@ class C6b extends self::S6b {`
`157`	`157`	`;`
`158`	`158`	`}`
`159`	`159`	`class D6b extends self::C6b {`
`160`		`- constructor •({core::int x = null}) → self::D6b`
	`160`	`+ constructor •({erroneously-initialized core::int x = null}) → self::D6b`
`161`	`161`	`;`
`162`	`162`	`}`
`163`	`163`	`class S7b extends core::Object {`
`@@ -213,7 +213,7 @@ class Ap extends core::Object {`
`213`	`213`	`;`
`214`	`214`	`}`
`215`	`215`	`class Bp extends self::Ap {`
`216`		`- constructor •([core::int x = null]) → self::Bp`
	`216`	`+ constructor •([erroneously-initialized core::int x = null]) → self::Bp`
`217`	`217`	`;`
`218`	`218`	`constructor req(core::int x) → self::Bp`
`219`	`219`	`;`
`@@ -223,7 +223,7 @@ class An extends core::Object {`
`223`	`223`	`;`
`224`	`224`	`}`
`225`	`225`	`class Bn extends self::An {`
`226`		`- constructor •({core::int x = null}) → self::Bn`
	`226`	`+ constructor •({erroneously-initialized core::int x = null}) → self::Bn`
`227`	`227`	`;`
`228`	`228`	`constructor req({required core::int x}) → self::Bn`
`229`	`229`	`;`